From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16F4EA04B7; Sun, 4 Oct 2020 12:42:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EFB5E1BC92; Sun, 4 Oct 2020 12:42:05 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 9B3011BB9A; Sun, 4 Oct 2020 12:42:03 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id m17so6232026ioo.1; Sun, 04 Oct 2020 03:42:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o+4d5eqoND5xkJTQ53FJ74qpPakzQg8KJN465UOgJzk=; b=YJm8hZTNH3XUEvPWrPtnN12hIOc5rbAKQlW5PzVsL1Dn6mEP/fKhQ4KXLJPz76S3Q2 0fbLqXZaQrKyuXaUrufOZvHFHQR2K8mNq7aKHUIlIVfQiVyS/gj91cYOLM9WFdPKkeLB unhBRd2A+fXnZrEmywGAaYdY+WbmXqKU12dVaOslkJwP+IU19B6l+1DA5dc/9VoIEO+1 aoJhsV9i3Em9nh547BqvspvZGZhfRrQGtXxOhdd1F7L6+lD6GtWBDLw3qBnT1DWw4mQz sbv+p4a+8ptHAs4adOIWT2j3z4AsWIF3piLYUCNccykTaJW3vtmH5AYMMEuBXASrEs3g Ys/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o+4d5eqoND5xkJTQ53FJ74qpPakzQg8KJN465UOgJzk=; b=ZdDQwzu7WJS/W5xQE499wVcZ1GhXrkNCrF3ZvkfLEF/HycbHs/SqNWH3Qw1Md+D2cS Fc7ppty4AIHur+VNYtsu9qgK1fSEJtKeKQ4CNUXQiP78PRVJZaFXHiXcQXw4hLzaXJK9 N5w9YDnH5TtKJWkLWGdCVSaD/wddrQDGjoTigW23Vbf8jbRWrCMZOn23VGvslN2cDSd4 CWJU88bz9SdTzhrEaoXdI/jtWAKYJtnqoZQv6gW3YTA8zPS5592nGNRwRxSQQMxso6ap BB8JSB/Gjao7OAoYWToRvw4LcLhFbNfGAB++ZsJKO6GR8oEoxE159yBAxbnS8Sl6MlyO 7vcQ== X-Gm-Message-State: AOAM530eTXZT4TcpLSyotjAwxlTY2XBOXnaD+qZWEW4gJTepnEhy9Z2C ptTYgezl0FkADzVbf4a/axHm4aoTHAS5ds+pYl8t33FyndE= X-Google-Smtp-Source: ABdhPJwsMxspRNNMBHXCuGEgD3UdaKEGgy6hwZlxA4Xh/Gu6heiBKhwi3WK6F3I2hK+Xqp97J1EkN22dkC1zxe7HVzY= X-Received: by 2002:a5d:9615:: with SMTP id w21mr7467363iol.59.1601808122025; Sun, 04 Oct 2020 03:42:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jerin Jacob Date: Sun, 4 Oct 2020 16:11:46 +0530 Message-ID: To: wangyunjian Cc: dpdk-dev , Hemant Agrawal , Nipun Gupta , "Lilijun (Jerry)" , xudingke , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] event/dpaa2: fix dereference before null check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 26, 2020 at 6:37 PM wangyunjian wrote: > > From: Yunjian Wang > > Coverity flags that 'portal' variable is used before > it's checked for NULL. This patch fixes this issue. > > Coverity issue: 323516 > Fixes: 4ab57b042e7c ("event/dpaa2: affine portal at runtime during I/O") > Cc: stable@dpdk.org dpaa2 maintainers, Please review this. > > Signed-off-by: Yunjian Wang > --- > drivers/event/dpaa2/dpaa2_eventdev.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c > index 3ae4441ee..f7383ca73 100644 > --- a/drivers/event/dpaa2/dpaa2_eventdev.c > +++ b/drivers/event/dpaa2/dpaa2_eventdev.c > @@ -569,14 +569,14 @@ dpaa2_eventdev_port_release(void *port) > > EVENTDEV_INIT_FUNC_TRACE(); > > + if (portal == NULL) > + return; > + > /* TODO: Cleanup is required when ports are in linked state. */ > if (portal->is_port_linked) > DPAA2_EVENTDEV_WARN("Event port must be unlinked before release"); > > - if (portal) > - rte_free(portal); > - > - portal = NULL; > + rte_free(portal); > } > > static int > -- > 2.23.0 > >