From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A65FA051C; Fri, 26 Jun 2020 17:00:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C30231C1D9; Fri, 26 Jun 2020 17:00:29 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 547DF1C1D7 for <dev@dpdk.org>; Fri, 26 Jun 2020 17:00:28 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id c4so10160811iot.4 for <dev@dpdk.org>; Fri, 26 Jun 2020 08:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4DWoWhb2z46jK/FZgvH8jE3jAX1D6jQpq+GgxfM5LOg=; b=WsULzJmdR7BcH2T1GPVFOLNnHUglTFdDb7ZsOEjwIe5v6aK2T/CukVR3kFScQuR1yE MrePQ8n0CZ1XBpjzxqnqsoZNbr/M+fZNQHUfmzNmOZVft1RQNB4xV4qA1jw6CXZZvhEx t/dfE5Pq6oO1qiN2UaXEkztulhLx1Qnyc0LOs1n+liu/k9dxR8BKchzGKDmJvT1Oh6gl nvZCgc6Lu40o5esS95VWZfNX00cDorvq5PgNYojhhloNupODiQ6dfwATQWyT9hutfwjd KtrSYXRlZk11fsDxn7LiN79PeAe9EwQHR4bQs78RdnVx96je9mIi/2poQ99KrOGZ0eb5 WqkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4DWoWhb2z46jK/FZgvH8jE3jAX1D6jQpq+GgxfM5LOg=; b=kf54OkBwqroWsJuxCelfc+7NRRynVcmNvbTpOizQwSPJ9hjuwQzF+Jpt9kD59E+OfU PB2Eh7VDNQEyciyflYpiacZIGFvuApdTvMWzSoyBwClzBtU0Yp8v/l/F3Dc3BJiC33TE Dv0rJxJpaGk6Up52GzxprDnsCDjU48hjPaOPXmkTCvkhcGhcX+PMcHadm0rRhOjXdOFx KUydZD/0HvbwSJMRswTfrlUG5MbjYu9SCrebo/W2gTEaYWO0iF8Kqln0Bv7NrzjH7gRQ 738p5NimLpVneCpm+KEZITV0ku0lsQAIA6MlZazNbkaxHho43pv08wOQfvuMgSXl2neD /8Ng== X-Gm-Message-State: AOAM530h+CvnCpMK64qjhWtUU8yQ3JGVqlnG8MOb0O4Wq622ZLtjWwE2 eOpNwztJebwNvSzGLL3a6Fx70qtyBgdhwR7eO/g= X-Google-Smtp-Source: ABdhPJzdcfD42kOEGfLUWITBzTw7UrYQZZg/TDukZVa+RQmKNeNiQ8r/aLMKC+1lSnDkR4cjA/VLVofekQAXqER0Uac= X-Received: by 2002:a05:6602:2dca:: with SMTP id l10mr3822242iow.163.1593183627682; Fri, 26 Jun 2020 08:00:27 -0700 (PDT) MIME-Version: 1.0 References: <20200610144506.30505-1-david.marchand@redhat.com> <20200626144736.11011-1-david.marchand@redhat.com> <20200626144736.11011-5-david.marchand@redhat.com> In-Reply-To: <20200626144736.11011-5-david.marchand@redhat.com> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Fri, 26 Jun 2020 20:30:11 +0530 Message-ID: <CALBAE1MQCDeCGeE8C8vrRVLYL6TeJWLiWTLPYPBWvDejUgyNeQ@mail.gmail.com> To: David Marchand <david.marchand@redhat.com> Cc: dpdk-dev <dev@dpdk.org>, "Richardson, Bruce" <bruce.richardson@intel.com>, Ray Kinsella <mdr@ashroe.eu>, Thomas Monjalon <thomas@monjalon.net>, Andrew Rybchenko <arybchenko@solarflare.com>, Kevin Traynor <ktraynor@redhat.com>, ian.stokes@intel.com, i.maximets@ovn.org, Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Neil Horman <nhorman@tuxdriver.com>, Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>, Omar Cardona <ocardona@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>, Ranjit Menon <ranjit.menon@intel.com> Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 4/9] eal: introduce thread uninit helper X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Fri, Jun 26, 2020 at 8:18 PM David Marchand <david.marchand@redhat.com> wrote: > > This is a preparation step for dynamically unregistering threads. > > Since we explicitly allocate a per thread trace buffer in > rte_thread_init, add an internal helper to free this buffer. > > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- > Note: I preferred renaming the current internal function to free all > threads trace buffers (new name trace_mem_free()) and reuse the previous > name (trace_mem_per_thread_free()) when freeing this buffer for a given > thread. > > Changes since v2: > - added missing stub for windows tracing support, > - moved free symbol to exported (experimental) ABI as a counterpart of > the alloc symbol we already had, > > Changes since v1: > - rebased on master, removed Windows workaround wrt traces support, > +/** > + * Uninitialize per-lcore info for current thread. > + */ > +void rte_thread_uninit(void); > + Is it a public API? I guess not as it not adding in .map file. If it is private API, Is n't it better to change as eal_thread_ like another private API in eal_thread.h?