From: Jerin Jacob <jerinjacobk@gmail.com>
To: Srikanth Yalavarthi <syalavarthi@marvell.com>
Cc: dev@dpdk.org, aprabhu@marvell.com, sshankarnara@marvell.com,
ptakkar@marvell.com, jerinj@marvell.com
Subject: Re: [PATCH 1/1] ml/cnxk: exclude caching run stats from xstats
Date: Tue, 5 Dec 2023 16:54:36 +0530 [thread overview]
Message-ID: <CALBAE1MR49gEGXdMgddhtYZGTGPRSsDmcYY=8FgAJU3EU6cHYA@mail.gmail.com> (raw)
In-Reply-To: <20231128140400.11921-1-syalavarthi@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 2218 bytes --]
On Tue, Nov 28, 2023 at 10:17 PM Srikanth Yalavarthi
<syalavarthi@marvell.com> wrote:
>
> From: Anup Prabhu <aprabhu@marvell.com>
>
> Exclude the hardware and firmware latency of model data
> caching run from xstats calculation.
>
> Fixes: 9cfad6c334f2 ("ml/cnxk: update device and model xstats functions")
>
> Signed-off-by: Anup Prabhu <aprabhu@marvell.com>
> Acked-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
Updated the git commit as follows and applied to
dpdk-next-net-mrvl/for-main. Thanks
ml/cnxk: fix xstats calculation
Exclude the hardware and firmware latency of model data
caching run from xstats calculation.
Fixes: 9cfad6c334f2 ("ml/cnxk: update device and model xstats functions")
Cc: stable@dpdk.org
Signed-off-by: Anup Prabhu <aprabhu@marvell.com>
Acked-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> ---
> drivers/ml/cnxk/cn10k_ml_ops.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/cnxk/cn10k_ml_ops.c
> index 7f7e5efceac..53700387335 100644
> --- a/drivers/ml/cnxk/cn10k_ml_ops.c
> +++ b/drivers/ml/cnxk/cn10k_ml_ops.c
> @@ -288,6 +288,7 @@ cn10k_ml_model_xstat_get(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_layer *l
> static int
> cn10k_ml_cache_model_data(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_layer *layer)
> {
> + struct cn10k_ml_layer_xstats *xstats;
> char str[RTE_MEMZONE_NAMESIZE];
> const struct plt_memzone *mz;
> uint64_t isize = 0;
> @@ -309,6 +310,16 @@ cn10k_ml_cache_model_data(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_layer *
> PLT_PTR_ADD(mz->addr, isize), 1);
> plt_memzone_free(mz);
>
> + /* Reset sync xstats. */
> + xstats = layer->glow.sync_xstats;
> + xstats->hw_latency_tot = 0;
> + xstats->hw_latency_min = UINT64_MAX;
> + xstats->hw_latency_max = 0;
> + xstats->fw_latency_tot = 0;
> + xstats->fw_latency_min = UINT64_MAX;
> + xstats->fw_latency_max = 0;
> + xstats->dequeued_count = 0;
> +
> return ret;
> }
>
> --
> 2.42.0
>
[-- Attachment #2: image.png --]
[-- Type: image/png, Size: 14470 bytes --]
next prev parent reply other threads:[~2023-12-05 11:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 14:04 Srikanth Yalavarthi
2023-12-05 11:24 ` Jerin Jacob [this message]
2024-01-07 15:19 Srikanth Yalavarthi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1MR49gEGXdMgddhtYZGTGPRSsDmcYY=8FgAJU3EU6cHYA@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=aprabhu@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=ptakkar@marvell.com \
--cc=sshankarnara@marvell.com \
--cc=syalavarthi@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).