From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A711A0547; Wed, 12 Oct 2022 11:45:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9D0642D6E; Wed, 12 Oct 2022 11:45:48 +0200 (CEST) Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by mails.dpdk.org (Postfix) with ESMTP id F2AEA42B6D for <dev@dpdk.org>; Wed, 12 Oct 2022 11:45:46 +0200 (CEST) Received: by mail-qk1-f179.google.com with SMTP id b25so4242056qkk.7 for <dev@dpdk.org>; Wed, 12 Oct 2022 02:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hxXryGa0Ql2UlMBJ/Bl6XiksvKYBU8iwJ+FVom90YjE=; b=lgoAg5xeUN1ZRdGrTKHyABHJkctogMp1oMbQARlHgSK8lVS1higq0UZaGAwOGj7R9b ExeVhpjNeawsn1uXdZyV1j+ueLhgE+Jxt4Ih6hth1dgKF3nE2kZwbaqZoXfV2iYT9WYt Mwl/6M+HzMi8+a9kjaRoL6Ak9lvCofI74Pg9Gl9GRUPHDgP9hbt628YLtagumWagxwsj VsucIsowh3gZGrVJdGPtXl7pDBtTHbuo6ixXJXJ1KFogqtgDjkoBBCmRgF9WY+Gx8/Ym MKcDRtzgf5r3dKovW2X+/9tSft8blX/2rvmE2VkVVeHQGHmKxQAD081/DLGMRy7G3jfi 2vjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hxXryGa0Ql2UlMBJ/Bl6XiksvKYBU8iwJ+FVom90YjE=; b=HO+o3vvFBwkyJRFBeOGTOepTEvW+LtBaHmO/X9CQmm2/QReZA/XzBtQ6DuWMHhcoyZ //C0EsJ259lgGWuFZn/rdqCFmyNFi02ervibmrvVefxqCPy6iEY8KCSOZUZfPRMIT8yv WFeYoDM6A5HcW+xOxKDwvu3GQWPzoWQSQPchpCPKpVBiLH5dDuDiR7PBD+vXHt94OtCA c/HKuWfDcmUw3EOEQfZaQ2Zo9Ytnml371KZWJGDbfM0xsO6+PYkptCgmLo05mfkj25oG /u5wBOXHtJbeRlc15aPGsETtIJmuxAKI3pHThCRw8nw+x3rPMJzXx0PmqQKTVd2HeFPe 326w== X-Gm-Message-State: ACrzQf3nZAbVRbs/iUSVsYOBm5THEuHJHyLUzGq+hSYOXob60aF053OX AGeMV4S41vjuDp9u3hDSdLaAMPcusLrTUCU9QR6m1cQ8fso= X-Google-Smtp-Source: AMsMyM6J1SWfHxastYhOb5x673+GGjUg6KuK2Jq89HqdG+OL6t+rHbX+cwmKDEJOX1vg0kuOjb9SJ5BNJkcysxfl/W4= X-Received: by 2002:a05:620a:1986:b0:6ec:fc63:1dce with SMTP id bm6-20020a05620a198600b006ecfc631dcemr10136510qkb.90.1665567946349; Wed, 12 Oct 2022 02:45:46 -0700 (PDT) MIME-Version: 1.0 References: <98CBD80474FA8B44BF855DF32C47DC35D873D4@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D873D4@smartserver.smartshare.dk> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Wed, 12 Oct 2022 15:15:20 +0530 Message-ID: <CALBAE1MSDYbKXEgafT9_j-mCt0p5PrpM8skgZx_O_L=1DPbsGQ@mail.gmail.com> Subject: Re: rte_event_dev_xstats_reset id type To: =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>, "Van Haaren, Harry" <harry.van.haaren@intel.com> Cc: Jerin Jacob <jerinj@marvell.com>, dev@dpdk.org, "Li, WeiyuanX" <weiyuanx.li@intel.com>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Wed, Oct 12, 2022 at 1:40 PM Morten Br=C3=B8rup <mb@smartsharesystems.co= m> wrote: > > Hi Jerin (eventdev maintainer), + harry.van.haaren@intel.com as the changes in drivers/event/sw. > > While looking into bug #1101 [1], I noticed a mix of unsigned int and uin= t32_t in the test code, which will fail on 64-bit big endian CPUs. > > Specifically, rte_event_dev_xstats_reset() is called with the "ids" param= eter pointing to an unsigned int [2], but that parameter is a pointer to an= uint32_t. > > I think the type of the ids array parameter to rte_event_dev_xstats_reset= () should be changed to unsigned int array, like in the other rte_event_dev= _xxx() functions. > > Or even better, use the same type for an "xstats id" across all device ty= pes. For ethdev devices, they are uint64_t, but I don't know why. (They are= passed around as arrays, so they could be 32 bit. I guess that they were o= riginally not used in arrays, so unsigned int seemed the logical choice.) > > > [1]: https://bugs.dpdk.org/show_bug.cgi?id=3D1101 > [2]: https://git.dpdk.org/dpdk/tree/drivers/event/sw/sw_evdev_selftest.c#= n1766 > > > Med venlig hilsen / Kind regards, > -Morten Br=C3=B8rup >