From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90EFBA0547; Mon, 21 Jun 2021 15:42:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2234C41158; Mon, 21 Jun 2021 15:42:01 +0200 (CEST) Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by mails.dpdk.org (Postfix) with ESMTP id 065B640040 for ; Mon, 21 Jun 2021 15:42:00 +0200 (CEST) Received: by mail-il1-f175.google.com with SMTP id h3so15284567ilc.9 for ; Mon, 21 Jun 2021 06:41:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yJjN28Vgyo1zM4YD/i85BG0g0wmAZnt4FgPgyqWrLVM=; b=lKB8vscmJLW+0JvF1I8/mvMti51VJDBTsmKzFEqLOuFM2cqCl+XSFCzRKlMjCK+P3o XwW1tDDVuMEy4jVIbC/1BOhDA7oiraXv2yrWpmFeiZHLxi4mEX2/svdWRHtA/j0cPC5Y I+oBWr9WGPBAGT580QwqhgFZ241SLqx3A5TwCXDHbRH/Gt3/+F3uPEy+Lre7Qd+Kwve6 /S+vy7+6QB6d1rwVvATFWM0E3axvgbS31Q0QQhNj3PMtsYX7JgtZpU+3NenEXz/GtKMW /WWsbiv3SWrg41DiLBC8Ru3FHPfLOm61aIBPt1ytiUe0kDQNnYlwSuUOIJezH60ed/LV qCEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yJjN28Vgyo1zM4YD/i85BG0g0wmAZnt4FgPgyqWrLVM=; b=ZYluiBogP2Gh8+h3PX4e93Y7tHHT0z9DdOAKOv0Ry0DbUW5h2mMDXR9aCbpmLqzui3 D+X3Jmt9Z+NqOz8eh8rAAC9yyptT0ocwA9kugZ6BvVkpHPcpbsO1tkuokYmg3aAUY9HO BnfA2BLbFzCeFBzgWyqfXSmYFxiCZyTDr98mBM/h5w4Hj4cfJcaQMebkbZcblLWUHHqq /JrF22yjEdEu/rRa7lO2L4NiXBWSl/flNWn1jeqr+xad5zFgrwlUHisp0yzJD5xO3ifh lK7ZO1YP79yVkP/gQWbAkPEMOAJW9+7IWt8ahWxBcMhNEBJISLh3oTHTyCY01PNpQwML Xeug== X-Gm-Message-State: AOAM532ZPLw7qWReMbV/w/H+kpk5VOZn0BlAwVn9fmg6nxqJi4ghgWuJ pv/oz+qC2G07vV4JKI1uavY/RGNCa7/FPtpo8ZY= X-Google-Smtp-Source: ABdhPJw5pY0ZqbdwTjJ1brO19hxG9K3dKb3NM1s2k9hSp5tmrzM3oNgzOVZVkVJaX9m823IOZAtfADlt/WKcegexu2k= X-Received: by 2002:a05:6e02:b4f:: with SMTP id f15mr7542610ilu.162.1624282919245; Mon, 21 Jun 2021 06:41:59 -0700 (PDT) MIME-Version: 1.0 References: <20210306153404.10781-1-ndabilpuram@marvell.com> <20210618103741.26526-1-ndabilpuram@marvell.com> In-Reply-To: <20210618103741.26526-1-ndabilpuram@marvell.com> From: Jerin Jacob Date: Mon, 21 Jun 2021 19:11:33 +0530 Message-ID: To: Nithin Dabilpuram Cc: dpdk-dev , Jerin Jacob , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Pavan Nikhilesh , Kiran Kumar K , Satheesh Paul , Ashwin Sekhar Thalakalath Kottilveetil , Harman Kalra Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 00/62] Marvell CNXK Ethdev Driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 18, 2021 at 4:09 PM Nithin Dabilpuram wrote: > > This patchset adds support for Marvell CN106XX SoC based on 'common/cnxk' > driver. In future, CN9K a.k.a octeontx2 will also be supported by same > driver when code is ready and 'net/octeontx2' will be deprecated. Looks good to me in general, a couple of final comments 1) Build issue with RHEL 7 (gcc 4.8) http://mails.dpdk.org/archives/test-report/2021-June/199620.html 2) Shorten git subject messages( for explicit "add" etc) Example: From: net/cnxk: add DMAC filter support to: net/cnxk: support DMAC filter 3) Add Cc: stable@dpdk.org for following patch common/cnxk: fix batch alloc completion poll logic 4) Fix following camel case CHECK:CAMELCASE: Avoid CamelCase: #92: FILE: drivers/net/cnxk/cnxk_ethdev.c:122: + if (roc_model_is_cn96_Ax() && 5) Replace INTERNAL in drivers/net/cnxk/version.map 6) Add [rte_flow items] and [rte_flow actions] in doc/guides/nics/features/cnxk_vec.ini and doc/guides/nics/features/cnxk_vf.ini