From: Jerin Jacob <jerinjacobk@gmail.com>
To: Naga Harish K S V <s.v.naga.harish.k@intel.com>
Cc: erik.g.carrillo@intel.com, jerinj@marvell.com,
pbhagavatula@marvell.com, sthotton@marvell.com, dev@dpdk.org
Subject: Re: [PATCH v2 1/4] eventdev/timer: add periodic event timer support
Date: Tue, 13 Sep 2022 17:37:46 +0530 [thread overview]
Message-ID: <CALBAE1MSicYoAqW3GzxmqWmzJCLbOVsiMWH2_-RLV2TYc6J-ww@mail.gmail.com> (raw)
In-Reply-To: <20220810070116.3110427-1-s.v.naga.harish.k@intel.com>
On Wed, Aug 10, 2022 at 12:31 PM Naga Harish K S V
<s.v.naga.harish.k@intel.com> wrote:
>
> This patch adds support to configure and use periodic event
> timers in software timer adapter.
>
> The structure ``rte_event_timer_adapter_stats`` is extended
> by adding a new field, ``evtim_drop_count``. This stat
> represents the number of times an event_timer expiry event
> is dropped by the event timer adapter.
1) Please remove depreciation from
doc/guides/rel_notes/deprecation.rst for above chage
2) Please squash "event/sw: report periodic event timer capability"
with first path and update the comments.
Rest looks good to me. Good to merge the next version.
next prev parent reply other threads:[~2022-09-13 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 7:01 Naga Harish K S V
2022-08-10 7:01 ` [PATCH v2 4/4] test/event: update periodic event timer tests Naga Harish K S V
2022-09-13 12:07 ` Jerin Jacob [this message]
2022-09-14 5:16 ` [PATCH v2 1/4] eventdev/timer: add periodic event timer support Naga Harish K, S V
-- strict thread matches above, loose matches on Subject: below --
2022-08-03 16:25 [PATCH " Naga Harish K S V
2022-08-10 7:07 ` [PATCH v2 " Naga Harish K S V
2022-08-10 19:55 ` Carrillo, Erik G
2022-08-11 15:43 ` Naga Harish K, S V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1MSicYoAqW3GzxmqWmzJCLbOVsiMWH2_-RLV2TYc6J-ww@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=s.v.naga.harish.k@intel.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).