From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50C99A04B1; Tue, 10 Nov 2020 15:08:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 252832B9D; Tue, 10 Nov 2020 15:08:24 +0100 (CET) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id DD5F1F64; Tue, 10 Nov 2020 15:08:20 +0100 (CET) Received: by mail-io1-f66.google.com with SMTP id r12so14158623iot.4; Tue, 10 Nov 2020 06:08:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HmNXvdXR4YW6sTIhcfjSXlQjJF/4wZPkQw9AarRK77s=; b=KtxXjgtXFdc7dTN63JkRySKzRuPdKbusShLU4mUoi9A8nQk+9hTY4KPhdshEeFtYW1 FkOV2yxeVZK5n+aReMqsuSVS7RVJWyawgDu8yYTZlq+T7IN9bFDptL1u5Cwawz802fgX XwH7HrkgZW5BIdOJo3P5KPtVYDvhBqs2rwykRyVMz4r8agUX+61AO4y4gjXdlFaM2sI0 lVxiNxZw5wZE0WmlbkBi4JOPlRDRPDqcuAHusMB9wWizBfWMj01IqU81Z+aTVInMo6lb iYRhmMZBQnNY1F3TO4kxMf1aowl06JYgipp4NcH/OFc8to2aljBhzqpIQXZLi7hK4rOp IAIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HmNXvdXR4YW6sTIhcfjSXlQjJF/4wZPkQw9AarRK77s=; b=iH5CdVQr7lT24TWLczffV7kOYGcQwxrY8CgKvbmBKpIe9GmkyfbQfwybK3rmauzA4e S4luZVnASDjxxFcfH/1JzrNlKYZrywGDF9WErDXH1vwnoNvpbyXpos2r5BYfIkoA+Vyb vf5fFSEWP2U1oXJNuYILz83bPzWoSVrL04EB1A4/9LGXXMRxAX6xoD9xyB1osvJHnNHe K5JnVMe9Z+VlYEhAN4lHixgqbjBqGQOv65yx956nUWL+DEcTcRPJ2+70YAIl6noz0lfa C3mZmoeFNDmhvekDHrFD+BovAP9WzeYWKBOj4KZo6LqtbDhR0FERDGX+b1rAWc8HdUzC fkFw== X-Gm-Message-State: AOAM533pFLhPshQLnYkp5Hrs5QkucJxDNBm7uaUe/VDr7p4HGTmtoPfj poFyjIeCDmr2WZLwhGtub/NSYP4/VQcn6s+afyk= X-Google-Smtp-Source: ABdhPJxhjFk8p/3Qwa2EhSb0gfiCAjdUZ5k1g9dwLefP3T9A/bTvOg/dZ9Be6X9F2lic0kVj6hiOQhOBrIH/3rA4aY0= X-Received: by 2002:a05:6638:10d0:: with SMTP id q16mr14925939jad.113.1605017299190; Tue, 10 Nov 2020 06:08:19 -0800 (PST) MIME-Version: 1.0 References: <20201109210009.919129-1-thomas@monjalon.net> <20201110101419.GB1641@bricha3-MOBL.ger.corp.intel.com> <2429206.vUhvlFYDAN@thomas> <20201110112044.GD1641@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201110112044.GD1641@bricha3-MOBL.ger.corp.intel.com> From: Jerin Jacob Date: Tue, 10 Nov 2020 19:38:03 +0530 Message-ID: To: Bruce Richardson Cc: Thomas Monjalon , dpdk-dev , Ferruh Yigit , David Marchand , dpdk stable , Luca Boccassi Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 10, 2020 at 4:51 PM Bruce Richardson wrote: > > On Tue, Nov 10, 2020 at 11:45:52AM +0100, Thomas Monjalon wrote: > > 10/11/2020 11:14, Bruce Richardson: > > > On Mon, Nov 09, 2020 at 10:00:08PM +0100, Thomas Monjalon wrote: > > > > PKG_CONFIG_PATH is specific to each target, so it must be empty > > > > before configuring each build from the file according to DPDK_TARGET. > > > > Inheriting a default PKG_CONFIG_PATH for all targets does not make sense > > > > and is prone to confusion. > > > > > > > > DPDK_MESON_OPTIONS might take a global initial value from environment > > > > to customize a build test from the shell. Example: > > > > DPDK_MESON_OPTIONS="b_lto=true" > > > > Some target-specific options can be added in the configuration file: > > > > DPDK_MESON_OPTIONS="$DPDK_MESON_OPTIONS kernel_dir=$MYKERNEL" > > > > > > > > Fixes: 272236741258 ("devtools: load target-specific compilation environment") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Thomas Monjalon > > > > --- > > > > > > Patch looks fine, but I think the log (and comments in the code too, > > > perhaps) should make it clear that the PKG_CONFIG_PATH can be set in the > > > local config file, to make it available to the script. > > > > OK, I'll look at improving the "doc". > > We could also provide a template for the config file. > > > Acked-by: Bruce Richardson Tested-by: Jerin Jacob >