From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 615E3A0032; Tue, 13 Sep 2022 15:54:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF03E40E50; Tue, 13 Sep 2022 15:54:55 +0200 (CEST) Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) by mails.dpdk.org (Postfix) with ESMTP id B0A5C40151 for ; Tue, 13 Sep 2022 15:54:54 +0200 (CEST) Received: by mail-qv1-f43.google.com with SMTP id c6so9209579qvn.6 for ; Tue, 13 Sep 2022 06:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=ei/+LXrpFFbYN41Nt4Qyk+QSXnBCYSRoTs2DPdMnek0=; b=OEoV5GGNJsqRZYa7zn+jDBQmH1daZRJS5kmY9BOORWn9Zua+EQW0dN+yB8BWKTrSS1 GZTGZG4ubRVglmfjLNc21M2yYYk6KQdKFsJg7pb9dj1voRZyNx8u+AwQEGsfqGT0/Rc+ HQDBEn7SbQjdHmLjlX4bhUfUqqu2JsmWanPw+4Z4BVH37CdEluuz0g/DlspvkNjxLz52 HVimi2/1KkUvzDhrhxWuxorSE/q4iGSSgANdCM63TLefcSTe3OpD9nDttiZYUSlm6iGG Ux5ERdmwYSvP2q5znkaCEfoL/3EJV3Sa0TAqfEC8T6AJHNOd52tOw9WfusVbQPaMSBq8 tQTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=ei/+LXrpFFbYN41Nt4Qyk+QSXnBCYSRoTs2DPdMnek0=; b=7zpZmqcklwNbtlktfb8iLo1Jq13NN2I4sBgYmSVS5afXXf6iy5c+xT1Ykh91MB1J+J zdXdtSPz0aq0Lb3DmKI2v5JKNNFv28eJWtRiGLIQ+wx3DpHQDeiz9JvSo0/Kp0mVcA/w Wqy9P6zg3yaP8/mnw5Utvhv7RAlc7nTF85tGbN27hcqOlspsKsbCM3tSYxBEzrjboaLH e/TiUq69VqKUGjQCRiTcutGWVHn8+FIojRJgf8JL9paRPCObDVxW3E9mY2V5W2tEDOIb +Q5yUwlRIKONcqbGbIRvcqFejP/Oy7A4DyC4WoGYUWD78TQAQIDm9oIZaLSjuaZnotfm 1xcw== X-Gm-Message-State: ACgBeo1oc/UVr3y0C0NeqXY7hLfFTT+Ey9ZrGfNT5nX2sHlWeB/ahyDC h619IMkBO5QOFkxeJMXeDPfFEbB61PpaDoUdGRc= X-Google-Smtp-Source: AA6agR7RMTNeVjTArBa2Hx7Df/I4vslg02e5YilLZ2JoBV9q9f9Tqj+TRwgDk42nEtT6s2tbegzS1bW9Vgw39MtDKqU= X-Received: by 2002:a05:6214:c89:b0:4ac:bb5b:fe94 with SMTP id r9-20020a0562140c8900b004acbb5bfe94mr6251550qvr.11.1663077293960; Tue, 13 Sep 2022 06:54:53 -0700 (PDT) MIME-Version: 1.0 References: <20220713152848.160523-1-stephen@networkplumber.org> In-Reply-To: <20220713152848.160523-1-stephen@networkplumber.org> From: Jerin Jacob Date: Tue, 13 Sep 2022 19:24:28 +0530 Message-ID: Subject: Re: [PATCH] app/test-eventdev: remove unnecessary memset To: Stephen Hemminger Cc: dev@dpdk.org, Jerin Jacob Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jul 13, 2022 at 8:59 PM Stephen Hemminger wrote: > > The function rte_event_dev_info_get already zeros the info structure. > Therefore the test code doesn't need to do it. > > Signed-off-by: Stephen Hemminger Acked-by: Jerin Jacob Applied to dpdk-next-net-eventdev/for-main. Thanks > --- > app/test-eventdev/test_order_common.c | 1 - > app/test-eventdev/test_perf_atq.c | 1 - > app/test-eventdev/test_perf_queue.c | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/app/test-eventdev/test_order_common.c b/app/test-eventdev/test_order_common.c > index 603e7c9178bc..6f00f2448a24 100644 > --- a/app/test-eventdev/test_order_common.c > +++ b/app/test-eventdev/test_order_common.c > @@ -328,7 +328,6 @@ order_event_dev_port_setup(struct evt_test *test, struct evt_options *opt, > struct test_order *t = evt_test_priv(test); > struct rte_event_dev_info dev_info; > > - memset(&dev_info, 0, sizeof(struct rte_event_dev_info)); > ret = rte_event_dev_info_get(opt->dev_id, &dev_info); > if (ret) { > evt_err("failed to get eventdev info %d", opt->dev_id); > diff --git a/app/test-eventdev/test_perf_atq.c b/app/test-eventdev/test_perf_atq.c > index 5436a9b06cd8..8326f540459f 100644 > --- a/app/test-eventdev/test_perf_atq.c > +++ b/app/test-eventdev/test_perf_atq.c > @@ -212,7 +212,6 @@ perf_atq_eventdev_setup(struct evt_test *test, struct evt_options *opt) > > nb_queues = atq_nb_event_queues(opt); > > - memset(&dev_info, 0, sizeof(struct rte_event_dev_info)); > ret = rte_event_dev_info_get(opt->dev_id, &dev_info); > if (ret) { > evt_err("failed to get eventdev info %d", opt->dev_id); > diff --git a/app/test-eventdev/test_perf_queue.c b/app/test-eventdev/test_perf_queue.c > index 5ef2e5a3ef9c..814ab9f9bd86 100644 > --- a/app/test-eventdev/test_perf_queue.c > +++ b/app/test-eventdev/test_perf_queue.c > @@ -215,7 +215,6 @@ perf_queue_eventdev_setup(struct evt_test *test, struct evt_options *opt) > > nb_queues = perf_queue_nb_event_queues(opt); > > - memset(&dev_info, 0, sizeof(struct rte_event_dev_info)); > ret = rte_event_dev_info_get(opt->dev_id, &dev_info); > if (ret) { > evt_err("failed to get eventdev info %d", opt->dev_id); > -- > 2.35.1 >