From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01B1FA0597; Thu, 9 Apr 2020 15:48:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 401581C25A; Thu, 9 Apr 2020 15:48:12 +0200 (CEST) Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by dpdk.org (Postfix) with ESMTP id 8D1661C246 for ; Thu, 9 Apr 2020 15:48:11 +0200 (CEST) Received: by mail-io1-f41.google.com with SMTP id f3so3902890ioj.1 for ; Thu, 09 Apr 2020 06:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nOc+iD69rYg3iQ4bLZIpE/nCxLu7p+qNtkyecScvVrI=; b=gJPYZx7TNJTlTb6U2ABogw7sClMHdeQK+7H64lIDH8gw0Z3XCJ/U4+5SebT5PrRcc6 wt/GJTJAy5sYsCJfLbb41CZzI30EInAd2qQHrl62bO34CbPJTlk4NF7OUuaq2R0ZPCJm YQgbBIGs4pVXvjqAzZc1xTd5oyCfeNQNn55gLDiLs2sFcmiTvfS64RDxYKc99j3ZaNyv 11IQhfc0YeFMYgYx1Ol5eoslYjg+3RM5frwlr3T6e3Tdz3H0nqz/PcSXAx7AMX6k6Qx2 W7TJHWc39uWL9Aw9l2OSn0NqrdSLNLdcKhHcXyqXB93+VhLe54KKyP4Dov2d2wT4In7D 2lDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nOc+iD69rYg3iQ4bLZIpE/nCxLu7p+qNtkyecScvVrI=; b=G4x1xj6kkopq8YqMwH9pR6J5rV8Bn0vFCgy7nOa8O9FH7mK8rkwOrN/wJc9QtZHjl9 A0SZ+/jszLDxnHalDCUiKIhjbUb5h89nVdpZVvV/1sIndZlrAJ1wotJpvSiROgXNQzSB B9hLx7h6MOJw7Ij3Ia59Ge3390U04/wFHvreVeBBtLqHzmTcWmkGyy0H1TUa3EoyRNHL G3aqPKxYtNWaMQ/RX0ZvX5XQ2EyIBwZHKDw+JTtPT/AdJqgyWgefUP+9AQ7Y5tg2qGen IOHdslx+V3iFIxWF3NaH3zZg5LI0szNQQQAjaeZZrHCphcmei1feNRBpFSe280G5OlVA Z/aA== X-Gm-Message-State: AGi0PuYOa9slqz8uRdDNWxfXKZJRR57rUgiPRNbj451pz//KZgB6yBLT qtgEt0+L0/44jrIX3Le9zWPnvQ7YkxQYnwG+qDM= X-Google-Smtp-Source: APiQypIJtevXxEcN12ltWMZu/axhLzJ71uKR36192xkmZqTbfTmcdQBK6cWs9gIQzdkP1gZcC1U2dIslkEcCMbQ3uR8= X-Received: by 2002:a5e:de05:: with SMTP id e5mr12019385iok.1.1586440090785; Thu, 09 Apr 2020 06:48:10 -0700 (PDT) MIME-Version: 1.0 References: <0e082fc8-c60c-f62b-ef22-4b453e193567@intel.com> <6233579.4vTCxPXJkl@thomas> In-Reply-To: <6233579.4vTCxPXJkl@thomas> From: Jerin Jacob Date: Thu, 9 Apr 2020 19:17:54 +0530 Message-ID: To: Thomas Monjalon Cc: Ferruh Yigit , dpdk-dev , David Marchand , Olivier Matz Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] DPDK Release Status Meeting 9/04/2020 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 9, 2020 at 7:06 PM Thomas Monjalon wrote: > > 09/04/2020 15:10, Jerin Jacob: > > > * tracing library > > > * Some concerns on the API, it is copy/paste of log API > > > > The following API signatures are taken from log API. > > > > 1) void rte_trace_global_level_set(uint32_t level); > > 2) uint32_t rte_trace_global_level_get(void); > > 3) uint32_t rte_trace_level_get(rte_trace_t trace); > > 4) int rte_trace_level_set(rte_trace_t trace, uint32_t level); > > 5) int rte_trace_pattern(const char *pattern, bool enable); > > 6) int rte_trace_regexp(const char *regex, bool enable); > > > > I have intentionally kept public API similar to rte_log wherever it is > > possible. Reason being, > > > > 1) In the future, it is easy to replace rte_log with trace _if needed_. > > 2) Avoid the new API learning curve. > > 3) I did not find anything wrong with the existing log API to improve > > on at least on API that selected to copy the prototype. > > > > If there are specific comments on why we need to take the deviation > > from log API on the above schematics. I am happy to change it. > > Please remove global level. Any specific reasoning? > We'll try to remove it from rte_log as well. Currently, In the log library, when EAL command-line argument specifies the "--log-level=x" it will call the rte_log_global_level_set(). Is the suggestion to make rte_log_global_level_set() as an internal EAL API or remove that feature? If we remove, then I dont know, how we can map --log-level or --trace-level EAL command-line argument. > Let's continue discussion in the patch thread. Yes. Please. Inline comments in the trace library code helps. > > >