From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE6FFA0547; Wed, 28 Jul 2021 08:08:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B27240E64; Wed, 28 Jul 2021 08:08:41 +0200 (CEST) Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by mails.dpdk.org (Postfix) with ESMTP id 3205940142 for ; Wed, 28 Jul 2021 08:08:40 +0200 (CEST) Received: by mail-io1-f44.google.com with SMTP id h1so1618912iol.9 for ; Tue, 27 Jul 2021 23:08:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CIKPPPVGf5Ob4pz0HUqMSIunkLJm664oX4aIc4gsPhE=; b=c9MvTsCXGgaYaC0342rksuJypnM9Q5z8jNMJVWNa/xKqDe8592zQYsVlDkEPXc6WZW LcLcs/fljsDRoGMhKXnGLnHF8rk8JZdBKjHM+VNSmlV6XbeAn95QUxIMtG4U9jvA9MKD HuNzPKVrPEjclbMtnvjZV2iLRK3Jx0Ej+WOB+R2XuWy3+bolJ36tHRVJ2YEbMvssLpmT 1NGZUI/O7G8w0hkvuzdrIAedpcF52aFlnwncaF9yjubptnA3+9Gd4D2lEtRpt3BM1822 EuTtLbG/nQoNUthpfGNxvn/wl/s/jorXm/TJthPZ+3EZlLxbf8X56ZXelUHP7Pqm8YZD GfNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CIKPPPVGf5Ob4pz0HUqMSIunkLJm664oX4aIc4gsPhE=; b=lrw1jID1avJXkp7CYhFpfZAEAx+fN3VlmAPdzDdZ79kiVWa0Rz+/t3oml9+Ddbsp7v GPTByllq8P5pXRhrfjKZAHh+KtqJ/0pQMiNgBpGmeXJ0vxbPeHwXdDe5yL7BCcrx7FIe NZP7aLS9yLToouJ08ArQyqQCUzZ9WsRqZZTOklSbnei/9SsiT2ZZFwUWL1sNn2+lfOl7 s+UptDkDA5yu0u7i8MYGqJThTL4r6+n8NA93mPAcsM5WZEB9Ay6Lr17gkDzSybXuwppb etOXE/6yU8KNHG2pH4bTvJL+8YoR+X7OdEes5HYO1vP+6XVpTo8dhu11WbMkfDm+eU8e 0uVg== X-Gm-Message-State: AOAM530AkV8fH1AGKroCMry2OAgINpA+sgIfy9uYV6t4ZB3OvukjDUE1 D/xp0iqxryt0x4VoCLM4HDZoJPAEocZli3+95zU= X-Google-Smtp-Source: ABdhPJwINZkGVpPu8oCfYkAGZaYzdM5NWzhu4s20+WCSDOToJMj4T6Z2CPpkbqAmjC4b81V1F9PkZTGwUyp58MSrDdw= X-Received: by 2002:a05:6638:388e:: with SMTP id b14mr24721658jav.113.1627452519517; Tue, 27 Jul 2021 23:08:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jerin Jacob Date: Wed, 28 Jul 2021 11:38:13 +0530 Message-ID: To: "Kundapura, Ganapati" Cc: dpdk-dev , "Jayatheerthan, Jay" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] RFC: Enahancements to Rx adapter for DPDK 21.11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 26, 2021 at 6:37 PM Kundapura, Ganapati wrote: > > A gentle ping for comments. > > -----Original Message----- > From: dev On Behalf Of Kundapura, Ganapati > Sent: 23 July 2021 12:33 > To: dpdk-dev ; Jerin Jacob ; Jayatheerthan, Jay > Subject: [dpdk-dev] RFC: Enahancements to Rx adapter for DPDK 21.11 > > Hi dpdk-dev, > > We would like to submit series of patches to Rx adapters that will enhance the configuration and performance. > Please find the details below. > > (1) Configure Rx event buffer at run time > Add new api to configure the size of the Rx event buffer at run time. > This api allows setting the size of the event buffer at adapter level. Since we can change ABI for 21.11, Not prefer to add a new API instead add a param to config structure. Please send the deprecation notice for ABI change. > > (2) Change packet enqueue buffer in Rx adapter to circular buffer > Rx adapter uses memmove() to move unprocessed events to the begining > of packet enqueue buffer which consumes good amount of CPU cycles. Looks good. > > (3) Add API to retrieve the Rx queue info > Rx queue info containinin flags for handling received packets, > event queue identifier, schedular type, event priority, > polling frequence of the receive queue and flow identifier Looks good. Please implement it as adaptor ops so that it can be adapter specific to support HW implementations. > > (4) Add adapter_stats cli to retrive Rx/Tx adapter stats and rxq info > This cli displays Rx and Tx adapter stats containing recieved packet count, > eventdev enqueue count, enqueue retry count, event buffer size, queue poll count, > transmitted packet count, packet dropped count, transmit fail count etc and rx queue info. Generally, we don't entertain CLI in the library. You can add command-line arguments to app/test-eventdev to test this. > > (5) Update Rx timestamp in mbuf using mbuf dynamic field > Add support to register timestamp dynamic field in mbuf > Update the timestamp in mbuf for each packet before eventdev enqueue Cool. > > We look forward to feedback on this proposal. Once we have initial feedback, patches will be submitted for review. > > Thanks, > Ganapati