From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 835B9454DE; Mon, 24 Jun 2024 11:13:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F7454026E; Mon, 24 Jun 2024 11:13:57 +0200 (CEST) Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by mails.dpdk.org (Postfix) with ESMTP id 0EFAD4014F for ; Mon, 24 Jun 2024 11:13:56 +0200 (CEST) Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-44054a2c153so18451651cf.2 for ; Mon, 24 Jun 2024 02:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719220435; x=1719825235; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yoEP3pGyGX5kNtnOdarXnSDwYBdrpDY442c+PUD2Gwo=; b=iGMZcz2TvWch5d61aonZn4WkvFe3qGv9AwWdlP1OAzaIHD1U8/UZsavu4wcYu/+0Ev dB+BBp/AWGpLMQuhgDRbvV62fNIFb9DBIEKuVvOhx46nmYCmL/ScU0bYPqp9coZrLtRG DhCvxGUwUKr0NXUgVvcvcpr/yf7wjQMA7jgKjfHQCxPemafFVBrey4eV2dvNmd+mdzAR BGWGtyDb7Y9iGFYX+ZN49wvl9A3bFNWWTb9P9qviWp+EMK/XZdOZOvpFH+kkFisGRcut unvhD6ktinJHzCrCT19qOcLXKSmU5wfSR+Hu16kD+1uRhYAFeilcBAuhHbRX9OYKipIk n1aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719220435; x=1719825235; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yoEP3pGyGX5kNtnOdarXnSDwYBdrpDY442c+PUD2Gwo=; b=mdjrcr65INl/ADKfQPq+n9jFD4NNooSctmfCbTREKWrdCMN1aYUrlsa9RNYWymOz2z KmfSxnKVnyWT/SjvJzJ8VibDujLpsAK6rCV+FojQ3g46bs8DDwLum76M9R1rFf7KT+2d 9/mktzcOyJREMR/7SXQeBvVBj9d1A0HBXA4XYgFKhoBIXnPnOyTUMOplPaOkzdgGPk0B wUv084vQ6O5o9100IGI7C9HsMv1lFh0TBimP1v7fqEXR2OxDqeXhrdZFB8mPyXwUthPb rmf3K42NzZD79vb+sLQtRVWngzHysZstnz/pp1NOrvz1owrZqm4prA4lb/iD1N7HdR1w EmCA== X-Forwarded-Encrypted: i=1; AJvYcCUOItliyg2af4abBOVh0bYAvNs6veMg89AZQ7HHpDfRWLX/IGYEOrBsI1p26uFEK4wfWKhdDwfAznDYt+M= X-Gm-Message-State: AOJu0Yx+nlmMXSd6+JF2BkrH06e9A1DtsvoRXyNCR3T8HlcsiN/bk1CA MXCecYXs9u3s84KNes0ZePtAZJqfXW2YbjvqAOoldL5Dh/Mofb7o6e2vesf+tkDZu12bfllO+W6 pCG/8D/Uq4ekgLvtGOCUUSCc5za4= X-Google-Smtp-Source: AGHT+IHck7O5abMbFO9JK5H0ZeIDeCX/Sq0RBG4i5vkXUNSzPtiLF4hkHODcXh1PMn6j7BDoSEWNgbaaQFzHoBZcito= X-Received: by 2002:ac8:5906:0:b0:43a:f578:23c6 with SMTP id d75a77b69052e-444d9227aecmr42362971cf.59.1719220435185; Mon, 24 Jun 2024 02:13:55 -0700 (PDT) MIME-Version: 1.0 References: <20240624074822.88955-1-hkalra@marvell.com> In-Reply-To: <20240624074822.88955-1-hkalra@marvell.com> From: Jerin Jacob Date: Mon, 24 Jun 2024 14:43:29 +0530 Message-ID: Subject: Re: [PATCH 1/6] net/cnxk: stale offload flag reset To: Harman Kalra Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dev@dpdk.org, jerinj@marvell.com, Amit Prakash Shukla Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 24, 2024 at 1:19=E2=80=AFPM Harman Kalra w= rote: > > From: Amit Prakash Shukla > > mbuf buffer is not reset on tx and hence few fields has stale data from > previous packets. Due to stale offload flags, in one of the scenarios > with OVS, VxLAN offload flag was set while packet did not have the VxLAN > header. In the OVS packet path, the flag was read and accordingly VxLAN > processing was done but as packet did not have VxLAN header it caused > segfault. > > This patch resets mbuf offload flags in rx burst function. Update the git commit in fix in nature and add Fixes: tag > > Signed-off-by: Amit Prakash Shukla > --- > drivers/net/cnxk/cnxk_eswitch_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/cnxk/cnxk_eswitch_rxtx.c b/drivers/net/cnxk/cnxk= _eswitch_rxtx.c > index d57e32b091..0200392f2d 100644 > --- a/drivers/net/cnxk/cnxk_eswitch_rxtx.c > +++ b/drivers/net/cnxk/cnxk_eswitch_rxtx.c > @@ -194,7 +194,7 @@ cnxk_eswitch_dev_rx_burst(struct cnxk_eswitch_dev *es= witch_dev, uint16_t qid, > mbuf->vlan_tci =3D rx->vtag0_tci; > /* Populate RSS hash */ > mbuf->hash.rss =3D cqe->tag; > - mbuf->ol_flags |=3D RTE_MBUF_F_RX_RSS_HASH; > + mbuf->ol_flags =3D RTE_MBUF_F_RX_RSS_HASH; > pkts[pkt] =3D mbuf; > roc_prefetch_store_keep(mbuf); > plt_esw_dbg("Packet %d rec on queue %d esw qid %d hash %x= mbuf %p vlan tci %d", > -- > 2.18.0 >