From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F12A1A0545; Mon, 20 Jun 2022 19:27:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A9794069C; Mon, 20 Jun 2022 19:27:21 +0200 (CEST) Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by mails.dpdk.org (Postfix) with ESMTP id 3938F40151 for ; Mon, 20 Jun 2022 19:27:20 +0200 (CEST) Received: by mail-qk1-f169.google.com with SMTP id d23so8298862qke.0 for ; Mon, 20 Jun 2022 10:27:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FrCe1omeNnfPUnRJ5jxaNcqASY6VqrARl2IO3QE8ztk=; b=KOQTv/XySI4TiDMINkQLUwP71FLxmDeo8y5XWYyrTlU+OFwGtMZbg5g0bNBBm8/Ehj 93E7ZkPPun9JIAmLvfDG1jIe0kHMe1q7C1e8wpNqk99/5nQeLwLpaxAE/PVhtIUA+Ep2 PNVGAkwa2YQ+rN+RHtewhm2l5cknxING+S0qTAgz9jO16LPNTpzk3wbfuwPAvjjWD3pZ ElRE1V0zQCz32ZhiIuTEkHAlbzoqkeJGyo4KbRSF9hYq1frzlGaR7gKeL7OLWiaAgDg8 O89yjY7ofOkIR6vHhguW0+5C4s4My5O09PnFtKBSFzReYbeS4X2j6VHoG24Gzlm88dyh to+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FrCe1omeNnfPUnRJ5jxaNcqASY6VqrARl2IO3QE8ztk=; b=ICK9VDHNccqWy4uu11mGO2+fDrynHP9qq1w0hqJx2uuoZkOIpOroP1xPIzFFZf0OjW 4RtJkbSmfy5XP/fNOprexHNwkpWUpCr748Nu8eSLlRUnsnFRvYpuzxRYn8lguBYwr/zQ vsC21wS7Y1FgKvrpP0VrLL8q8rdah2DqZH7bmhiqpXZE9d52bkLIeOlb6DfrHMWpa/C3 9N1LL5bZ4Z4Gngfrc7k5Dll0s88BOwjgxYnLOkLv3bvVvwEX5tpdFafFmfzuGjFqQ77V a4NoGJ/mRnbz0kuIzfka7Xrmh3Owz/82IJTx/wP3mALzb2Huc+r72BGN/15aB0KaKGWP R5lQ== X-Gm-Message-State: AJIora8IYoBbY3Ykxk/6VeL9nRCc9ndQl47koUhjOo23rfE/Xf+0tBAm 2Bb0W1HWNHjaalcfJ19E4ZNU1S/V80dSCDRiXrCr2lZtmew= X-Google-Smtp-Source: AGRyM1s6EFALY7ESnHYV7i7JZdJtaxeuP16pebM8HfxTOGqq+bmhtRoS38RMFO9Wnf3POiJ43cd6YbpkGsGqUzHdi2Q= X-Received: by 2002:a37:c20a:0:b0:6a6:bfa7:ca5a with SMTP id i10-20020a37c20a000000b006a6bfa7ca5amr16362945qkm.283.1655746039448; Mon, 20 Jun 2022 10:27:19 -0700 (PDT) MIME-Version: 1.0 References: <20220616070743.30658-1-ndabilpuram@marvell.com> <20220616092420.17861-1-ndabilpuram@marvell.com> In-Reply-To: <20220616092420.17861-1-ndabilpuram@marvell.com> From: Jerin Jacob Date: Mon, 20 Jun 2022 22:56:53 +0530 Message-ID: Subject: Re: [PATCH v2 01/12] common/cnxk: use computed value for WQE skip To: Nithin Dabilpuram Cc: Jerin Jacob , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Pavan Nikhilesh , Shijith Thotton , dpdk-dev Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 16, 2022 at 2:54 PM Nithin Dabilpuram wrote: > > Use computed value for WQE skip instead of a hardcoded value. > WQE skip needs to be number of 128B lines to accommodate rte_mbuf. > > Signed-off-by: Nithin Dabilpuram > --- > Depends-on: series=23500 ("common/cnxk: add cnf10kb support") Series(except 12/12) applied to dpdk-next-net-mrvl/for-next-net. Thanks > > v2: > - Fixed commit message in 10/12, 1/12 patches > > drivers/common/cnxk/roc_nix_inl.h | 2 +- > drivers/common/cnxk/roc_nix_inl_priv.h | 2 +- > drivers/event/cnxk/cnxk_eventdev_adptr.c | 5 ++++- > drivers/net/cnxk/cnxk_ethdev_sec.c | 5 ++++- > 4 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/drivers/common/cnxk/roc_nix_inl.h b/drivers/common/cnxk/roc_nix_inl.h > index b1b4c5b..c7b1817 100644 > --- a/drivers/common/cnxk/roc_nix_inl.h > +++ b/drivers/common/cnxk/roc_nix_inl.h > @@ -131,7 +131,7 @@ struct roc_nix_inl_dev { > uint16_t channel; > uint16_t chan_mask; > bool attach_cptlf; > - bool wqe_skip; > + uint16_t wqe_skip; > uint8_t spb_drop_pc; > uint8_t lpb_drop_pc; > bool set_soft_exp_poll; > diff --git a/drivers/common/cnxk/roc_nix_inl_priv.h b/drivers/common/cnxk/roc_nix_inl_priv.h > index d61c7b2..a775efc 100644 > --- a/drivers/common/cnxk/roc_nix_inl_priv.h > +++ b/drivers/common/cnxk/roc_nix_inl_priv.h > @@ -84,7 +84,7 @@ struct nix_inl_dev { > uint32_t ipsec_in_max_spi; > uint32_t inb_spi_mask; > bool attach_cptlf; > - bool wqe_skip; > + uint16_t wqe_skip; > bool ts_ena; > }; > > diff --git a/drivers/event/cnxk/cnxk_eventdev_adptr.c b/drivers/event/cnxk/cnxk_eventdev_adptr.c > index fa96090..cf5b1dd 100644 > --- a/drivers/event/cnxk/cnxk_eventdev_adptr.c > +++ b/drivers/event/cnxk/cnxk_eventdev_adptr.c > @@ -125,6 +125,7 @@ cnxk_sso_rxq_enable(struct cnxk_eth_dev *cnxk_eth_dev, uint16_t rq_id, > { > struct roc_nix *nix = &cnxk_eth_dev->nix; > struct roc_nix_rq *rq; > + uint16_t wqe_skip; > int rc; > > rq = &cnxk_eth_dev->rqs[rq_id]; > @@ -132,7 +133,9 @@ cnxk_sso_rxq_enable(struct cnxk_eth_dev *cnxk_eth_dev, uint16_t rq_id, > rq->tt = ev->sched_type; > rq->hwgrp = ev->queue_id; > rq->flow_tag_width = 20; > - rq->wqe_skip = 1; > + wqe_skip = RTE_ALIGN_CEIL(sizeof(struct rte_mbuf), ROC_CACHE_LINE_SZ); > + wqe_skip = wqe_skip / ROC_CACHE_LINE_SZ; > + rq->wqe_skip = wqe_skip; > rq->tag_mask = (port_id & 0xF) << 20; > rq->tag_mask |= (((port_id >> 4) & 0xF) | (RTE_EVENT_TYPE_ETHDEV << 4)) > << 24; > diff --git a/drivers/net/cnxk/cnxk_ethdev_sec.c b/drivers/net/cnxk/cnxk_ethdev_sec.c > index d01ebb4..1de3454 100644 > --- a/drivers/net/cnxk/cnxk_ethdev_sec.c > +++ b/drivers/net/cnxk/cnxk_ethdev_sec.c > @@ -264,6 +264,7 @@ cnxk_nix_inl_dev_probe(struct rte_pci_driver *pci_drv, > char name[CNXK_NIX_INL_DEV_NAME_LEN]; > struct roc_nix_inl_dev *inl_dev; > const struct rte_memzone *mz; > + uint16_t wqe_skip; > int rc = -ENOMEM; > > RTE_SET_USED(pci_drv); > @@ -295,7 +296,9 @@ cnxk_nix_inl_dev_probe(struct rte_pci_driver *pci_drv, > > inl_dev->attach_cptlf = true; > /* WQE skip is one for DPDK */ > - inl_dev->wqe_skip = true; > + wqe_skip = RTE_ALIGN_CEIL(sizeof(struct rte_mbuf), ROC_CACHE_LINE_SZ); > + wqe_skip = wqe_skip / ROC_CACHE_LINE_SZ; > + inl_dev->wqe_skip = wqe_skip; > inl_dev->set_soft_exp_poll = true; > rc = roc_nix_inl_dev_init(inl_dev); > if (rc) { > -- > 2.8.4 >