From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74B5842DD2; Wed, 5 Jul 2023 09:48:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 021DA406BC; Wed, 5 Jul 2023 09:48:08 +0200 (CEST) Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by mails.dpdk.org (Postfix) with ESMTP id ACB6A40150 for ; Wed, 5 Jul 2023 09:48:06 +0200 (CEST) Received: by mail-vs1-f43.google.com with SMTP id ada2fe7eead31-440c5960b58so1899580137.3 for ; Wed, 05 Jul 2023 00:48:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688543286; x=1691135286; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eIcEjBo61rwGAq5VAgOPaIhj1eQsiq6MKLV3dhovNWs=; b=Wplk+L4uwYfVb8D9vlQnY9fvmfTFtqWzFSXqrt4fj23T8STFNDXqKXclToTcjMC4Tn Y8sHodcoVGZzul2F8CcCeubIwcK6GO2crEcO0ou3COPovBvYZT6dPW6X3yhXpHi7ePjX UtRJ54qaZqF9aYcPxMY7acIx6HhJjE9BAXwD6qj3SXqBMxeWDTrMtHXTiKEnpveGORTI c/eHRbVqhXUHlPb9SdLwIPwXEPtYqCqCIlpp5hm/0DyjGauFhNo+3KE3gLVXrbGSSyIS 8jCZoM3O+UPVc2edJBxU1Usr25/ItE9nCwxAmZ0qo7pRrEz9AJakYPqWHWCRy40QH0y5 l6zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688543286; x=1691135286; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eIcEjBo61rwGAq5VAgOPaIhj1eQsiq6MKLV3dhovNWs=; b=G7MXR+xxrCRFM4SFHI8zxHlOBhKMAlHQxF6rFitKgFcP14GGcYAxtIUwKLYcU/8wgo PRbrhopbJKNyaxKSDwUqeVSH1VmUuLt63BaoQf6gee7iBHAbM9MOT/yUwbk0MrVGpFh+ FSicZtmZ67ARfasBAoBs5PzJ6RQFvT7ND76JE1zBnSd14Ux7nDxSfJkwWstlwYN416dx 9qUEib7UV4aMgKr6aRqKPwih0ZdzsWyzhPk/dHdbcnbDbrHbTbFIaxuXbat8Pkf7o2Nh PhHNGDMMK+lt20qJqKgF+l9ohcDQiLMOTJ/3Es93LW4jVwvGEOkj1wFC9gdSuxMFCE7R lu5A== X-Gm-Message-State: ABy/qLbkE1zMDnEuveDTM408vyJxmRk7wnpgSePYv6A3EC1r+JpyXV4r 7fI/Vwr4WqfrUZn1+494/iAiLgkfx+6Tbof7iC8= X-Google-Smtp-Source: APBJJlFM6mrJ4wbv6tm1zyZMmGNl0xKbZXEXcWBkOg+XMWb3pWl8UD1QqrGP50MuFwMUiDSSyftIRezitBh+m3LMGfA= X-Received: by 2002:a67:e998:0:b0:443:6c11:fc5b with SMTP id b24-20020a67e998000000b004436c11fc5bmr6115485vso.14.1688543285930; Wed, 05 Jul 2023 00:48:05 -0700 (PDT) MIME-Version: 1.0 References: <20230609174205.150027-1-mattias.ronnblom@ericsson.com> <20230704115307.243031-1-mattias.ronnblom@ericsson.com> In-Reply-To: <20230704115307.243031-1-mattias.ronnblom@ericsson.com> From: Jerin Jacob Date: Wed, 5 Jul 2023 13:17:39 +0530 Message-ID: Subject: Re: [PATCH] eventdev: remove single-event enqueue operation To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: jerinj@marvell.com, hofors@lysator.liu.se, dev@dpdk.org, Pavan Nikhilesh , Timothy McDaniel , Hemant Agrawal , Sachin Saxena , Harry van Haaren , Liang Ma , Peter Mccarthy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jul 4, 2023 at 5:29=E2=80=AFPM Mattias R=C3=B6nnblom wrote: > > Eliminate non-burst enqueue operation from Eventdev. > > The effect of this change is to reduce Eventdev code complexity > somewhat and slightly improve performance. > > The single-event enqueue shortcut provided a very minor performance > advantage in some situations (e.g., with a compile time-constant burst > size of '1'), but would in other situations cause a noticeable > performance penalty (e.g., rte_event_enqueue_forward_burst() with run > time-variable burst sizes varying between '1' and larger burst sizes). > > Signed-off-by: Mattias R=C3=B6nnblom > > -- > > PATCH: Add ABI deprecation notice. Need to split this patch as depreciation notice only will be merged to this release. Example: https://patches.dpdk.org/project/dpdk/patch/20230704194445.3332847= -1-gakhil@marvell.com/ I think, we need to remove the single dequeue as well. So I think, we can write a generic deprecation notice which says size of struct rte_event_fp_ops will be changed by removing single enqueue, dequeue and. Reservation fields size . Later we can analysis the performance impact when the implementation patch is ready. For now, let make deprecation notice for this release.