From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A425A0093; Thu, 11 Jun 2020 17:33:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ADF951B19; Thu, 11 Jun 2020 17:33:38 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 9BE3F1515 for ; Thu, 11 Jun 2020 17:33:36 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id r77so6766143ior.3 for ; Thu, 11 Jun 2020 08:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FXPUkZGtLXZptFRmxPN2k/UO7Tq5Mirj2xDksSP3V7Q=; b=e2qhISte+LzhLmXUePB3j8XmVhKPjnpAOxd6CdQFDlJhYKCZGF4+4bnddnw9US4Etx TWJG6umsfwH4CMAkvUlyl5BPp8IiMiegRkniCSsIajuGRv7DHwtztnuv/N95jf/qa4nn Tue8OQBByDAccBavJeTXhVhOOGJbidyyeQiageK53YSat63tWP/0C02+9/wkpfANqoNh fKGFEKjryLfXily/4e3Pl8GkQ5ReMDPkt3gk45J3t/CeOOCGjwCX4gAHo1w4d7bJrEom 6ThEP3rt6IV1SeG2kaeG2uqGpzojVkDn3+ZVhymqkuVqAuM7xUYC/fnvkYt3JZ1D3T6i mRdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FXPUkZGtLXZptFRmxPN2k/UO7Tq5Mirj2xDksSP3V7Q=; b=pxHkwBMCrYipnNSodJIR2ZBOFlIarE4QaBS2I1e2vc5/J8k+SYtgckTFT8AUl0wuL3 R1g9NyPtM2BWqFZ5HarULPBhOqTmHX1N+JT+Li87AOFAWlRQ+XvCIEI8x6WsUNI7k8Fp X69IAmWlkMzmQES02jvALfkmw3P9EzykBIh27bFZffnWCgudnPkFjEcTHewiwGdSU5yq hDrOQI/5ikJaSZwX4QmR06iT4TIjz6Cu0PWhmn1aRQXoJoHXd92krKDb33a5O6Q1COBp 3yYmoD3P+JiqnLGmy9EGKlYTevD1S1cCIqNQ+iPN6Q/86Y2mq/DMdZ5PKSjQdiCiS7M2 x5pA== X-Gm-Message-State: AOAM531sSReafw2MAA6tR0ua7uqSdAQkrF/hrWHJnHjXZvTL/BujObUw 4IT//YUZWu7dOLRsUfeH1v+ISTXd3BdffJukKlU= X-Google-Smtp-Source: ABdhPJwbWj3r1j5RBrsoNTQ4zIdUwJ6FP32OzGkaI8STC0lv5nfU7bEPw5/4p/9zuoFkkSwXgeMUDfqohGiJeFwuaHY= X-Received: by 2002:a05:6602:2001:: with SMTP id y1mr8727297iod.94.1591889615924; Thu, 11 Jun 2020 08:33:35 -0700 (PDT) MIME-Version: 1.0 References: <1591870283-7776-1-git-send-email-radu.nicolau@intel.com> <23762f7e-80f2-e969-893b-f9f1ea6a293a@intel.com> In-Reply-To: <23762f7e-80f2-e969-893b-f9f1ea6a293a@intel.com> From: Jerin Jacob Date: Thu, 11 Jun 2020 21:03:19 +0530 Message-ID: To: "Nicolau, Radu" Cc: dpdk-dev , Beilei Xing , jia.guo@intel.com, "Richardson, Bruce" , "Ananyev, Konstantin" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1 1/2] eal/x86: add WC store function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 11, 2020 at 7:26 PM Nicolau, Radu wrote: > > > On 6/11/2020 1:23 PM, Jerin Jacob wrote: > > On Thu, Jun 11, 2020 at 3:41 PM Radu Nicolau wrote: > >> Add rte_write32_wc function that implements a WC store > >> using movdiri instruction. > >> > >> Signed-off-by: Radu Nicolau > >> --- > >> lib/librte_eal/x86/include/rte_io.h | 20 ++++++++++++++++++++ > >> 1 file changed, 20 insertions(+) > >> > >> diff --git a/lib/librte_eal/x86/include/rte_io.h b/lib/librte_eal/x86/include/rte_io.h > >> index 2db71b1..3d74bec 100644 > >> --- a/lib/librte_eal/x86/include/rte_io.h > >> +++ b/lib/librte_eal/x86/include/rte_io.h > >> @@ -11,6 +11,26 @@ extern "C" { > >> > >> #include "generic/rte_io.h" > >> > >> +/** > >> + * Write a 32-bit value to I/O device memory address *addr*. > >> + * Uses MOVDIRI instruction to perform a direct-store operation using WC > >> + * memory write protocol. > > It will be an x86 specific API, Please change the API name to reflect that. > > > You mean something like rte_x86_write32_wc? Yes. Something like that...