DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: dpdk-dev <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
	 Hemant Agrawal <hemant.agrawal@nxp.com>,
	Akhil Goyal <akhil.goyal@nxp.com>,
	ogerlitz@mellanox.com, Ajit Khaparde <ajit.khaparde@broadcom.com>,
	Pavan Nikhilesh <pbhagavatula@marvell.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] eal/arm: change inline functions to always inline
Date: Tue, 7 Jul 2020 07:35:29 +0530
Message-ID: <CALBAE1Md+Q76xNosEG1gJEKL0bt8KLTCE7c5D_BdRafCY=zxLQ@mail.gmail.com> (raw)
In-Reply-To: <20200626203502.20658-2-honnappa.nagarahalli@arm.com>

On Sat, Jun 27, 2020 at 2:05 AM Honnappa Nagarahalli
<honnappa.nagarahalli@arm.com> wrote:
>
> Change the inline functions to use __rte_always_inline to be
> consistent with rest of the inline functions.
>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>



> ---
>  lib/librte_eal/arm/include/rte_cycles_64.h | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/lib/librte_eal/arm/include/rte_cycles_64.h b/lib/librte_eal/arm/include/rte_cycles_64.h
> index e41f9dbd6..029fdc435 100644
> --- a/lib/librte_eal/arm/include/rte_cycles_64.h
> +++ b/lib/librte_eal/arm/include/rte_cycles_64.h
> @@ -50,7 +50,7 @@ __rte_arm64_cntvct_precise(void)
>   * This call is portable to any ARMv8 architecture, however, typically
>   * cntvct_el0 runs at <= 100MHz and it may be imprecise for some tasks.
>   */
> -static inline uint64_t
> +static __rte_always_inline uint64_t
>  rte_rdtsc(void)
>  {
>         return __rte_arm64_cntvct();
> @@ -85,22 +85,25 @@ __rte_arm64_pmccntr(void)
>         return tsc;
>  }
>
> -static inline uint64_t
> +static __rte_always_inline uint64_t
>  rte_rdtsc(void)
>  {
>         return __rte_arm64_pmccntr();
>  }
>  #endif
>
> -static inline uint64_t
> +static __rte_always_inline uint64_t
>  rte_rdtsc_precise(void)
>  {
>         asm volatile("isb" : : : "memory");
>         return rte_rdtsc();
>  }
>
> -static inline uint64_t
> -rte_get_tsc_cycles(void) { return rte_rdtsc(); }
> +static __rte_always_inline uint64_t
> +rte_get_tsc_cycles(void)
> +{
> +       return rte_rdtsc();
> +}
>
>  #ifdef __cplusplus
>  }
> --
> 2.17.1
>

  reply	other threads:[~2020-07-07  2:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-08 21:34 [dpdk-dev] [PATCH] eal: generic counter based loop for CPU freq calculation Honnappa Nagarahalli
2020-06-24 12:50 ` Jerin Jacob
2020-06-26 20:46   ` Honnappa Nagarahalli
2020-06-24 15:09 ` Pavan Nikhilesh Bhagavatula
2020-06-26 20:35 ` [dpdk-dev] [PATCH v2 1/2] eal/arm: " Honnappa Nagarahalli
2020-06-26 20:35   ` [dpdk-dev] [PATCH v2 2/2] eal/arm: change inline functions to always inline Honnappa Nagarahalli
2020-07-07  2:05     ` Jerin Jacob [this message]
2020-07-07 11:16   ` [dpdk-dev] [PATCH v2 1/2] eal/arm: generic counter based loop for CPU freq calculation David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1Md+Q76xNosEG1gJEKL0bt8KLTCE7c5D_BdRafCY=zxLQ@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=jerinj@marvell.com \
    --cc=nd@arm.com \
    --cc=ogerlitz@mellanox.com \
    --cc=pbhagavatula@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git