From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56085A0543; Mon, 13 Jun 2022 08:21:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E32D74021E; Mon, 13 Jun 2022 08:21:37 +0200 (CEST) Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by mails.dpdk.org (Postfix) with ESMTP id 828C040150 for ; Mon, 13 Jun 2022 08:21:36 +0200 (CEST) Received: by mail-qt1-f175.google.com with SMTP id hh4so3244041qtb.10 for ; Sun, 12 Jun 2022 23:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3YV2jG1iaExhLmFFOJgDZ7gnhn+i2s2cAZmdWnvE9Rk=; b=lpN9iP8YNrnGNuFHXuxLS7GNQRJjeW18eDrijm8QtMrVrTwETpPkzZZamnMp+aJYhN v716NzcoDbQTxtVoGs+079Y4e4JNeSxvI2NonC3cp9L9KaPTg6TsGfLC2h2zqSTix8Ni 7J+klsaBEpSqMvo8Hw9RM0/cOCtVNqYF0gKaFaraYE7h3Ic04voR+XSP6bJQK54DGg0J NDllIQ00cnyUzbQAg+1+jCcDTzkUOA0ci4Y4Op7xoe2PXYTuYTx2xrEd1D6eutGFTSv8 0k4jwjPPMCCnsPm4Enzof84scqOUDL4RHW0mMCc5kjFOvXD/+rFYz/foXWWxtdJYV7M9 XF7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3YV2jG1iaExhLmFFOJgDZ7gnhn+i2s2cAZmdWnvE9Rk=; b=f0t3l1ngacBd/m9BtAI0bMBriVEZ5tXL687qi4v77B5476CtauMXmnBXSd7W4LrOKD ZMbyewQxcXLRBjCOImtMt+0mzqsRRr6aARNIfOMO6fepsm7DWk26irZENQ51oVS8Ym9n er7QLCwam7aWBRTHBPHOw9S4lSes8Ak5G2xCS/CpBmsaf49bZHyZwEko9qUQu4qBGSsa xk/N+h7Xa/+NSiLt6y13D0IWpj7C9PuCQR7NepWaixQt4gKokBenXat9AiwXBk3GA5eC tjC9Fb3glGmINo5n9A977X0ry3vDKHPfa8DtinwsivspIGICqtj5LT+d1BU5AFdM20gv XzCw== X-Gm-Message-State: AOAM532Fq/J7WUAwzJdemojQHH9ktOSDkthAOrzzbzZ+zYjW5mQo7Oi9 lqpsk7lU96FNLz72FuUP0cNTtsJt55o/Ri7fkLA= X-Google-Smtp-Source: ABdhPJy1BKulS5/k35HUbPGVxhFtSAy3Ky49z5hFVALJoiyH6cPy0/kr6lpXWyO7zG8cv4tRZ1nQcLYrRAgSpIXigsU= X-Received: by 2002:a05:622a:81:b0:304:ea54:ae89 with SMTP id o1-20020a05622a008100b00304ea54ae89mr32744954qtw.172.1655101295808; Sun, 12 Jun 2022 23:21:35 -0700 (PDT) MIME-Version: 1.0 References: <20220606154044.1225683-1-timothy.mcdaniel@intel.com> <20220610183631.3093650-1-timothy.mcdaniel@intel.com> In-Reply-To: <20220610183631.3093650-1-timothy.mcdaniel@intel.com> From: Jerin Jacob Date: Mon, 13 Jun 2022 11:51:09 +0530 Message-ID: Subject: Re: [PATCH v2] event/dlb2: fix advertized capabilities To: Timothy McDaniel Cc: Jerin Jacob , dpdk-dev Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Jun 11, 2022 at 12:06 AM Timothy McDaniel wrote: > > This commit corrects the advertized capabilities reported by the DLB2 PMD. > > Previously DLB2 reported supporting RTE_EVENT_DEV_CAP_QUEUE_QOS, but the > DLB2 hardware does not support such capability. This commit removes that > feature from the reported capabilities feature set. > > Additionally, two capabilities that DLB2 does support were not being > reported in the capabilities feature set. This commit adds those. > > RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT = Event device is capable of > setting up the link between multiple queues and a single port. If the > flag is not set, the eventdev can only map a single queue to each > port or map a single queue to many port > > RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK = Event device is capable of > configuring the queue/port link at runtime. If the flag is not set, > the eventdev queue/port link is only can be configured during > initialization > > Finally, the file doc/guides/eventdevs/features/dlb2.ini has been updated > to match the capabilities actually reported by the PMD. > > Signed-off-by: Timothy McDaniel Please fix [for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1 Missing 'Fixes' tag: event/dlb2: fix advertized capabilities Invalid patch(es) found - checked 1 patch > === > > Changes since V1; > 1) reorder capabilities flags to match the order that they appear in > in the default.ini file > 2) update the dlb2.ini file with the new set of features supported by DLB2 > 3) expanded the commit message to provide additional details > --- > doc/guides/eventdevs/features/dlb2.ini | 3 ++- > drivers/event/dlb2/dlb2.c | 9 +++++---- > 2 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/doc/guides/eventdevs/features/dlb2.ini b/doc/guides/eventdevs/features/dlb2.ini > index 29747b1c26..48a2a18aff 100644 > --- a/doc/guides/eventdevs/features/dlb2.ini > +++ b/doc/guides/eventdevs/features/dlb2.ini > @@ -4,12 +4,13 @@ > ; Refer to default.ini for the full list of available PMD features. > ; > [Scheduling Features] > -queue_qos = Y > event_qos = Y > distributed_sched = Y > queue_all_types = Y > burst_mode = Y > implicit_release_disable = Y > +runtime_port_link = Y > +multiple_queue_port = Y > maintenance_free = Y > > [Eth Rx adapter Features] > diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c > index 3641ed2942..bc4e705e0b 100644 > --- a/drivers/event/dlb2/dlb2.c > +++ b/drivers/event/dlb2/dlb2.c > @@ -61,12 +61,13 @@ static struct rte_event_dev_info evdev_dlb2_default_info = { > .max_num_events = DLB2_MAX_NUM_LDB_CREDITS, > .max_single_link_event_port_queue_pairs = > DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2), > - .event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS | > - RTE_EVENT_DEV_CAP_EVENT_QOS | > - RTE_EVENT_DEV_CAP_BURST_MODE | > + .event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS | > RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED | > - RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE | > RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES | > + RTE_EVENT_DEV_CAP_BURST_MODE | > + RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE | > + RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK | > + RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT | > RTE_EVENT_DEV_CAP_MAINTENANCE_FREE), > }; > > -- > 2.25.1 >