From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 1E610A04AC;
Fri, 1 May 2020 13:18:40 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id C3DB51DA1D;
Fri, 1 May 2020 13:18:39 +0200 (CEST)
Received: from mail-io1-f67.google.com (mail-io1-f67.google.com
[209.85.166.67]) by dpdk.org (Postfix) with ESMTP id B57C91D906
for <dev@dpdk.org>; Fri, 1 May 2020 13:18:38 +0200 (CEST)
Received: by mail-io1-f67.google.com with SMTP id k18so4588731ion.0
for <dev@dpdk.org>; Fri, 01 May 2020 04:18:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=59rhpRYu92dXk5N1s8FkldOMQrmPoDn1JA4iGyUdjSc=;
b=ZhtTgjVWs6Tr/43IhMC9EF4TZEb2hIIRvqlXouBZVC9mhoGQcFIAL+tzQBgVjy7J8L
obOZXtabXrI3DT/lxexeh0Ko5TZubIU4woMgejCPmi4Z5mq8cpe9xRfGe8DADErXeP11
kzbR3wKP5j6HY1zwAUnDhkXFAh5qH5aMXWRqEuXrr7wHlF2Hq+vdURyAvFW30RrE56nR
5d5fY+sKSN3h0oHQ8iQ0FHbSJsAeEng7T6x8+Hg6mzAWcLl1Z1kzjHrSqFQavv3YREHP
auJwVcw28FQlJyMGAzohrCUB8LmgwcNqhN09XqBPfy0K38RKUM2m+6cOj2kLdyU4yImn
/fKg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=59rhpRYu92dXk5N1s8FkldOMQrmPoDn1JA4iGyUdjSc=;
b=D/1oUPVUZqbaB38/g4efWDW0vPQC9jUY2uxqyTb6Jg4x6gEUK8EDeQAGLbF/hegobF
l8MLIraIF6R5JFyXPSCGUJpC9y2yR+FbXN+pdV775HRhq/aFisH9BGaeiMbK/Lz0cNCJ
HnLDtkO/2Ikm9vwb7D5SSfaw1M8HeXkvhCnjb57rOo2JDW5yDKYpuwThjkLlOPp6lSF1
bmf1RKT0rrTyia+3GMG1gaEXXh22sfhcLkaoAod3bJS+1nfBbWLCPmXiUNupMa6bp+zq
hkMd657ZZLgrCHHw57QVKiiGlqNvKGCIURW4f+XinT+V8z2Iu/pslY/JHSJajIv3uL69
0oIQ==
X-Gm-Message-State: AGi0PuYh6/tijErgiprByOHzFSwRzdnA8EYIRpho/En4/hCEdHG4IYW8
QVpaREu4OnJj42EhZSOGu49q3iASXPG1XMx2CXo=
X-Google-Smtp-Source: APiQypK6G0e7hLN9y6zJMD4weJpGxS+uln3pOwUcpu92x3K9r7U9MpNpXHBDNn8M0jd4AIFORBYle+OHg5npoZY1Ll4=
X-Received: by 2002:a02:1c83:: with SMTP id c125mr2739445jac.112.1588331918008;
Fri, 01 May 2020 04:18:38 -0700 (PDT)
MIME-Version: 1.0
References: <20200417072254.11455-1-nithind1988@gmail.com>
In-Reply-To: <20200417072254.11455-1-nithind1988@gmail.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Fri, 1 May 2020 16:48:21 +0530
Message-ID: <CALBAE1MeWqShW2O44WD01=vXzrLjMeszFOKPmm86FPxmuY4aSQ@mail.gmail.com>
To: Nithin Dabilpuram <nithind1988@gmail.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>, Ori Kam <orika@mellanox.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Olivier Matz <olivier.matz@6wind.com>, dpdk-dev <dev@dpdk.org>,
Jerin Jacob <jerinj@marvell.com>, Krzysztof Kanas <kkanas@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH 1/3] mbuf: add Tx offloads for packet marking
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Fri, Apr 17, 2020 at 12:53 PM Nithin Dabilpuram
<nithind1988@gmail.com> wrote:
>
> From: Nithin Dabilpuram <ndabilpuram@marvell.com>
>
> Introduce PKT_TX_MARK_IP_DSCP, PKT_TX_MARK_IP_ECN
> and PKT_TX_MARK_VLAN_DEI Tx offload flags to support
> packet marking.
>
> When packet marking feature in Traffic manager is enabled,
> application has to the use the three new flags to indicate
> to PMD on whether packet marking needs to be enabled on the
> specific mbuf or not. By setting the three flags, it is
> assumed by PMD that application has already verified the
> applicability of marking on that specific packet and
> PMD need not perform further checks as per RFC.
>
> Signed-off-by: Krzysztof Kanas <kkanas@marvell.com>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
None of the ethdev TM driver implementations has supported packet
marking support.
rte_tm and rte_mbuf maintainers(Christian, Oliver), Could you review this patch?
> ---
> doc/guides/nics/features.rst | 14 ++++++++++++++
> lib/librte_mbuf/rte_mbuf.c | 6 ++++++
> lib/librte_mbuf/rte_mbuf_core.h | 36 ++++++++++++++++++++++++++++++++++--
> 3 files changed, 54 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
> index edd21c4..bc978fb 100644
> --- a/doc/guides/nics/features.rst
> +++ b/doc/guides/nics/features.rst
> @@ -913,6 +913,20 @@ Supports to get Rx/Tx packet burst mode information.
> * **[implements] eth_dev_ops**: ``rx_burst_mode_get``, ``tx_burst_mode_get``.
> * **[related] API**: ``rte_eth_rx_burst_mode_get()``, ``rte_eth_tx_burst_mode_get()``.
>
> +.. _nic_features_traffic_manager_packet_marking_offload:
> +
> +Traffic Manager Packet marking offload
> +--------------------------------------
> +
> +Supports enabling a packet marking offload specific mbuf.
> +
> +* **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_MARK_IP_DSCP``,
> + ``mbuf.ol_flags:PKT_TX_MARK_IP_ECN``, ``mbuf.ol_flags:PKT_TX_MARK_VLAN_DEI``,
> + ``mbuf.ol_flags:PKT_TX_IPV4``, ``mbuf.ol_flags:PKT_TX_IPV6``.
> +* **[uses] mbuf**: ``mbuf.l2_len``.
> +* **[related] API**: ``rte_tm_mark_ip_dscp()``, ``rte_tm_mark_ip_ecn()``,
> + ``rte_tm_mark_vlan_dei()``.
> +
> .. _nic_features_other:
>
> Other dev ops not represented by a Feature
> diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
> index cd5794d..5c6896d 100644
> --- a/lib/librte_mbuf/rte_mbuf.c
> +++ b/lib/librte_mbuf/rte_mbuf.c
> @@ -880,6 +880,9 @@ const char *rte_get_tx_ol_flag_name(uint64_t mask)
> case PKT_TX_SEC_OFFLOAD: return "PKT_TX_SEC_OFFLOAD";
> case PKT_TX_UDP_SEG: return "PKT_TX_UDP_SEG";
> case PKT_TX_OUTER_UDP_CKSUM: return "PKT_TX_OUTER_UDP_CKSUM";
> + case PKT_TX_MARK_VLAN_DEI: return "PKT_TX_MARK_VLAN_DEI";
> + case PKT_TX_MARK_IP_DSCP: return "PKT_TX_MARK_IP_DSCP";
> + case PKT_TX_MARK_IP_ECN: return "PKT_TX_MARK_IP_ECN";
> default: return NULL;
> }
> }
> @@ -916,6 +919,9 @@ rte_get_tx_ol_flag_list(uint64_t mask, char *buf, size_t buflen)
> { PKT_TX_SEC_OFFLOAD, PKT_TX_SEC_OFFLOAD, NULL },
> { PKT_TX_UDP_SEG, PKT_TX_UDP_SEG, NULL },
> { PKT_TX_OUTER_UDP_CKSUM, PKT_TX_OUTER_UDP_CKSUM, NULL },
> + { PKT_TX_MARK_VLAN_DEI, PKT_TX_MARK_VLAN_DEI, NULL },
> + { PKT_TX_MARK_IP_DSCP, PKT_TX_MARK_IP_DSCP, NULL },
> + { PKT_TX_MARK_IP_ECN, PKT_TX_MARK_IP_ECN, NULL },
> };
> const char *name;
> unsigned int i;
> diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h
> index b9a59c8..d9f1290 100644
> --- a/lib/librte_mbuf/rte_mbuf_core.h
> +++ b/lib/librte_mbuf/rte_mbuf_core.h
> @@ -187,11 +187,40 @@ extern "C" {
> /* add new RX flags here, don't forget to update PKT_FIRST_FREE */
>
> #define PKT_FIRST_FREE (1ULL << 23)
> -#define PKT_LAST_FREE (1ULL << 40)
> +#define PKT_LAST_FREE (1ULL << 37)
>
> /* add new TX flags here, don't forget to update PKT_LAST_FREE */
>
> /**
> + * Packet marking offload flags. These flags indicated what kind
> + * of packet marking needs to be applied on a given mbuf when
> + * appropriate Traffic Manager configuration is in place.
> + * When user set's these flags on a mbuf, below assumptions are made
> + * 1) When PKT_TX_MARK_VLAN_DEI is set,
> + * a) PMD assumes pkt to be a 802.1q packet.
> + * b) Application should also set mbuf.l2_len where 802.1Q header is
> + * at (mbuf.l2_len - 6) offset.
> + * 2) When PKT_TX_MARK_IP_DSCP is set,
> + * a) Application should also set either PKT_TX_IPV4 or PKT_TX_IPV6
> + * to indicate whether if it is IPv4 packet or IPv6 packet
> + * for DSCP marking. It should also set PKT_TX_IP_CKSUM if it is
> + * IPv4 pkt.
> + * b) Application should also set mbuf.l2_len that indicates
> + * start offset of L3 header.
> + * 3) When PKT_TX_MARK_IP_ECN is set,
> + * a) Application should also set either PKT_TX_IPV4 or PKT_TX_IPV6.
> + * It should also set PKT_TX_IP_CKSUM if it is IPv4 pkt.
> + * b) PMD will assume pkt L4 protocol is either TCP or SCTP and
> + * ECN is set to 2'b01 or 2'b10 as per RFC 3168 and hence HW
> + * can mark the packet for a configured color.
> + * c) Application should also set mbuf.l2_len that indicates
> + * start offset of L3 header.
> + */
> +#define PKT_TX_MARK_VLAN_DEI (1ULL << 38)
> +#define PKT_TX_MARK_IP_DSCP (1ULL << 39)
> +#define PKT_TX_MARK_IP_ECN (1ULL << 40)
> +
> +/**
> * Outer UDP checksum offload flag. This flag is used for enabling
> * outer UDP checksum in PMD. To use outer UDP checksum, the user needs to
> * 1) Enable the following in mbuf,
> @@ -384,7 +413,10 @@ extern "C" {
> PKT_TX_MACSEC | \
> PKT_TX_SEC_OFFLOAD | \
> PKT_TX_UDP_SEG | \
> - PKT_TX_OUTER_UDP_CKSUM)
> + PKT_TX_OUTER_UDP_CKSUM | \
> + PKT_TX_MARK_VLAN_DEI | \
> + PKT_TX_MARK_IP_DSCP | \
> + PKT_TX_MARK_IP_ECN)
>
> /**
> * Mbuf having an external buffer attached. shinfo in mbuf must be filled.
> --
> 2.8.4
>