From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A918843D47; Mon, 25 Mar 2024 12:08:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99E6840271; Mon, 25 Mar 2024 12:08:46 +0100 (CET) Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by mails.dpdk.org (Postfix) with ESMTP id A674D40270 for ; Mon, 25 Mar 2024 12:08:44 +0100 (CET) Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-690caa6438aso25367646d6.0 for ; Mon, 25 Mar 2024 04:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711364924; x=1711969724; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=k0Cdr5krmzxLHIKGV1SSSGW1iADImYooSI6AsSdoLFo=; b=llhVDQAv7dCKyi9SLuXttm8taZTgLkird9Br8cqtZEu4WFMN+JMPwcFO41n1xiQdm9 LzTMCpDeCZClt1Y3LFa2NlwSlKNMJd5r71giRx++olXumGrLDbFI0S3TMKULXmAeP0qY 0Jrq0G78LgwVwsxwOeiO+3Aj4FBhgGIoAXefC7SWNo99Sp4eHC4zDr3d9bUfLZ7WSAsG mb1Pf3mHUpW14ihFqcXPYs83pRVuvdrWv+K0bIagGX8vQzgWHEY/hb42PZtzDZOf/2CT M9M+3Cyglf9wibfFDPOb76cxtKERSld017kknXxUjtVEqaMEjvz9n4dDDv2vmHs6SER/ yeLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711364924; x=1711969724; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k0Cdr5krmzxLHIKGV1SSSGW1iADImYooSI6AsSdoLFo=; b=AcC5mc7oEwej8NnLHKNZmihCXo2z/cLfwUT+awSyXFmLpguwI0MxubwjKxvHmVf9Q7 4YaHg5Cclm5rjAhHGP68V5mE9iJEPI4f7hvrjORoXW+5h5QX/QX+3k+MDb19gOzkcKeh Dr78w2Io/IIk2tfqOH+2VTGtK6ZAKrjsp1ZlK8s52p1K+cR0HUM0l4jh5zspW6QXf1Cc mTu/CxIenqdn8ED6c23lftmqVHTuhyNaL7Y5qSf83ClA5B6d9NRFHRLBBw7EB2hV6Wm0 o0FX16d4MZtb2NDNuZYKT8uAMWkkiCeY431zh1SELhLCVbalSSzhfMKvqaiJ2RbNiiKs c78A== X-Gm-Message-State: AOJu0YwjZpNuRgM91n3wf0a0e/9EG7mwxuGO3k6DkvRua4mdO0VhjyEp vUZwmGumjv/Ine0HOYJK85QA10+ChQfz8FYk0qCnoqwd2xZIKCXKSuzanxzPpH0fOH+Fsc+CNfr gKHplUxmpb3y8YoA8qsQTevLuxKXMlzenghA= X-Google-Smtp-Source: AGHT+IGWXG8Z9jFmc8fJmOeY09JYJQAc0mVc7oK4IzWKe+x/msKvsibMIrxkt6xFMTjSeneTU3I6E+QK0AoOpwVdfd4= X-Received: by 2002:a05:6214:12c8:b0:696:8806:1209 with SMTP id s8-20020a05621412c800b0069688061209mr2730889qvv.11.1711364923984; Mon, 25 Mar 2024 04:08:43 -0700 (PDT) MIME-Version: 1.0 References: <20240325100500.694748-2-rjarry@redhat.com> In-Reply-To: From: Jerin Jacob Date: Mon, 25 Mar 2024 16:38:18 +0530 Message-ID: Subject: Re: [PATCH v3] graph: expose node context as pointers To: Robin Jarry Cc: dev@dpdk.org, Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , Zhirun Yan , Tyler Retzlaff Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Mar 25, 2024 at 4:32=E2=80=AFPM Robin Jarry wro= te: > > Jerin Jacob, Mar 25, 2024 at 11:59: > > > +static_assert(offsetof(struct rte_node, ctx) % RTE_CACHE_LINE_SIZE = =3D=3D 0, > > > + "rte_node ctx must be aligned on a cache line"); > > > > > > This will fail in 32bit machine. > > https://mails.dpdk.org/archives/test-report/2024-March/623806.html > > Hi Jerin, yes I saw that :( > > > I can think of following solution to add before ctx. > > RTE_MARKER fastpath __rte_cache__aligned; > > It will not be taken into account for MSVC. Is that OK? Why?. rte_mbuf has a similar scheme. RTE_MARKER cacheline1 __rte_cache_min_aligned; >