From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3D3E6A0562;
	Sat,  4 Apr 2020 14:16:10 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 749845F13;
	Sat,  4 Apr 2020 14:16:09 +0200 (CEST)
Received: from mail-il1-f196.google.com (mail-il1-f196.google.com
 [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id 97C15F12
 for <dev@dpdk.org>; Sat,  4 Apr 2020 14:16:07 +0200 (CEST)
Received: by mail-il1-f196.google.com with SMTP id j9so10112793ilr.7
 for <dev@dpdk.org>; Sat, 04 Apr 2020 05:16:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=wmMUwj84XUa3zYoiDPv0XbQus9ZXlr0HPXutOg3TXi8=;
 b=YiLohDWwgfvBKpKxiDPiHcs0XHskCuTxmyUMSUEOhDbJAgTxryf6VvWbJXRmGPWetF
 0TS2XCDA9ysVSzaLTLe3K+QJFRTf812nx7oRxuGYp8kkmiVP4OLy2mxzyscBThbltOSp
 /ONIGBXXgvw5UFUNQbTC+V9F9Yw9qIQH2qv7sCFr5CWlrtIM4qBw9NB5JHfWjhXmntSZ
 YWv2zlWP9ZjF17ZN3zrtKA4KQM/ZL/ePWYCvhu0+ih6AmiZNHrrByyoceJdwoOgR1Frm
 GGeNzqRqVxkkJrVlXdK77K11cfNqA0c3S2+xxe4eC3RPfyy0iHWmWVty8jlmA+3Lv6AP
 0Kpg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=wmMUwj84XUa3zYoiDPv0XbQus9ZXlr0HPXutOg3TXi8=;
 b=WtrNXxkZBCm8jUrO16ujJV69pQhH88ckFfpfotd3z2E90twxoFWQl7TQMr90qHIjKL
 zH/Ft1aec4bO0urDijm6IIgtbsz7FjWztmkRVUqyd/VNtT6dmk4cV4dGTaASiXcPR4wR
 FtEPD9q+c2Vqmx6rfhIuJgUf9FLNJk9BZyj682ho23/gaeaYgRBFWRd+PjwSVt/pxMXh
 BLTCXgW6YAvMDzI+nHicoZST6Gq13mvlHLPyNKKalHUIVz/nbrEK+jgvAtkgKDfTEvwC
 SchcOr1qKkTONtUwqWsGJXH0T2qSDPNHkkXRJrnEtgs5+FYa90HC8RV8Z6hS+iwTH4UQ
 fS/Q==
X-Gm-Message-State: AGi0PuY76XZZhnYsbd1z4m0y8YqgfBCB+ARjP7xw9K2RTRebaePpvreM
 bdhk4XjVtKDefaV7BUfwJmRCuUTbw8AdOML3azA=
X-Google-Smtp-Source: APiQypIfEdB76vvCHp/V4FB03UE9GEEPArnCAT1bu5oVzGLNwuMLo9gMTgY2FR/1z/wgP99mqj/Gj50+Uv7XapgwXec=
X-Received: by 2002:a92:2804:: with SMTP id l4mr13700552ilf.130.1586002566805; 
 Sat, 04 Apr 2020 05:16:06 -0700 (PDT)
MIME-Version: 1.0
References: <20200326165644.866053-1-jerinj@marvell.com>
 <20200331192945.2466880-1-jerinj@marvell.com>
 <20200331192945.2466880-2-jerinj@marvell.com>
 <BN6PR11MB1473B50F3770E9234B292866B8C70@BN6PR11MB1473.namprd11.prod.outlook.com>
In-Reply-To: <BN6PR11MB1473B50F3770E9234B292866B8C70@BN6PR11MB1473.namprd11.prod.outlook.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Sat, 4 Apr 2020 17:45:50 +0530
Message-ID: <CALBAE1MfgAXf_50eKD9D1Ep8uvxa2NDbFsUthZQBsvet2JNNTQ@mail.gmail.com>
To: "Wang, Xiao W" <xiao.w.wang@intel.com>
Cc: "jerinj@marvell.com" <jerinj@marvell.com>,
 Thomas Monjalon <thomas@monjalon.net>, 
 "Richardson, Bruce" <bruce.richardson@intel.com>, "Mcnamara,
 John" <john.mcnamara@intel.com>, 
 "Kovacevic, Marko" <marko.kovacevic@intel.com>,
 Kiran Kumar K <kirankumark@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "david.marchand@redhat.com" <david.marchand@redhat.com>, 
 "mdr@ashroe.eu" <mdr@ashroe.eu>, 
 "mattias.ronnblom@ericsson.com" <mattias.ronnblom@ericsson.com>, 
 "pbhagavatula@marvell.com" <pbhagavatula@marvell.com>, 
 "ndabilpuram@marvell.com" <ndabilpuram@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v3 01/29] graph: define the public API for
 graph support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Apr 3, 2020 at 2:56 PM Wang, Xiao W <xiao.w.wang@intel.com> wrote:
>
> Hi Jerin,

Hi Xiao. Thanks for the review.

> Found small typos on this patch. Please check comments inline.
>
> Best Regards,
> Xiao
>
> > +/**
> > + * @warning
> > + * @b EXPERIMENTAL: this API may change without prior notice
> > + *
> > + * Destroy cluster stats.
> > + *
> > + * @param stat
> > + *    Valid cluster pointer to destroy.
> > + *
> This empty line can be removed.

Will fix in v4.

> > +/**
> > + * @warning
> > + * @b EXPERIMENTAL: this API may change without prior notice
> > + *
> > + * Clone a node from static node(node created from RTE_NODE_REGISTER).
> > + *
> > + * @param id
> > + *   Static node id to clone from.
> > + * @param name
> > + *   Name of the new node. The library prepends the parent node name to the
> > + * user-specified the name. The final node name will be,
> Change it to "the user-specified name".

Will fix in v4.