From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DEF1425E6; Wed, 20 Sep 2023 06:35:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25D1E402EE; Wed, 20 Sep 2023 06:35:24 +0200 (CEST) Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com [209.85.217.51]) by mails.dpdk.org (Postfix) with ESMTP id 620C9402DD for <dev@dpdk.org>; Wed, 20 Sep 2023 06:35:22 +0200 (CEST) Received: by mail-vs1-f51.google.com with SMTP id ada2fe7eead31-452951b27d0so486133137.2 for <dev@dpdk.org>; Tue, 19 Sep 2023 21:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695184522; x=1695789322; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lZ+MRThVEKzHIRXV/jyVZiBgk5GElzmibA+z6IGtmMo=; b=LY8WUI8CZDAvCy+kgIiaUh8kaN88vbFwOxQrgM9jOo35M+mXnKOIEaeisvtM/UyLIj 7gXqv3eXSOIpeGcQfIzZYUQ9iaORw/i94L3DvQllEeKrp30pONGdsutKpeqyROM+P9N5 p30GcIHmhUPtIcCgrAm3swo+Ct2hTisFwSpfhaxZsAZh+ETsdM3GjE9C1Oylhnu9dSZd 2H2bZSaCUjpzP+Ken0NSBdXI7Rw04XLMeNIkg5anzwJ33wCbL4FTeOcO+p26dvj1JAHW /3S8cMmtWLbYVMIVFsJ+DoilfqEOS5Rf24lvYMZyJRtibNjVHKuisYZ1E2APadg9Pv1I 0vmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695184522; x=1695789322; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lZ+MRThVEKzHIRXV/jyVZiBgk5GElzmibA+z6IGtmMo=; b=iu8J40FxpHdBBTmjMxMSK3VbUdPLILoi4g0BfrrY3HShr+bOvXbFg3qamtFRAqBteN YC6g1XaKmGEV/37Tcxb9P3ZSyaTbR9ERghBEaQDZONjh//X2fSCY4DF2nd86RnwExLgN xz1Hqevz9ZSqu91rLCZtjHGVnoHd4mbf/F9i29vr4FBKCiyAnInWqR/egFkx58hM23j6 hI/d9h9MV4SAvp/wL9KUMDvkf3PipTCGIZUN3wN6e2s6yWMp0aUdLCRT8vPVJcAtsW/l RjSK45BzH5YI+Xe5Q8p/oqy52ntv9JC7aI1skjqAifHQJEAbwmLQpo9pBHmjWQDfnxtu Mf7w== X-Gm-Message-State: AOJu0YywqBn7IHAys0hCrIQb/WrCI7ZzUH/LLlv7XdEkadyVfhApF+i4 NhipJzUuZef+bv7KsUWJb1km68UG3TH0jrXwTNo= X-Google-Smtp-Source: AGHT+IGBfcPsX0GwQrLCNNHJ+896ceX4W/p95rD377oqn5tjgENQPSt0kLbA4QbvyC4MuYxPdL7JQI8/Jr8jogFLD4Q= X-Received: by 2002:a67:e9c9:0:b0:452:6451:5e16 with SMTP id q9-20020a67e9c9000000b0045264515e16mr1512474vso.31.1695184521778; Tue, 19 Sep 2023 21:35:21 -0700 (PDT) MIME-Version: 1.0 References: <20230908104907.4060511-1-skori@marvell.com> <20230919160455.1678716-1-skori@marvell.com> <20230919160455.1678716-2-skori@marvell.com> In-Reply-To: <20230919160455.1678716-2-skori@marvell.com> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Wed, 20 Sep 2023 10:04:55 +0530 Message-ID: <CALBAE1MgV1+sD4wJOG+QjTLHpgqT+4=_bc1-ep3c16Z=bKgY3w@mail.gmail.com> Subject: Re: [PATCH v4 02/14] app/graph: add telnet connectivity framework To: skori@marvell.com Cc: Rakesh Kudurumalla <rkudurumalla@marvell.com>, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, Sep 19, 2023 at 9:35=E2=80=AFPM <skori@marvell.com> wrote: > > From: Sunil Kumar Kori <skori@marvell.com> > > It adds framework to initate a telnet session with application. > > Some configurations and debug commands are exposed as runtime APIs. > Those commands can be invoked using telnet session. > > Application initiates a telnet server with host address 0.0.0.0 > and port number 8086 by default. > > To make it configurable, "-h" and "-p" options are provided. > Using them user can pass host address and port number on which > application will start telnet server. > > Using same host address and port number, telnet client can connect > to application. > > Syntax to connect with application: > # telnet <host> <port> > > Once session is connected, "graph> " prompt will be available. > Example: > # telnet 10.28.35.207 50000 > Trying 10.28.35.207... > Connected to 10.28.35.207. > Escape character is '^]'. > > Welcome! > > graph> Some improvements 1) Please squash 14/14 patch to 1/14. 2) Ctrl - C doesn't work which is a serious issue. We have to kill it via kill -9 <pid> from a separate window. This is probably because of command line library. 3). In case app launch fails due to error, it will leave terminal into a bad state until "reset" command is executed. This might also be because of command line library. 4). Just a wishlist: If on terminal console I could do a tab and get commands help, just like testpmd console.