From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53953A317C for ; Thu, 17 Oct 2019 18:22:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 223921E887; Thu, 17 Oct 2019 18:22:58 +0200 (CEST) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id 888521E887 for ; Thu, 17 Oct 2019 18:22:56 +0200 (CEST) Received: by mail-il1-f196.google.com with SMTP id o18so2613695ilo.9 for ; Thu, 17 Oct 2019 09:22:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=36xzrLumM8SCiySJaNAje2t7++OKqPWmGNA+NoO7Scg=; b=CGorAqnSYEUSO/bV46IH7wxQ3F5KLRtZRwMGz9kQI6i5KNo7NQHQuameCdx0HQ+i8Q bC9yNzi39QLjWWEd/moLnrXSqDBq9850XNzoht7UYEpYgk/b1rjNwMDUoNMWMCHo28zi yJkzhtMxEggzokBhRgyBYejb4AEV7O5ezIq4g6u3kK3eLdYlkG3R1fLgNtNPZPTaFvP3 jmQgNxXHMAbKupguRvgsQhih7whOW0n7TBJ20+udWf+on37reuiPdTeM1nUubvbcxeLq WmXbxrU1L4yia7a0w/fDpCe6bJFOId16ntpvco3Oj0ucdXmYaUQBedWGRQrSbppG30ad cY8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=36xzrLumM8SCiySJaNAje2t7++OKqPWmGNA+NoO7Scg=; b=fwXTTuUdF9nHzP/mixC68ngXuX5RcSFq25N5oehZUfWI2AvGNkJv0uktZ1Qkn5IUQ1 eo5/tiw2nJhrUG4RZ3Nfum6IEwz1E7NpaQmkiBAVaiYnsiV2Yqgyu6hme+2j7gf5WyRZ sitChiSfZG9pzKVK/Ve9BOrc3kwLzKmBdr6+4TCNYMEiwuAhZateBJl9h6bLR7UErVbU Wylu3M7K5J2CldRrA4NNRHi9rGqR/ubo/LHxEmTfFlixOrZH48QIIvS+Z05YC/ViiUzl 16w//swGhaAEnHYdQLZQdxsT9Sa1YuUCGTpz2rHGtvPElCRnxz0+Efi1URVAv3YQvSuG nDQw== X-Gm-Message-State: APjAAAVqXTnxYcdI/lgg0TNkxmZBySW6nXB5Z1H5JSaQBK8tXs0xc+q/ yWEX6i51qI+5GeJkpO0QXTzENbVkQsd1GOIOMzDmpTWr2qQ= X-Google-Smtp-Source: APXvYqzWEHeD1Un6rCxIY48LP/xoLk/DVwKltXcyVCyeQlQmValC/XBS3/DW3YMqTRo18kueMTNpIshfkfZjgTNtMnQ= X-Received: by 2002:a92:2c03:: with SMTP id t3mr4676644ile.271.1571329374449; Thu, 17 Oct 2019 09:22:54 -0700 (PDT) MIME-Version: 1.0 References: <20191008090024.1250-1-pbhagavatula@marvell.com> <20191017122004.5446-1-pbhagavatula@marvell.com> In-Reply-To: <20191017122004.5446-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Thu, 17 Oct 2019 21:52:43 +0530 Message-ID: To: Pavan Nikhilesh Cc: Ferruh Yigit , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] net/octeontx2: add set supported types op X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 17, 2019 at 5:50 PM wrote: > > From: Pavan Nikhilesh > > Add support to set supported ptypes for octeontx2. > > Signed-off-by: Pavan Nikhilesh > --- > v2 Changes: > ---------- > - Update documentation. See below. > - Use positive logic. > > drivers/net/octeontx2/otx2_ethdev.c | 1 + > drivers/net/octeontx2/otx2_ethdev.h | 2 ++ > drivers/net/octeontx2/otx2_ethdev_devargs.c | 21 --------------------- > drivers/net/octeontx2/otx2_lookup.c | 15 +++++++++++++++ It looks like forgot to update the documentation file. 4 files changed, 18 insertions(+), 21 deletions(-) > > diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c > index 4a60f9f74..361a3d993 100644 > --- a/drivers/net/octeontx2/otx2_ethdev.c > +++ b/drivers/net/octeontx2/otx2_ethdev.c > @@ -1944,6 +1944,7 @@ static const struct eth_dev_ops otx2_eth_dev_ops = { > .dev_set_link_up = otx2_nix_dev_set_link_up, > .dev_set_link_down = otx2_nix_dev_set_link_down, > .dev_supported_ptypes_get = otx2_nix_supported_ptypes_get, > + .dev_supported_ptypes_set = otx2_nix_supported_ptypes_set, > .dev_reset = otx2_nix_dev_reset, > .stats_get = otx2_nix_dev_stats_get, > .stats_reset = otx2_nix_dev_stats_reset, > diff --git a/drivers/net/octeontx2/otx2_ethdev.h b/drivers/net/octeontx2/otx2_ethdev.h > index 33fa0c60b..a5bf89090 100644 > --- a/drivers/net/octeontx2/otx2_ethdev.h > +++ b/drivers/net/octeontx2/otx2_ethdev.h > @@ -506,6 +506,8 @@ void *otx2_nix_fastpath_lookup_mem_get(void); > > /* PTYPES */ > const uint32_t *otx2_nix_supported_ptypes_get(struct rte_eth_dev *dev); > +int otx2_nix_supported_ptypes_set(struct rte_eth_dev *eth_dev, > + uint32_t ptype_mask); > > /* Mac address handling */ > int otx2_nix_mac_addr_set(struct rte_eth_dev *eth_dev, > diff --git a/drivers/net/octeontx2/otx2_ethdev_devargs.c b/drivers/net/octeontx2/otx2_ethdev_devargs.c > index 7dc6e92be..9ad00c6f4 100644 > --- a/drivers/net/octeontx2/otx2_ethdev_devargs.c > +++ b/drivers/net/octeontx2/otx2_ethdev_devargs.c > @@ -63,21 +63,6 @@ parse_reta_size(const char *key, const char *value, void *extra_args) > return 0; > } > > -static int > -parse_ptype_flag(const char *key, const char *value, void *extra_args) > -{ > - RTE_SET_USED(key); > - uint32_t val; > - > - val = atoi(value); > - if (val) > - val = 0; /* Disable NIX_RX_OFFLOAD_PTYPE_F */ > - > - *(uint16_t *)extra_args = val; > - > - return 0; > -} > - > static int > parse_flag(const char *key, const char *value, void *extra_args) > { > @@ -105,7 +90,6 @@ parse_sqb_count(const char *key, const char *value, void *extra_args) > } > > #define OTX2_RSS_RETA_SIZE "reta_size" > -#define OTX2_PTYPE_DISABLE "ptype_disable" > #define OTX2_SCL_ENABLE "scalar_enable" > #define OTX2_MAX_SQB_COUNT "max_sqb_count" > #define OTX2_FLOW_PREALLOC_SIZE "flow_prealloc_size" > @@ -114,7 +98,6 @@ parse_sqb_count(const char *key, const char *value, void *extra_args) > int > otx2_ethdev_parse_devargs(struct rte_devargs *devargs, struct otx2_eth_dev *dev) > { > - uint16_t offload_flag = NIX_RX_OFFLOAD_PTYPE_F; > uint16_t rss_size = NIX_RSS_RETA_SIZE; > uint16_t sqb_count = NIX_MAX_SQB; > uint16_t flow_prealloc_size = 8; > @@ -129,8 +112,6 @@ otx2_ethdev_parse_devargs(struct rte_devargs *devargs, struct otx2_eth_dev *dev) > if (kvlist == NULL) > goto exit; > > - rte_kvargs_process(kvlist, OTX2_PTYPE_DISABLE, > - &parse_ptype_flag, &offload_flag); > rte_kvargs_process(kvlist, OTX2_RSS_RETA_SIZE, > &parse_reta_size, &rss_size); > rte_kvargs_process(kvlist, OTX2_SCL_ENABLE, > @@ -144,7 +125,6 @@ otx2_ethdev_parse_devargs(struct rte_devargs *devargs, struct otx2_eth_dev *dev) > rte_kvargs_free(kvlist); > > null_devargs: > - dev->rx_offload_flags = offload_flag; > dev->scalar_ena = scalar_enable; > dev->max_sqb_count = sqb_count; > dev->rss_info.rss_size = rss_size; > @@ -158,7 +138,6 @@ otx2_ethdev_parse_devargs(struct rte_devargs *devargs, struct otx2_eth_dev *dev) > > RTE_PMD_REGISTER_PARAM_STRING(net_octeontx2, > OTX2_RSS_RETA_SIZE "=<64|128|256>" > - OTX2_PTYPE_DISABLE "=1" > OTX2_SCL_ENABLE "=1" > OTX2_MAX_SQB_COUNT "=<8-512>" > OTX2_FLOW_PREALLOC_SIZE "=<1-32>" > diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c > index 3071278fc..8e15b59a0 100644 > --- a/drivers/net/octeontx2/otx2_lookup.c > +++ b/drivers/net/octeontx2/otx2_lookup.c > @@ -62,6 +62,21 @@ otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev) > return NULL; > } > > +int > +otx2_nix_supported_ptypes_set(struct rte_eth_dev *eth_dev, uint32_t ptype_mask) > +{ > + struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev); > + > + if (ptype_mask) > + dev->rx_offload_flags |= NIX_RX_OFFLOAD_PTYPE_F; > + else > + dev->rx_offload_flags &= ~NIX_RX_OFFLOAD_PTYPE_F; > + > + otx2_eth_set_rx_function(eth_dev); > + > + return 0; > +} > + > /* > * +------------------ +------------------ + > * | | IL4 | IL3| IL2 | TU | L4 | L3 | L2 | > -- > 2.17.1 >