From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8152A04E6; Tue, 17 Nov 2020 17:56:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5D8A637B1; Tue, 17 Nov 2020 17:56:08 +0100 (CET) Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by dpdk.org (Postfix) with ESMTP id 76AA237B0 for ; Tue, 17 Nov 2020 17:56:06 +0100 (CET) Received: by mail-il1-f193.google.com with SMTP id x18so5305527ilq.4 for ; Tue, 17 Nov 2020 08:56:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OmMlOOd/Sq94Mr5TzQA6LmycnjV/sRlUaYlG1luAAdc=; b=nQF9KgPyIMt4tM2RKevdknBqlqMMy14r7GE6QZLkVL3YQCmlPpzaPdbQHgxieotEdG VaQa04pS3VYvgPDMmMwepKG2ehLOeH04YamtTvvo6DrA/IRbQ9iO0oNy3gjdnXMDtsEC UlxPG4Be0msj/rl50s3gXGyQ1kELaZIwuxfWBCMqdcoRuR8W0UWSGZ0qoqG5w/laxbyG kuJjtCiKbXSEP8SeWw9lp72jKLwRZx0lQwUgQkDcHi7AcAdBSSvEg1widc0i1YlCOSDN EMwodwOxdYTyvKSiCfORzxful59FQAM5zXAzkLdiw/0lUrWEEJP5gxOIpLB5EKbOaolb aEBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OmMlOOd/Sq94Mr5TzQA6LmycnjV/sRlUaYlG1luAAdc=; b=KPTsCrW7PoDcRImgQTBnc0l6a/WqXKxbSSjVeG1U3RwhteKrA0JMZdIL7YeVmE+DHM +slt7nVBz7DK8mCiFSGmsSqkXiiveSuEUkIuKEwEbhpcoswo7/30bdZRY3HMrQoweHCs lFu6OhirKCPeNlQ9piIMaO85oPs0VwavNxAagfrm3eRCCgQOKQchdyiaaDarMBrq96EA 0PVugpiLRZt6V+U3Zl8xa5E1SUrfexSYi0TbGtUE7O4IZdirdnHbmFjxSr0J2gDCxLGq OLHB01jzdb5PczWnhtyMNqpauyOew6O+BQ1KvVv0IUBcb+fhzlF6vF+FSzPPNHfmlL06 EmiQ== X-Gm-Message-State: AOAM533NczneEhQr7Qm3ciefqUihyLkkpMmbF8knxpOmmhRkCymCP4la jZ8EXz+uAQwt7jq2dhg9KgcR7Nf8YMeeuLWRPyY= X-Google-Smtp-Source: ABdhPJziHVhYRLtLtxxVGwIqtqVw66SaKv72A58PH1EBgv9hLsq4nsu/JRkQHq9YRtuUz8hPa3zyNWuj6afUAPccMrM= X-Received: by 2002:a05:6e02:c61:: with SMTP id f1mr11826559ilj.60.1605632164824; Tue, 17 Nov 2020 08:56:04 -0800 (PST) MIME-Version: 1.0 References: <20201116144155.148634-1-hkalra@marvell.com> In-Reply-To: <20201116144155.148634-1-hkalra@marvell.com> From: Jerin Jacob Date: Tue, 17 Nov 2020 22:25:47 +0530 Message-ID: To: Harman Kalra , Ferruh Yigit Cc: Jerin Jacob , Nithin Dabilpuram , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] common/octeontx2: fix msix offset structure fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 16, 2020 at 8:12 PM Harman Kalra wrote: > > Syncing the data types of msix offset mbox response structure > fields wrt rvu_pfvf structure as in msix offset mbox handler, > respective block LFs response field is initialised with rvu_pfvf > and mismatch in the data types of respective fields may lead > to issues. > > This mismatch in data types resulted in a bug where no sso msix > offsets are returned. For 256 SSO hwgrps, 256 msix offsets > are required, but since num of sso lf field (rsp->sso) in > response structure is u8 and is initialised with same field > in pfvf structure viz u16, value 256 corresponds to 0 hence > no sso_msixoff. > Similar mbox changes are required in kernel side also which are > available in marvell SDK version SDK-11.0. > > Fixes: 2b71657c8660 ("common/octeontx2: add mbox request and response definition") > > Signed-off-by: Harman Kalra Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/for-main. Thanks > --- > drivers/common/octeontx2/otx2_mbox.h | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/common/octeontx2/otx2_mbox.h b/drivers/common/octeontx2/otx2_mbox.h > index 9a1e8a7ea..f6d884c19 100644 > --- a/drivers/common/octeontx2/otx2_mbox.h > +++ b/drivers/common/octeontx2/otx2_mbox.h > @@ -90,7 +90,7 @@ struct mbox_msghdr { > #define OTX2_MBOX_RSP_SIG (0xbeef) > /* Signature, for validating corrupted msgs */ > uint16_t __otx2_io sig; > -#define OTX2_MBOX_VERSION (0x0009) > +#define OTX2_MBOX_VERSION (0x000a) > /* Version of msg's structure for this ID */ > uint16_t __otx2_io ver; > /* Offset of next msg within mailbox region */ > @@ -454,17 +454,17 @@ struct msix_offset_rsp { > struct mbox_msghdr hdr; > uint16_t __otx2_io npa_msixoff; > uint16_t __otx2_io nix_msixoff; > - uint8_t __otx2_io sso; > - uint8_t __otx2_io ssow; > - uint8_t __otx2_io timlfs; > - uint8_t __otx2_io cptlfs; > + uint16_t __otx2_io sso; > + uint16_t __otx2_io ssow; > + uint16_t __otx2_io timlfs; > + uint16_t __otx2_io cptlfs; > uint16_t __otx2_io sso_msixoff[MAX_RVU_BLKLF_CNT]; > uint16_t __otx2_io ssow_msixoff[MAX_RVU_BLKLF_CNT]; > uint16_t __otx2_io timlf_msixoff[MAX_RVU_BLKLF_CNT]; > uint16_t __otx2_io cptlf_msixoff[MAX_RVU_BLKLF_CNT]; > - uint8_t __otx2_io cpt1_lfs; > - uint8_t __otx2_io ree0_lfs; > - uint8_t __otx2_io ree1_lfs; > + uint16_t __otx2_io cpt1_lfs; > + uint16_t __otx2_io ree0_lfs; > + uint16_t __otx2_io ree1_lfs; > uint16_t __otx2_io cpt1_lf_msixoff[MAX_RVU_BLKLF_CNT]; > uint16_t __otx2_io ree0_lf_msixoff[MAX_RVU_BLKLF_CNT]; > uint16_t __otx2_io ree1_lf_msixoff[MAX_RVU_BLKLF_CNT]; > -- > 2.18.0 >