From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D93D8A034F; Fri, 7 May 2021 11:17:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 63BAE4013F; Fri, 7 May 2021 11:17:50 +0200 (CEST) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by mails.dpdk.org (Postfix) with ESMTP id 56B2340040 for ; Fri, 7 May 2021 11:17:49 +0200 (CEST) Received: by mail-io1-f54.google.com with SMTP id l21so7391063iob.1 for ; Fri, 07 May 2021 02:17:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8gu+8IAOeuWTFNyyV8IWxxlcZzU8cNO8yVsy0g7mc8Y=; b=h4IdT1g7bsFw42VYVpZqHb/OuVUEo/2iRuHnVSxbIYy4THYhbkxtOQ0crzTmshbJge FEfNlc4U460/fpJ43wpgss4xezZtCfREftAScZxapL+QrUs/5PjrbSTJL+CvSfn0drKG uNnm7hE1Bpc6GODLLdW/0xqEJsZ7n8v7GXXqcMnf2x+ZEQ3bseSpmo343xp8AwfWfy6V mp44HhD13jvtfvqgkQyKLq3yHJfFfLb/lb9nN51xEStfs7u4m+P182oeXcJr3mLkL8K7 5QqRCoB02dyDYybCnZoH+06pWqi9x5Dq1aP5sFHRdJ7SMB57p9BVmHt6y7zPt/bwMYYL bYug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8gu+8IAOeuWTFNyyV8IWxxlcZzU8cNO8yVsy0g7mc8Y=; b=jSKzzcaIQC5xErbK+eDecP4V9TFhbCcgx72BQDNrrv0XXaQIwJuLlVxjDcauU35FKo NiIkGl1QwygcbDV18UUxNF+Ua4diPFCcmXsWlPJ8tYEUcNAPdXdLUONuXGoWtcTdefT3 c0XVDlgEARihr9jeNtepdbElL2eXQzQolP/lDQzQPdgdScOOphuNNuIFW62MYPcRY3NT T19/WvqxpRQWVvlTyo+OCvo6yvP81a7vO8b7EBCj6ozp+Wesb4A56XwpsNyk34jxRLJ/ tBPkWpDniyZxl6/zGq7p2vEx9rK5KdsC8KskycZfoDmK5GH6i1235qWJA9cp53k35IbX vJLg== X-Gm-Message-State: AOAM530laf8qMjrs0729sVnkuEGTYpagtFcsR8ZP7wREhN1oz9lxsqZK mdY7cfX37F9K75VnhzAjs6DwXfLsgtSHb3x0Nb4= X-Google-Smtp-Source: ABdhPJx5v+p0h8DLiY//7MtgJ5b5RRGnBQ+Fijt0y7p2bPRE5STmVZEJo/ZyNX977AC5mIgjoKAAv+t9duQVnj6/+Yg= X-Received: by 2002:a5d:8188:: with SMTP id u8mr7088007ion.163.1620379068736; Fri, 07 May 2021 02:17:48 -0700 (PDT) MIME-Version: 1.0 References: <20210415090859.1319171-1-gakhil@marvell.com> <347ace77-7704-5ac4-7dd9-0cabe88dfce0@ashroe.eu> In-Reply-To: From: Jerin Jacob Date: Fri, 7 May 2021 14:47:32 +0530 Message-ID: To: "Kinsella, Ray" Cc: Akhil Goyal , Jerin Jacob Kollanukkaran , "thomas@monjalon.net" , "dev@dpdk.org" , "david.marchand@redhat.com" , "abhinandan.gujjar@intel.com" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "sachin.saxena@oss.nxp.com" , Anoob Joseph , "matan@nvidia.com" , "roy.fan.zhang@intel.com" , "g.singh@nxp.com" , "erik.g.carrillo@intel.com" , "jay.jayatheerthan@intel.com" , Pavan Nikhilesh Bhagavatula , "harry.van.haaren@intel.com" , Shijith Thotton Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] doc: announce modification in eventdev structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, May 4, 2021 at 3:06 PM Kinsella, Ray wrote: > > > > On 03/05/2021 12:18, Akhil Goyal wrote: > > Hi Ray, > >>> @@ -127,6 +127,10 @@ Deprecation Notices > >>> values to the function ``rte_event_eth_rx_adapter_queue_add`` using > >>> the structure ``rte_event_eth_rx_adapter_queue_add``. > >>> > >>> +* eventdev: The function pointer ``ca_enqueue`` in structure > >> ``rte_eventdev`` > >>> + will be moved after ``txa_enqueue`` so that all enqueue/dequeue > >>> + function pointers are adjacent to each other. > >>> + > >>> * sched: To allow more traffic classes, flexible mapping of pipe queues to > >>> traffic classes, and subport level configuration of pipes and queues > >>> changes will be made to macros, data structures and API functions > >> defined > >>> > >> > >> I admire the disipline - but since you are not actually removing ca_enqueue, > >> just moving it in memory when the new ABI is declared in anycase, this is not > >> required. > >> > > > > Does it mean we can move elements in a structure without giving deprecation notice? > > > > well if memory serves - you aren't depreciating the field, just moving it, right? > And you are aligning the change with an ABI break in anycase - so I think it is all good. OK. Change the status of the patch in patchwork as "Not applicable" > > Ray K