From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20D89A057B; Wed, 1 Apr 2020 22:00:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7F5F51C197; Wed, 1 Apr 2020 22:00:41 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id C7F7C1C196 for <dev@dpdk.org>; Wed, 1 Apr 2020 22:00:39 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id q9so1095051iod.4 for <dev@dpdk.org>; Wed, 01 Apr 2020 13:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wrVJI38tQhP2yRLSvu/LFgGh5gLUjMZgf3EDCBYFa68=; b=AOSxKQlQOtc6Qwe9v7pSy3auuT1bTStnvAw3rHLuE8n1jlsepUlPNTPJeQHcKN9zEL ftWnzil8D642KZUjEKp5UqJzP/bAbCxIH2u102832CR8T9Gnm8zUASr77lVl2ySsuGti 9EMXgsxkHQHMhy+kQG4Q8v9cCiuwyujslmNVL17F1B1ES6PsesjcQfJEI6GmzpWoLiwV qyg9dt2xFZEq6y6XW4iqnDJHfksi6Y8+6qH3OAITk2RT78xGOEgYwhzlEBJgEAlwCHRu BL4YD5kLaeJWVgQxJRHyYH0DFAqTP6gzhbSTxYHhN4uZaup17/rrBvtOq2YJ99gGVo1+ mglA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wrVJI38tQhP2yRLSvu/LFgGh5gLUjMZgf3EDCBYFa68=; b=EYzr4TNXRYVONmUzmtnVoYj7+zRHOiIB7f235YMjCOEvRagfe3v9p/HMgQMrDU45aT BZ9T/ZAHziNl4arCm1Q6hHaTDMTgvNxTlcGH4sUdtytsmiC7IHHXsNVcWO6U/me3gKl5 tDzJmzj24dkuZAh+1LIsVncQPRPLdaPvWnhqga01aeMFRGovMUzmVgFmf+wXiHHv0h89 v2aKswSaipC18rZwbR4R1Rwo1tlI5oSyKbyRtrEWN8PzW5hTyYPHWh2YXnwMQ9/kOdo3 61Llw30WTIxJsd4CnUOUqrtR2UvGLiCyXRSWmYYhw1HcdpESbUf0gAQ/g2tXoU2+iN6F Y4DA== X-Gm-Message-State: ANhLgQ2osDMCmU40J4NeZPgjQ2+sAioBtSQHPVk7EjCM5UTLOfJ2jvNS KL2Q16zKzzLaTCwN7pnc9S34oOA8WWBYbY+n4go= X-Google-Smtp-Source: ADFU+vtuHhm0i1Vwb4tp8f3X24WlxQRKW0petuPhV04zJfjHBpUNmkhyZaTN8J8wwDgLUqdgdyRub9g/PO8RnoxNOOA= X-Received: by 2002:a5d:87c6:: with SMTP id q6mr16895570ios.163.1585771238943; Wed, 01 Apr 2020 13:00:38 -0700 (PDT) MIME-Version: 1.0 References: <20200325211603.240288-1-jerinj@marvell.com> <CALBAE1M3nbeFfYe-doEcM_m4aJhHfaOuHG94htd9XXVoDqW7MA@mail.gmail.com> <CALBAE1PrE3bvbv8tnTPibL_xLVmJ5fEE6wr4iSkHe1NpOqyepw@mail.gmail.com> <3173562.8FI41Ny9JD@xps> In-Reply-To: <3173562.8FI41Ny9JD@xps> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Thu, 2 Apr 2020 01:30:20 +0530 Message-ID: <CALBAE1Mm3TJ7-3Kri1w03U9aUqPKBkMh+EOw0UXXneOAsEKR7A@mail.gmail.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: David Marchand <david.marchand@redhat.com>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>, =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>, Sunil Kumar Kori <skori@marvell.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, Declan Doherty <declan.doherty@intel.com>, Olivier Matz <olivier.matz@6wind.com>, Neil Horman <nhorman@tuxdriver.com>, Ray Kinsella <mdr@ashroe.eu> Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 00/33] DPDK Trace support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Thu, Apr 2, 2020 at 1:13 AM Thomas Monjalon <thomas@monjalon.net> wrote: > > 01/04/2020 21:14, Jerin Jacob: > > On Wed, Apr 1, 2020 at 11:22 PM Jerin Jacob <jerinjacobk@gmail.com> wrote: > > > > > > On Wed, Apr 1, 2020 at 11:02 PM David Marchand > > > <david.marchand@redhat.com> wrote: > > > > > > > > On Wed, Apr 1, 2020 at 6:25 PM Jerin Jacob <jerinjacobk@gmail.com> wrote: > > > > > On Wed, Apr 1, 2020 at 7:42 PM David Marchand <david.marchand@redhat.com> wrote: > > > > > > On Wed, Apr 1, 2020 at 12:05 PM Jerin Jacob <jerinjacobk@gmail.com> wrote: > > > > > > > I assume the patch content will be: > > > > > > > 1) Removing experimental API from app, lib, drivers, examples with > > > > > > > make and meson > > > > > > > 2) Have it enabled at the global level. > > > > > > > > > > > > examples are a special case as they can be compiled out of the dpdk sources. > > > > > > This is why I excluded them of the list in my mail before. > > > > > > > > > > There are a lot of examples already that have ALLOW_EXPERIMENTAL_API. > > > > > What is the issue in enabling ALLOW_EXPERIMENTAL_API in the in tree > > > > > example application? > > > > > > > > I did not say there is an issue in keeping this flag in the example makefiles. > > > > > > > > examples makefile should be self sufficient (like an external > > > > application makefile would be) and are called directly in our building > > > > test scripts: see devtools/test-meson-builds.sh. > > > > So I don't see how it would work if you remove this flag from all > > > > examples makefiles and rely on some global thing. > > > > > > Thanks for the clarification. I will update meson.build and Makefile in > > > examples. > > > > > > devtools/test-meson-builds.sh tests[1] the the below apps, > > > "cmdline helloworld l2fwd l3fwd skeleton time" > > > > > > What is your preference, Adding in all the examples or above selected ones? > > > > > > Since meson installing example application as well. I will update the > > effected examples > > with ALLOW_EXPERIMENTAL_API > > I think you need to update all examples. OK. Will do next version. > >