From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98E19A0548; Sun, 9 May 2021 18:07:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EFC9041109; Sun, 9 May 2021 18:07:00 +0200 (CEST) Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by mails.dpdk.org (Postfix) with ESMTP id EE94D41106 for ; Sun, 9 May 2021 18:06:59 +0200 (CEST) Received: by mail-il1-f179.google.com with SMTP id v13so11966327ilj.8 for ; Sun, 09 May 2021 09:06:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zzxYNoo9bhmOkPq10oqDp+gAly7dlJVzEgsK92CtaaE=; b=YEQjgdszcql+V7dBvEvVjA+SXzDZcqqBjlF4Mh6vQnHdr4i9/bfBS00eBwZ0cYh6HK iSfYZKelVHRFR29dhBJamnIm/TASiu+l0PQc6FrXl6232V9cSFtmwlcEZ2bil6rFpfIx KAWsFxb+PJyeBSfBwBuiiTsB5oM15EOBeDkeYLbWvBCqs72Qyq7kZO3ct6MoO3476AfP 45JaJS32juMkW9lMAFnuA49eRkQR78jfvDZfkMtEM0QjYn3atgA9yuN8w6U5TwP0uTVh UEwxOrW1lzNH19tXcWytCWB0WExh/yrNUy8r+FV1WvSG5MzhwrokjPMmxqZei9dR19Hl l3ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zzxYNoo9bhmOkPq10oqDp+gAly7dlJVzEgsK92CtaaE=; b=K9Dj9Nd+TYNp29EVAJ3MbYCGd9Gj04h2DlrFGJFrrCyF3UJkqeVNa3r0A/7IV+M/CO zNYcOz9aYNnIbTfgmJ/Tj4mpNI5Dey4x8AkknUOSRZTknwBxNs8IlGd6tVXGxTXjqM80 Q1GuZBTU5jqlRJaWOF1hjlMic4EJJtPOmG+t9tYgyksODLYeITQeAzZ452oufoJyBdCq AKdaPWP649+b7KygqoTs/uhFC5PvL+E+3ufOE/nGPurj03xraYWES64DOjmT4P7LJrJe PICijyu45h0BuSqKXS7aXGxcWh9mUUrpd1C+D+rKgZDjWVTSIYungu7d3fosWqRG7F/M rgoA== X-Gm-Message-State: AOAM531yuW7+rk0XC6N9XClTto+5PfLWUUfaD4HR2xSSxu2sxCw7/rnd pxfZcAmOAaAAnn5ub537aSK/n8Bx52NI6McqVNogHXIz+cgPTA== X-Google-Smtp-Source: ABdhPJxhstIAV+ldpvGTvxWd1wFD3RSLgrfYTyGSfYNYP5RWAsBPTsb2BOgAbNe8DD2fFd+ufClFT6oczFrVz3i4KgU= X-Received: by 2002:a05:6e02:b28:: with SMTP id e8mr19235842ilu.60.1620576419389; Sun, 09 May 2021 09:06:59 -0700 (PDT) MIME-Version: 1.0 References: <7d28b0e4a5e0eb715eaced93b98af833da34b63b.1620382076.git.sthotton@marvell.com> In-Reply-To: <7d28b0e4a5e0eb715eaced93b98af833da34b63b.1620382076.git.sthotton@marvell.com> From: Jerin Jacob Date: Sun, 9 May 2021 21:36:43 +0530 Message-ID: To: Shijith Thotton Cc: dpdk-dev , Erik Gabriel Carrillo , Jerin Jacob , Pavan Nikhilesh Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1] test/event: fix return value of timer test setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 7, 2021 at 3:42 PM Shijith Thotton wrote: > > Test case setup should return -ENOTSUP, if it is not supported. > > Fixes: 7d761b07fcf6 ("test/event: add unit tests for periodic timer") Cc: stable@dpdk.org > > Signed-off-by: Shijith Thotton Acked-by: Jerin Jacob Applied to dpdk-next-eventdev/for-main. Thanks. > --- > app/test/test_event_timer_adapter.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/app/test/test_event_timer_adapter.c b/app/test/test_event_timer_adapter.c > index c36ab32ac..121c2d93e 100644 > --- a/app/test/test_event_timer_adapter.c > +++ b/app/test/test_event_timer_adapter.c > @@ -303,10 +303,8 @@ _timdev_setup(uint64_t max_tmo_ns, uint64_t bkt_tck_ns, uint64_t flags) > "failed to get adapter capabilities"); > > if (flags & RTE_EVENT_TIMER_ADAPTER_F_PERIODIC && > - !(caps & RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC)) { > - printf("Adapter does not support periodic timers\n"); > - return TEST_SKIPPED; > - } > + !(caps & RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC)) > + return -ENOTSUP; > > if (!(caps & RTE_EVENT_TIMER_ADAPTER_CAP_INTERNAL_PORT)) { > timdev = rte_event_timer_adapter_create_ext(&config, > -- > 2.25.1 >