From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1B54A0562; Mon, 29 Mar 2021 17:51:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE593140E25; Mon, 29 Mar 2021 17:51:35 +0200 (CEST) Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by mails.dpdk.org (Postfix) with ESMTP id 231F8140E1D for ; Mon, 29 Mar 2021 17:51:34 +0200 (CEST) Received: by mail-il1-f175.google.com with SMTP id j16so3058989ilq.13 for ; Mon, 29 Mar 2021 08:51:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n6Cwm8mNRR+SIAW2JrQhIoWImGuf4u+Z9WrWpaJIboY=; b=oEwWGhL7nn7nJF9U3WkiieHkj9shifrYZL+k8Y78rfVUK1g8de1eeHxuSFe+FTxQwD 9PsuLdgcrHXd6T79jAtGmZqfP6V6MYHaF326MJJmAmy8PoPUHv9dTVI6cfdgav7gvE4t ZFhRbjbUwEYHg8rphFJIWkVCXKopsjK+uSAPS35uaaOioMr2QQnXvcsj+G6oJlS0u3Xa 9PvQIVSFONXJFEVdx6VFbFjrCyZgW7msTBEhUQeTq2rIO7JpdD5/nyDskRJ6iEurELhC UIAl+Z7dOEaAlAbJY6Y/XTvMyFCvrwM4IrZOXBCU4I6/bdHYFTq+3MUDrBT0znhFv2Hq k78A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n6Cwm8mNRR+SIAW2JrQhIoWImGuf4u+Z9WrWpaJIboY=; b=iJxbcwLZfopTz6SvDBQ9OVvZlemQZXLYF372hGjD60JUVukNKoF2Q1fiDT6XZUmkvT 5P+7rF0sjrZ65VkpCmJ8DkYRo9260KF2aBkLSPNGuK87Yey1jHR8Jb8sFgrpGEIFfzEa ik/7RD5WvKrcGYInK31OS2IqOk/QhgOUImPTTh3yH9siucWoW4jZa4jijUlJaicnjwJ+ ulkiLloWIyysevOFax8bUcaXIJTpltAf/xGqF1dU8rTE63hS6Pi6XjoUmJpnREdGQe6o 9SZKtHI5kbu07z0/DhugAbjUBwn7lraiOd07hsGo8t9MqUVp9kRrOz3o1nN0Su7jFSVc sN7A== X-Gm-Message-State: AOAM531YsfgeaqECqmfDJdqsbJm8xoczakJfbtiduGpQyvktPdSIhst+ 1buI9/b2OCh7tuUjaugvcaptWyd5UPfEtpdQn3s= X-Google-Smtp-Source: ABdhPJzsV6Eg3pwr6uAR9mdEGHhh3SC+zmCm/55752lut8FGMpkBnd+WVdOShnpjVJDPhB0f1w+gDQJsgYItcpOMdKI= X-Received: by 2002:a92:d28b:: with SMTP id p11mr21445168ilp.130.1617033093492; Mon, 29 Mar 2021 08:51:33 -0700 (PDT) MIME-Version: 1.0 References: <20210316221857.2254-1-timothy.mcdaniel@intel.com> <20210316221857.2254-2-timothy.mcdaniel@intel.com> In-Reply-To: From: Jerin Jacob Date: Mon, 29 Mar 2021 21:21:17 +0530 Message-ID: To: "McDaniel, Timothy" Cc: dpdk-dev , Jerin Jacob , "Van Haaren, Harry" , Ray Kinsella , Neil Horman , "Rao, Nikhil" , "Carrillo, Erik G" , "Gujjar, Abhinandan S" , Pavan Nikhilesh , Hemant Agrawal , "mattias.ronnblom" , "Mccarthy, Peter" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Mar 29, 2021 at 8:30 PM McDaniel, Timothy wrote: > > > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Friday, March 26, 2021 9:33 AM > > To: McDaniel, Timothy > > Cc: dpdk-dev ; Jerin Jacob ; Van Haaren, > > Harry ; Ray Kinsella ; Neil > > Horman ; Rao, Nikhil ; > > Carrillo, Erik G ; Gujjar, Abhinandan S > > ; Pavan Nikhilesh > > ; Hemant Agrawal ; > > mattias.ronnblom ; Mccarthy, Peter > > > > Subject: Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe > > > > On Fri, Mar 26, 2021 at 7:33 PM McDaniel, Timothy > > wrote: > > > > > > > > > > > > > -----Original Message----- > > > > From: Jerin Jacob > > > > Sent: Friday, March 26, 2021 6:01 AM > > > > To: McDaniel, Timothy > > > > Cc: dpdk-dev ; Jerin Jacob ; Van > > Haaren, > > > > Harry ; Ray Kinsella ; Neil > > > > Horman ; Rao, Nikhil ; > > > > Carrillo, Erik G ; Gujjar, Abhinandan S > > > > ; Pavan Nikhilesh > > > > ; Hemant Agrawal > > ; > > > > mattias.ronnblom ; Mccarthy, Peter > > > > > > > > Subject: Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe > > > > > > > > On Thu, Mar 25, 2021 at 1:01 AM McDaniel, Timothy > > > > wrote: > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Jerin Jacob > > > > > > Sent: Sunday, March 21, 2021 4:48 AM > > > > > > To: McDaniel, Timothy > > > > > > Cc: dpdk-dev ; Jerin Jacob ; Van > > > > Haaren, > > > > > > Harry ; Ray Kinsella ; > > Neil > > > > > > Horman ; Rao, Nikhil ; > > > > > > Carrillo, Erik G ; Gujjar, Abhinandan S > > > > > > ; Pavan Nikhilesh > > > > > > ; Hemant Agrawal > > > > ; > > > > > > mattias.ronnblom ; Mccarthy, Peter > > > > > > > > > > > > Subject: Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe > > > > > > > > > > > > On Wed, Mar 17, 2021 at 3:49 AM Timothy McDaniel > > > > > > wrote: > > > > > > > > > > > > > > This commit adds dlb v2.5 probe support, and updates > > > > > > > parameter parsing. > > > > > > > > > > > > > > The dlb v2.5 device differs from dlb v2, in that the > > > > > > > number of resources (ports, queues, ...) is different, > > > > > > > so macros have been added to take the device version > > > > > > > into account. > > > > > > > > > > > > > > This commit also cleans up a few issues in the original > > > > > > > dlb2 source: > > > > > > > - eliminate duplicate constant definitions > > > > > > > - removed unused constant definitions > > > > > > > > > > > > > > Signed-off-by: Timothy McDaniel > > > > > > > --- > > > > > > > > > > > > > > > > > > > > -#define EVDEV_DLB2_NAME_PMD dlb2_event > > > > > > > +#define EVDEV_DLB2_NAME_PMD dlb_event > > > > > > > > > > > > Is this an intended change? why change the driver's name. > > > > > > > > > > Yes, This is an intentional change. We will be using the same driver name > > > > going forward, regardless of the hardware version. > > > > > Internally, we know which version of the hardware is present. > > > > > > > > Since the driver name is still driver/event/dlb2. Keep it as same > > > > prefix scheme with other drivers. > > > > > > > > > > > > > > > > > > Thanks, > > > > > Tim > > > > > > > > > > > Would it be acceptable to rename drivers/event/dlb2 to drivers/event/dlb? > > > We may have additional dlb devices in the pipeline, such as v3, and we would > > really like > > > to have them all use a common name. > > > > Makes sense to change to drivers/event/dlb. I think, we can make to > > dlb when you > > add v3 support. Now there is no need. > > > > > > > > > Hi Jerin, > > I spoke to the team, and we would like to get this change in now. It happens that we have > several applications that use the eventdev API rte_event_dev_get_dev_id(const char *name). > Having a single name simplifies these applications, and also prevents customers from having to > update application source code every time a new dlb device is released. Now that we removed drivers/event/dlb, Please rename drivers/event/dlb2 as drivers/event/dlb. and change EVDEV_DLB_NAME_PMD as dlb_event and submit the new patch patches for v2.5. > > Thanks, > Tim >