From: Jerin Jacob <jerinjacobk@gmail.com>
To: Kiran Kumar K <kirankumark@marvell.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: disable HIGIG on port stop
Date: Tue, 28 Jan 2020 16:57:35 +0530 [thread overview]
Message-ID: <CALBAE1Mmw=5W3tRQR=9AEYyf=CcSbWTWjHu96FH5DBHbb9kgwA@mail.gmail.com> (raw)
In-Reply-To: <20200124135426.13157-1-kirankumark@marvell.com>
On Fri, Jan 24, 2020 at 7:25 PM <kirankumark@marvell.com> wrote:
>
> From: Kiran Kumar K <kirankumark@marvell.com>
>
> If HIGIG mode is enabled on configure, This needs to be disabled
> on port stop. Adding support to send mbox message on port stop
> to configure the port to default.
>
> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/master. Thanks
> ---
> drivers/net/octeontx2/otx2_ethdev.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c
> index 268b383db..11f8c786b 100644
> --- a/drivers/net/octeontx2/otx2_ethdev.c
> +++ b/drivers/net/octeontx2/otx2_ethdev.c
> @@ -93,7 +93,7 @@ nix_lf_alloc(struct otx2_eth_dev *dev, uint32_t nb_rxq, uint32_t nb_txq)
> }
>
> static int
> -nix_lf_switch_header_type_enable(struct otx2_eth_dev *dev)
> +nix_lf_switch_header_type_enable(struct otx2_eth_dev *dev, bool enable)
> {
> struct otx2_mbox *mbox = dev->mbox;
> struct npc_set_pkind *req;
> @@ -106,12 +106,16 @@ nix_lf_switch_header_type_enable(struct otx2_eth_dev *dev)
> /* Notify AF about higig2 config */
> req = otx2_mbox_alloc_msg_npc_set_pkind(mbox);
> req->mode = dev->npc_flow.switch_header_type;
> + if (enable == 0)
> + req->mode = OTX2_PRIV_FLAGS_DEFAULT;
> req->dir = PKIND_RX;
> rc = otx2_mbox_process_msg(mbox, (void *)&rsp);
> if (rc)
> return rc;
> req = otx2_mbox_alloc_msg_npc_set_pkind(mbox);
> req->mode = dev->npc_flow.switch_header_type;
> + if (enable == 0)
> + req->mode = OTX2_PRIV_FLAGS_DEFAULT;
> req->dir = PKIND_TX;
> return otx2_mbox_process_msg(mbox, (void *)&rsp);
> }
> @@ -1648,7 +1652,7 @@ otx2_nix_configure(struct rte_eth_dev *eth_dev)
> goto free_nix_lf;
> }
>
> - rc = nix_lf_switch_header_type_enable(dev);
> + rc = nix_lf_switch_header_type_enable(dev, true);
> if (rc) {
> otx2_err("Failed to enable switch type nix_lf rc=%d", rc);
> goto free_nix_lf;
> @@ -1882,6 +1886,7 @@ otx2_nix_dev_stop(struct rte_eth_dev *eth_dev)
> struct otx2_eth_rxq *rxq;
> int count, i, j, rc;
>
> + nix_lf_switch_header_type_enable(dev, false);
> nix_cgx_stop_link_event(dev);
> npc_rx_disable(dev);
>
> --
> 2.17.1
>
prev parent reply other threads:[~2020-01-28 11:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 13:54 kirankumark
2020-01-28 11:27 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1Mmw=5W3tRQR=9AEYyf=CcSbWTWjHu96FH5DBHbb9kgwA@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).