From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6245A0093; Mon, 7 Nov 2022 15:22:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A86140156; Mon, 7 Nov 2022 15:22:48 +0100 (CET) Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by mails.dpdk.org (Postfix) with ESMTP id AE26340151; Mon, 7 Nov 2022 15:22:46 +0100 (CET) Received: by mail-yb1-f175.google.com with SMTP id 131so9376583ybl.3; Mon, 07 Nov 2022 06:22:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TlaCkuqu6WCrip97YvaMH1eYfMdsCRVskQp/b05xsS4=; b=nsOlhkzXUG+mBrqUH75EzKd3AinAMO7IUcqXqf2fMBROv2TSoin/S0CGTXE9Y5S8BE IaAL2fROilHi6Mmpwu+GHok5WOi71l3W/xkR4GgssqsvZbQ5YDbdAnsNw7mPUdXkstSm m5FLOXSfQHoTimxvtyEmbGfoxdqJC3A1ucW02qt5u1zNiWBESXg02sR6IiZjVJR5viyb mFQpDk8X0dJ+QMraIJQc2ubJRn71iX0WAGxSfoGqRGBW24ojZA/sKSeLeQPC3GGqno6n WH4DxKxX89nc981a1K76r08+t341PWa1tMjDwpsF/tQfUUljzeuU+MZg3OoF94qCejwH sBQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TlaCkuqu6WCrip97YvaMH1eYfMdsCRVskQp/b05xsS4=; b=xFSQdSqTaZd0f0e7tDxRU27oOu6/Ic1OBbSqUQITPWQaa1L0TSGAxRvnqy9XBjG/EK lxjLz241/+T0G9mZJMqtHF/dWj0i0On7tfV0tYN7LaYEfmmeJUiNVyPp/pl2NrqMmSU0 TdHtbztEFBDj/hiPv+JqksDm0Kze4PlviS7DSY4VdD9p5lLle93g9nBfMpv0i3WpITUN BpoDdojo4Gyq45YfCZRQR6GWVTHXjkzhONj/y9MevXqXToevJh+aCuaG39TWU8iHIVL6 DPO7HKmcCy+Y6l3SJPaUsin+pTXeSLfd3htldC+9W9IX6NKnIXdhkbbL1vpl3Q2mt2Zu srAw== X-Gm-Message-State: ANoB5pmg2FaqbiCZxs0nMZ0bEHZZpt5qVSSLl2T8E3PH8BMM9D33f4hE 1O1wGg3o6y92LB3aDz5iKgtYdXIDas0dT7UALO0= X-Google-Smtp-Source: AA0mqf5iMANeHN9zgG3FLXN2UbA7gJs+fkT8Gf7lK74GXTdyUdVuTJ8LbWWe4RhS+N1O2MQ1B5Lw/J5NN9JWH4yfKe0= X-Received: by 2002:a25:8b8f:0:b0:6d6:acf:193c with SMTP id j15-20020a258b8f000000b006d60acf193cmr8088238ybl.524.1667830966011; Mon, 07 Nov 2022 06:22:46 -0800 (PST) MIME-Version: 1.0 References: <20221103152204.2706555-1-ferruh.yigit@amd.com> <3277434.9LS3J3VOpE@thomas> <42f937a0-d308-ed59-ba35-fe2124a72d09@amd.com> In-Reply-To: From: Jerin Jacob Date: Mon, 7 Nov 2022 19:52:20 +0530 Message-ID: Subject: Re: [PATCH] event/dlb2: fix meson build To: Ferruh Yigit Cc: Thomas Monjalon , Timothy McDaniel , Kent Wires , dev@dpdk.org, David Marchand , stable@dpdk.org, Luca Boccassi , Bruce Richardson , "Mcnamara, John" , Abdullah Sevincer Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Nov 4, 2022 at 4:30 PM Jerin Jacob wrote: > > On Thu, Nov 3, 2022 at 9:52 PM Ferruh Yigit wrote: > > > > On 11/3/2022 3:35 PM, Thomas Monjalon wrote: > > > 03/11/2022 16:22, Ferruh Yigit: > > >> "meson setup" fails when '-Werror' compiler flag is enabled [1]. > > >> This is not a build error in the driver but a build error in meson > > >> during "meson setup" stage. > > >> > > >> This issue exists for a while but meson takes it as a warning and > > >> ignores it unless '-Werror' compiler flag is provided. > > > [...] > > >> Reproduced via `meson -Dc_args='-Werror' build` > > > > > > Is it different of 'meson --werror" as in devtools/test-meson-builds.sh > > > or 'meson -Dwerror=true' as in .ci/linux-build.sh? > > > > > > > As I checked now, it seems there is a difference. > > > > Via "meson --werror" & "meson -Dwerror=true", > > '-Werror' flag is used to compile dpdk source code, but meson doesn't > > use the flag for its internal logic, so this seems more proper usage. > > > > Via "meson -Dc_args='-Werror'" & "CFLAGS='-Werror' meson" usage, > > '-Werror' flag is used both to compile dpdk code and meson internal > > logic, so that is why this usage cause build error. > > > > > > And independent from the above usage difference, event/dlb2 meson file > > is wrong and this fix is required. > > I assume 'dlb2_avx512.c' compiled because of the '-mavx512vl' fallback > > and that is why mentioned error is not detected. > > + @abdullah.sevincer@intel.com > > Waiting from Ack from Abdullah to merge No reply. Patch looks reasonable to me. Applied to dpdk-next-net-eventdev/for-main. Thanks