From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5ECFCA04DB; Wed, 14 Oct 2020 20:27:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CA8B91DAF3; Wed, 14 Oct 2020 20:27:44 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id CE7851BB9A for ; Wed, 14 Oct 2020 20:27:41 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id k21so167356ioa.9 for ; Wed, 14 Oct 2020 11:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3C0h8BnwSKXpHrc+Q6896YPOvV8KWhvOuSqbrxqn8fU=; b=fUhjb6P+/X8sI1KhtPICZM1LTgdR/ieKaugypL9g5jqWvNb5L9HqgATscKhBLN031k /ymiFWZVIRUzOLHaUelkISxT2wVaPzOgBPnJxo392z/A2VIihBk0cCfqRCQkj2V1r5Lu Y4f/VufDXgeU5DFmjqEB9KXHfnJRd6CcCgAjH9QsufdGLE19q627SraBIGlrfEF23aYT XempZzg6xQ7gzXYB70tFmrRnH6WMtEsr5nBQ6YE+rk6IrW0ZCAN5p02bMzsF3wNXYgd9 WZP3T53NWiTeZ0DH10heTzYaatjj6xlUf3vTXeOEMINwap0iF5ymUFyYgH2jr6ffZyIj XeUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3C0h8BnwSKXpHrc+Q6896YPOvV8KWhvOuSqbrxqn8fU=; b=ZlskPym7PuMcHbGGMFqBG5tn2ARQO+aw8utFEBe1Kdj1km9eDMK7Sfdz6Wv3dVsvWm 4KCw9gn/pGZcdc6AYSZR99CZo21GcLbCCfUlCj9Dj+oeBqy/8pcj1L3rRo5vKy6G6CAO Be3/nuUEIJEvsCokvLhKzoElPn2ZTiP9fHozp8x1rfJ2B+5BduGNYfEKPFS49DlnXAlq 2r6fRX1sIIImSNDOWZydRrGe8W00+EV1F/um3v3NyGpCyfJQdAvbn42dMLedVR91vlT9 ObonU6l/AKytIHMwlzvs6ZtfD3YV5BCphaP9X8H0MzHSM61GClCqTfy6FPDgt7+uAcAL 0JHA== X-Gm-Message-State: AOAM530gSVL2qytNoKfCNuD5IcNtMX3YrMcw/Bl1AINxvZsfYtmQoBSj 7p59QXOw3KC3InVZZKL6GTmdWucMUdyplAdM2BA= X-Google-Smtp-Source: ABdhPJy0VwOMjh6UD1Sklge78oq08Vvav737DcCQDRYvTj4LfpqbzwuCTqLheSKYhUhD2upBYn7vbC/a8x0QsggQA54= X-Received: by 2002:a02:7:: with SMTP id 7mr703281jaa.112.1602700060137; Wed, 14 Oct 2020 11:27:40 -0700 (PDT) MIME-Version: 1.0 References: <20200908105211.10066-1-radu.nicolau@intel.com> <46118f3466274596a663d7d44abb680a@intel.com> <20200925102805.GD923@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: From: Jerin Jacob Date: Wed, 14 Oct 2020 23:57:23 +0530 Message-ID: To: "Ananyev, Konstantin" Cc: "Nicolau, Radu" , "Van Haaren, Harry" , Honnappa Nagarahalli , "Richardson, Bruce" , "dev@dpdk.org" , "jerinj@marvell.com" , nd Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1] event/sw: performance improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 14, 2020 at 3:51 PM Ananyev, Konstantin wrote: > > > > > > > On Wed, Oct 14, 2020 at 2:02 PM Nicolau, Radu wrote: > > > > > > > > > On 10/13/2020 8:11 PM, Jerin Jacob wrote: > > > > On Wed, Oct 7, 2020 at 4:22 PM Ananyev, Konstantin > > > > wrote: > > > >>> On 10/6/2020 11:13 AM, Ananyev, Konstantin wrote: > > > >>>>>> -----Original Message----- > > > >>>>>> From: Jerin Jacob > > > >>>>>> Sent: Monday, October 5, 2020 5:35 PM > > > >>>>>> To: Nicolau, Radu > > > >>>>>> Cc: Honnappa Nagarahalli ; Richardson, Bruce > > > >>>>>> ; Ananyev, Konstantin > > > >>>>>> ; Van Haaren, Harry > > > >>>>>> ; dev@dpdk.org; jerinj@marvell.com; nd > > > >>>>>> > > > >>>>>> Subject: Re: [dpdk-dev] [PATCH v1] event/sw: performance improvements > > > >>>>>> > > > >>>>>> On Tue, Sep 29, 2020 at 2:32 PM Nicolau, Radu wrote: > > > > a concern that another library not uses public ring API, > > > >>>> but instead accesses ring internals directly. Obviously such coding practice is not welcomed > > > >>>> as it makes harder to maintain/extend ring library in future. > > > >>>> About 2) - these new API can(/shoud) be marked an experimental anyway. > > > >>>> As another thing - it is still unclear what a performance gain we are talking about here. > > > >>>> Is it really worth it comparing to just using SP/SC? > > > >>> The change itself came after I analyzed the memory bound sections of the > > > >>> code, and I just did a quick test, I got about 3.5% improvement in > > > >>> throughput, maybe not so much but significant for such a small change, > > > >>> and depending on the usecase it may be more. > > > >>> > > > >>> As for the implementation itself, I would favour having a custom ring > > > >>> like container in the PMD code, this will solve the issue of using > > > >>> rte_ring internals while still allow for full optimisation. If this is > > > >>> acceptable, I will follow up by tomorrow. > > > >> Sounds ok to me. > > > > Nicolau Radu, > > > > > > > > Could you supersede this patch, if the plan is to send it to a new > > > > version based on a custom ring? > > > The v3 (https://patchwork.dpdk.org/patch/79879/) sent last week > > > implements the custom ring and does not use the rte_ring internals. v1 > > > and v2 are superseded. > > > > Ok. Looks good to me. @Honnappa Nagarahalli @Ananyev, Konstantin , > > I will merge this patch if there are no more objections for v3. > > No objections from me. Applied to dpdk-next-eventdev/for-main. Thanks. >