From: Jerin Jacob <jerinjacobk@gmail.com>
To: Liron Himi <lironh@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>,
Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: move PF-func location for egress
Date: Mon, 25 Jan 2021 23:54:06 +0530 [thread overview]
Message-ID: <CALBAE1Mqcmar7EYHvEUV5A983Kn7XpgoY-+dSHX2+svKvsKQFw@mail.gmail.com> (raw)
In-Reply-To: <20210118105031.474-1-lironh@marvell.com>
On Mon, Jan 18, 2021 at 4:20 PM <lironh@marvell.com> wrote:
>
> From: Liron Himi <lironh@marvell.com>
>
> pf-func is 16bit but the current reserved location
> used in tx action is 8bits. moved it to bits 63-48.
>
> Fixes: 32e6aaa97 ("net/octeontx2: support flow parse actions")
> Cc: stable@dpdk.org
>
> Signed-off-by: Liron Himi <lironh@marvell.com>
> Reviewed-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
Applied to dpdk-next-net-mrvl/for-main. Thanks
> ---
> drivers/net/octeontx2/otx2_flow_parse.c | 5 ++++-
> drivers/net/octeontx2/otx2_flow_utils.c | 2 +-
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/octeontx2/otx2_flow_parse.c b/drivers/net/octeontx2/otx2_flow_parse.c
> index 476195d63..e9b940f6c 100644
> --- a/drivers/net/octeontx2/otx2_flow_parse.c
> +++ b/drivers/net/octeontx2/otx2_flow_parse.c
> @@ -1090,7 +1090,10 @@ otx2_flow_parse_actions(struct rte_eth_dev *dev,
>
> set_pf_func:
> /* Ideally AF must ensure that correct pf_func is set */
> - flow->npc_action |= (uint64_t)pf_func << 4;
> + if (attr->egress)
> + flow->npc_action |= (uint64_t)pf_func << 48;
> + else
> + flow->npc_action |= (uint64_t)pf_func << 4;
>
> return 0;
>
> diff --git a/drivers/net/octeontx2/otx2_flow_utils.c b/drivers/net/octeontx2/otx2_flow_utils.c
> index 9a0a5f9fb..7ed86ba74 100644
> --- a/drivers/net/octeontx2/otx2_flow_utils.c
> +++ b/drivers/net/octeontx2/otx2_flow_utils.c
> @@ -944,7 +944,7 @@ otx2_flow_mcam_alloc_and_write(struct rte_flow *flow, struct otx2_mbox *mbox,
> req->entry_data.kw[0] |= flow_info->channel;
> req->entry_data.kw_mask[0] |= (BIT_ULL(12) - 1);
> } else {
> - uint16_t pf_func = (flow->npc_action >> 4) & 0xffff;
> + uint16_t pf_func = (flow->npc_action >> 48) & 0xffff;
>
> pf_func = htons(pf_func);
> req->entry_data.kw[0] |= ((uint64_t)pf_func << 32);
> --
> 2.28.0
>
prev parent reply other threads:[~2021-01-25 18:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 10:50 lironh
2021-01-25 18:24 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1Mqcmar7EYHvEUV5A983Kn7XpgoY-+dSHX2+svKvsKQFw@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=lironh@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).