From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 330DE4297B; Tue, 18 Apr 2023 10:34:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B464940EDF; Tue, 18 Apr 2023 10:34:08 +0200 (CEST) Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com [209.85.222.42]) by mails.dpdk.org (Postfix) with ESMTP id 5CCEA40698; Tue, 18 Apr 2023 10:34:07 +0200 (CEST) Received: by mail-ua1-f42.google.com with SMTP id r10so10483108uat.6; Tue, 18 Apr 2023 01:34:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681806846; x=1684398846; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ItVRJONiza5n4x/dXyn1fifVnuJYLleQEiH+KmnWTPA=; b=FmoubW+loyJLBYm2wY00rV4cqBL9F5y9ntUoeE9depBCB09d3esqQIrRt41RWqKH2+ EYhkd8G/E7rg9XN2AfTab6aMJR4DB1etmwwHzdj1kRXOIN7gUweKHIRYokWsdU9IW5BC 2AT6S9BGdFbDwHL29vIryiQe9RXxcvRHv5/aKkpVn19orqOK6mkXVNzetqI3+6PEYkSE q5yjnRzKHw+sHWyOs/uluFi/82VgfqI62SYByJVhoDmsIrt/01f0XL4Z5Cca8+92WA8q Kt0EYWTbURaiYCfJ1ru4ibDjlifPuIbSWjPVO7wVnpuSJvwqIieRD57PS7gV4ctt7pfH f1Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681806846; x=1684398846; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ItVRJONiza5n4x/dXyn1fifVnuJYLleQEiH+KmnWTPA=; b=kOERHm/nN/wk75mQopFWGuM3eClWwLzQlbEGnmbVftKfcUk5fFfJLpeW6KM5vPt9xv egdP0elFLy+vR33wPsE/K5tir4jgc/EueO48OiVJqCAG8Xr2WBoqWrAuNrsU23wKji9W pKBu06nOD5ccQDYEU5gH9UXiFHifUDhdZ6v8Bctp4cnNO2SqRx1hAdVTfdNMoi+ftzYh vPx7kvTaYKyeKH0CEGxfrF60V62tVijo+3zDkuAdH83Eyc2bEceWetJm7zXSY26iTc92 RBO0idBcpOxONBSRxFRXFoFv1dc7ciUBIRL2QLoChoogPbk1ZG9h1t7QjXNEiQ7WMiBy 519Q== X-Gm-Message-State: AAQBX9fbVPO2kLxFfrThnU25uy4tPdJwCB9SvJzuudpNK5WzkUhSR/M6 MbScQjv7fUy8VvITtvMYEz5COpC6EQKG5yxwt9o= X-Google-Smtp-Source: AKy350aeOPaF2G4t0fk+dSEXOdWqXLMU+AsZahMivjGPSAhhK9G+5xTlCit+vQ0C6jSqsccqNvsTLBa5w8veIH9QrCk= X-Received: by 2002:a1f:d685:0:b0:443:d39d:77d7 with SMTP id n127-20020a1fd685000000b00443d39d77d7mr133619vkg.13.1681806846696; Tue, 18 Apr 2023 01:34:06 -0700 (PDT) MIME-Version: 1.0 References: <20230309085645.1630826-1-ndabilpuram@marvell.com> <20230411100410.1174495-1-ndabilpuram@marvell.com> <20230411110553.25f7c038@hermes.local> In-Reply-To: <20230411110553.25f7c038@hermes.local> From: Jerin Jacob Date: Tue, 18 Apr 2023 14:03:40 +0530 Message-ID: Subject: Re: [PATCH 1/3] security: introduce out of place support for inline ingress To: Stephen Hemminger Cc: Nithin Dabilpuram , Thomas Monjalon , Akhil Goyal , jerinj@marvell.com, dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , techboard@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Apr 11, 2023 at 11:36=E2=80=AFPM Stephen Hemminger wrote: > > On Tue, 11 Apr 2023 15:34:07 +0530 > Nithin Dabilpuram wrote: > > > diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h > > index 4bacf9fcd9..866cd4e8ee 100644 > > --- a/lib/security/rte_security.h > > +++ b/lib/security/rte_security.h > > @@ -275,6 +275,17 @@ struct rte_security_ipsec_sa_options { > > */ > > uint32_t ip_reassembly_en : 1; > > > > + /** Enable out of place processing on inline inbound packets. > > + * > > + * * 1: Enable driver to perform Out-of-place(OOP) processing for= this inline > > + * inbound SA if supported by driver. PMD need to register m= buf > > + * dynamic field using rte_security_oop_dynfield_register() > > + * and security session creation would fail if dynfield is n= ot > > + * registered successfully. > > + * * 0: Disable OOP processing for this session (default). > > + */ > > + uint32_t ingress_oop : 1; > > + > > /** Reserved bit fields for future extension > > * > > * User should ensure reserved_opts is cleared as it may change i= n > > @@ -282,7 +293,7 @@ struct rte_security_ipsec_sa_options { > > * > > * Note: Reduce number of bits in reserved_opts for every new opt= ion. > > */ > > - uint32_t reserved_opts : 17; > > + uint32_t reserved_opts : 16; > > }; > > NAK > Let me repeat the reserved bit rant. YAGNI > > Reserved space is not usable without ABI breakage unless the existing > code enforces that reserved space has to be zero. > > Just saying "User should ensure reserved_opts is cleared" is not enough. Yes. I think, we need to enforce to have _init functions for the structures which is using reserved filed. On the same note on YAGNI, I am wondering why NOT introduce RTE_NEXT_ABI marco kind of scheme to compile out ABI breaking changes. By keeping RTE_NEXT_ABI disable by default, enable explicitly if user wants it to avoid waiting for one year any ABI breaking changes. There are a lot of "fixed appliance" customers (not OS distribution driven customer) they are willing to recompile DPDK for new feature. What we are loosing with this scheme? > >