From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7184A00BE; Mon, 27 Apr 2020 18:29:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C05F1D514; Mon, 27 Apr 2020 18:29:28 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 8ED661D513 for ; Mon, 27 Apr 2020 18:29:26 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id y26so9628255ioj.2 for ; Mon, 27 Apr 2020 09:29:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=arELxIaVf1uYAIpcvI8FT5duYd4OI3qLi2lShgefLYI=; b=i2ZGZiuL9v5sXNknfJ19YDumjJJoHa/rDxTBoRtLMr6UF/1fAG+TVF3HKumMdDA5Ie k0KM8VoYD6QAkrcwUUIs57sC4wsqt1MzWyKBOub8yNUlejxYsRlftHlJEUCW5eoBcEs1 vBjmF5PLmbBFxRNMt4JQ11oCy+zK+IjJyrlWxb9H1zAF6V53G/QRbfyUOj6cqD873Hw5 tWHfV3FiKJ86Wo0wdrXw54dymgTriNzcvuwkYGtPIReCjOGGSCkUH9aOQl6ApacI59+f 7ay81voj5woWCStnCSzHAHGm63m3U0I/7Jb8Kj6YSXm7Uo55783x4Gflh7Ue8QCt0ROj 9xkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=arELxIaVf1uYAIpcvI8FT5duYd4OI3qLi2lShgefLYI=; b=Vxmp+Gyq4ry8f4He1IiW8BGQ6uI9SMboB+iML2mHPOAfgoeVzZ9KxPRlIdEwC4m8/g dTskML1enJCKqoSMEoAaocIPAU3+f579TaFM7ZTUITIyMFb3x4Zlwejjj5EkV0P/PS58 D9vbhpvCqJ2YzDpl15zes+6HH5IT3QwVk8bV7BpoYmTEKG7q07Gwz4Xw+xWpGVeVHCsU gECMGt849SPjKCEFMJaVxUNjh65j/8umUb9wK9RGZZNklQ9l5r84dF9OTCUqX+YDFAR2 gDgrSD+Fi1ihZXhy9NkJpQbrVHz2TzrWuecTu5Iuba8aaJtX6DkdX7SkN8Zlv1BV6jxb VSkQ== X-Gm-Message-State: AGi0PuZVy+vPQTm/6P0KwryJ/ZVJsP21fsbRbUcxgAeX3kMRp+FtXrrQ cscJ33jd5zREnPs7iO+CKlsVMhtWqM6h1iY0XE4= X-Google-Smtp-Source: APiQypJQOu27nWLQkeCPPwMxDdr1uOnFbqG57iaNzRaI+hISMWx+AK4k4sqcLb6CFN+UvbySasHeZrqJha5RlMEUKyw= X-Received: by 2002:a05:6638:5ad:: with SMTP id b13mr20676605jar.113.1588004965690; Mon, 27 Apr 2020 09:29:25 -0700 (PDT) MIME-Version: 1.0 References: <20200330160019.29674-1-ndabilpuram@marvell.com> <20200422172104.23099-1-nithind1988@gmail.com> In-Reply-To: From: Jerin Jacob Date: Mon, 27 Apr 2020 21:59:09 +0530 Message-ID: To: Ferruh Yigit Cc: "Dumitrescu, Cristian" , Nithin Dabilpuram , "Singh, Jasvinder" , Thomas Monjalon , Andrew Rybchenko , "dev@dpdk.org" , "jerinj@marvell.com" , "kkanas@marvell.com" , Nithin Dabilpuram , "Kinsella, Ray" , Neil Horman , Luca Boccassi , Kevin Traynor , David Marchand , Bruce Richardson Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 27, 2020 at 9:42 PM Ferruh Yigit wrote: > > On 4/27/2020 10:19 AM, Dumitrescu, Cristian wrote: > > > > > >> -----Original Message----- > >> From: Yigit, Ferruh > >> Sent: Saturday, April 25, 2020 9:09 PM > >> To: Dumitrescu, Cristian ; Nithin Dabilpuram > >> ; Singh, Jasvinder ; > >> Thomas Monjalon ; Andrew Rybchenko > >> > >> Cc: dev@dpdk.org; jerinj@marvell.com; kkanas@marvell.com; Nithin > >> Dabilpuram > >> Subject: Re: [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt > >> mode > >> > >> On 4/24/2020 11:28 AM, Dumitrescu, Cristian wrote: > >>> > >>> > >>>> -----Original Message----- > >>>> From: Nithin Dabilpuram > >>>> Sent: Wednesday, April 22, 2020 6:21 PM > >>>> To: Singh, Jasvinder ; Dumitrescu, Cristian > >>>> ; Thomas Monjalon > >>>> ; Yigit, Ferruh ; Andrew > >>>> Rybchenko > >>>> Cc: dev@dpdk.org; jerinj@marvell.com; kkanas@marvell.com; Nithin > >>>> Dabilpuram > >>>> Subject: [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt > >>>> mode > >>>> > >>>> From: Nithin Dabilpuram > >>>> > >>>> Some NIC hardware support shaper to work in packet mode i.e > >>>> shaping or ratelimiting traffic is in packets per second (PPS) as > >>>> opposed to default bytes per second (BPS). Hence this patch > >>>> adds support to configure shared or private shaper in packet mode, > >>>> provide rate in PPS and add related tm capabilities in port/level/node > >>>> capability structures. > >>>> > >>>> This patch also updates tm port/level/node capability structures with > >>>> exiting features of scheduler wfq packet mode, scheduler wfq byte mode > >>>> and private/shared shaper byte mode. > >>>> > >>>> SoftNIC PMD is also updated with new capabilities. > >>>> > >>>> Signed-off-by: Nithin Dabilpuram > >>>> --- > >>>> v3..v4: > >>>> - Update text under packet_mode as per Cristian. > >>>> - Update rte_eth_softnic_tm.c based on Jasvinder's comments. > >>>> - Add error enum > >> RTE_TM_ERROR_TYPE_SHAPER_PROFILE_PACKET_MODE > >>>> - Fix shaper_profile_check() with packet mode check > >>>> - Fix typo's > >>>> > >>> > >>> Acked-by: Cristian Dumitrescu > >>> > >> > >> Hi Nithin, > >> > >> It looks like patch is causing ABI break, I am getting following warning [1], > >> can you please check? > >> > >> [1] > >> https://pastebin.com/XYNFg14u > > > > > > Hi Ferruh, > > > > The RTE_TM API is marked as experimental, but it looks that this was not correctly marked when __rte_experimental ABI checker was introduced. > > > > It is marked as experimental at the top of the rte_tm.h, similarly to other APIs introduced around same time, but it was not correctly picked up by the ABI check procedure when later introduced, so __rte_experimental was not added to every function. > > > > :( > > Is it time to mature them? > > As you said they are not marked as experimental both in header file (function > declarations) and .map file. > > The problem is, they are not marked as experimental in DPDK_20.0 ABI (v19.11), > so marking them as experimental now will break the ABI. Not sure what to do, > cc'ed a few ABI related names for comment. > > For me, we need to proceed as the experimental tag removed and APIs become > mature starting from v19.11, since this is what happened in practice, and remove > a few existing being experimental references in the doxygen comments. I think, accidentally we can not make a library as NON-experimental. TM never went through experimental to mature transition(see git log lib/librte_ethdev/rte_tm.h) It was a bug to not mark as experimental in each function in the ABI process. Some of the features like packet marking are not even implemented by any HW. I think, we can make API stable only all the features are implemented by one or two HW. > > Ray, Neil, David, Luca, Kevin, what do you think?