* [PATCH] net/cnxk: add RSS config via ethdev configure API
@ 2024-04-10 13:11 skori
2024-05-23 14:13 ` Jerin Jacob
2024-05-23 14:53 ` [PATCH v2 1/1] net/cnxk: fix " skori
0 siblings, 2 replies; 4+ messages in thread
From: skori @ 2024-04-10 13:11 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao,
Harman Kalra
Cc: dev
From: Sunil Kumar Kori <skori@marvell.com>
Currently user passed RSS configuration is ignored via
rte_eth_dev_configure() API. Instead default RSS setup is done by
driver.
Adding handling for user passed RSS configuration too via
rte_eth_dev_configure().
Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
drivers/net/cnxk/cnxk_ethdev.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c
index 6b37bd877f..95a3d8aaf9 100644
--- a/drivers/net/cnxk/cnxk_ethdev.c
+++ b/drivers/net/cnxk/cnxk_ethdev.c
@@ -1384,6 +1384,13 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev)
goto free_nix_lf;
}
+ /* Overwrite default RSS setup if requested by user */
+ rc = cnxk_nix_rss_hash_update(eth_dev, &conf->rx_adv_conf.rss_conf);
+ if (rc) {
+ plt_err("Failed to configure rss rc=%d", rc);
+ goto free_nix_lf;
+ }
+
/* Init the default TM scheduler hierarchy */
rc = roc_nix_tm_init(nix);
if (rc) {
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/cnxk: add RSS config via ethdev configure API
2024-04-10 13:11 [PATCH] net/cnxk: add RSS config via ethdev configure API skori
@ 2024-05-23 14:13 ` Jerin Jacob
2024-05-23 14:53 ` [PATCH v2 1/1] net/cnxk: fix " skori
1 sibling, 0 replies; 4+ messages in thread
From: Jerin Jacob @ 2024-05-23 14:13 UTC (permalink / raw)
To: skori; +Cc: Nithin Dabilpuram, Kiran Kumar K, Satha Rao, Harman Kalra, dev
On Wed, Apr 10, 2024 at 6:41 PM <skori@marvell.com> wrote:
>
> From: Sunil Kumar Kori <skori@marvell.com>
>
> Currently user passed RSS configuration is ignored via
> rte_eth_dev_configure() API. Instead default RSS setup is done by
> driver.
Rewrite the git commit as fix and add Fixes: tag
>
> Adding handling for user passed RSS configuration too via
> rte_eth_dev_configure().
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
> drivers/net/cnxk/cnxk_ethdev.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c
> index 6b37bd877f..95a3d8aaf9 100644
> --- a/drivers/net/cnxk/cnxk_ethdev.c
> +++ b/drivers/net/cnxk/cnxk_ethdev.c
> @@ -1384,6 +1384,13 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev)
> goto free_nix_lf;
> }
>
> + /* Overwrite default RSS setup if requested by user */
> + rc = cnxk_nix_rss_hash_update(eth_dev, &conf->rx_adv_conf.rss_conf);
> + if (rc) {
> + plt_err("Failed to configure rss rc=%d", rc);
> + goto free_nix_lf;
> + }
> +
> /* Init the default TM scheduler hierarchy */
> rc = roc_nix_tm_init(nix);
> if (rc) {
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/1] net/cnxk: fix RSS config via ethdev configure API
2024-04-10 13:11 [PATCH] net/cnxk: add RSS config via ethdev configure API skori
2024-05-23 14:13 ` Jerin Jacob
@ 2024-05-23 14:53 ` skori
2024-05-24 13:40 ` Jerin Jacob
1 sibling, 1 reply; 4+ messages in thread
From: skori @ 2024-05-23 14:53 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao,
Harman Kalra
Cc: dev, stable
From: Sunil Kumar Kori <skori@marvell.com>
Currently user passed RSS configuration is ignored via
rte_eth_dev_configure() API. Instead default RSS setup is done by
driver.
Adding handling for user passed RSS configuration too via
rte_eth_dev_configure().
Fixes: b75e0aca84b0 ("net/cnxk: add device configuration operation")
Cc: stable@dpdk.org
Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
v1..v2:
- added Fixes tag.
drivers/net/cnxk/cnxk_ethdev.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c
index 6b37bd877f..95a3d8aaf9 100644
--- a/drivers/net/cnxk/cnxk_ethdev.c
+++ b/drivers/net/cnxk/cnxk_ethdev.c
@@ -1384,6 +1384,13 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev)
goto free_nix_lf;
}
+ /* Overwrite default RSS setup if requested by user */
+ rc = cnxk_nix_rss_hash_update(eth_dev, &conf->rx_adv_conf.rss_conf);
+ if (rc) {
+ plt_err("Failed to configure rss rc=%d", rc);
+ goto free_nix_lf;
+ }
+
/* Init the default TM scheduler hierarchy */
rc = roc_nix_tm_init(nix);
if (rc) {
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] net/cnxk: fix RSS config via ethdev configure API
2024-05-23 14:53 ` [PATCH v2 1/1] net/cnxk: fix " skori
@ 2024-05-24 13:40 ` Jerin Jacob
0 siblings, 0 replies; 4+ messages in thread
From: Jerin Jacob @ 2024-05-24 13:40 UTC (permalink / raw)
To: skori
Cc: Nithin Dabilpuram, Kiran Kumar K, Satha Rao, Harman Kalra, dev, stable
On Thu, May 23, 2024 at 8:23 PM <skori@marvell.com> wrote:
>
> From: Sunil Kumar Kori <skori@marvell.com>
>
> Currently user passed RSS configuration is ignored via
> rte_eth_dev_configure() API. Instead default RSS setup is done by
> driver.
>
> Adding handling for user passed RSS configuration too via
> rte_eth_dev_configure().
>
> Fixes: b75e0aca84b0 ("net/cnxk: add device configuration operation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
> v1..v2:
> - added Fixes tag.
Applied to dpdk-next-net-mrvl/for-main. Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-24 13:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-10 13:11 [PATCH] net/cnxk: add RSS config via ethdev configure API skori
2024-05-23 14:13 ` Jerin Jacob
2024-05-23 14:53 ` [PATCH v2 1/1] net/cnxk: fix " skori
2024-05-24 13:40 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).