Re: [PATCH 1/1] common/cnxk: fix static assertion failure

[Jerin Jacob <jerinjacobk@gmail.com>]

On Wed, Mar 2, 2022 at 5:37 PM Vamsi Attunuru <vattunuru@marvell.com> wrote:
>
> use dynamically allocated memory for storing soft expiry

Use

> ring base addresses which fixes the static assertion failure,
> size of this dynamic allocation depends on RTE_MAX_ETHPORTS

as the size of

> which varies based on the build config.
>

Fill Bugzilla ID:

> Fixes: d26185716d3f ("net/cnxk: support outbound soft expiry
> notification")

Please move word "notification" to same line.

Add Cc: stable@dpdk.org

+ @yux.jiang@intel.com

Add Reported-by:


>
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> ---
> +
> +/* Add / Sub pointer with scalar and cast to uint64_t */
> +#define PLT_PTR_ADD_U64_CAST(__ptr, __x) PLT_U64_CAST(PLT_PTR_ADD(__ptr, __x))
> +#define PLT_PTR_SUB_U64_CAST(__ptr, __x) PLT_U64_CAST(PLT_PTR_SUB(__ptr, __x))

Since it is not used in this patch, This line can be removed

> +
>  /** Divide ceil */
>  #define PLT_DIV_CEIL(x, y)                     \
>         ({                                      \
> @@ -158,6 +170,10 @@
>  #define plt_write64(val, addr)                                                 \
>         rte_write64_relaxed((val), (volatile void *)(addr))
>
> +#define plt_read32(addr) rte_read32_relaxed((volatile void *)(addr))
> +#define plt_write32(val, addr)                                                 \
> +       rte_write32_relaxed((val), (volatile void *)(addr))

Since it is not used in this patch, This line can be removed