From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22B5EA04A4; Wed, 2 Mar 2022 13:47:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA73742715; Wed, 2 Mar 2022 13:47:01 +0100 (CET) Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by mails.dpdk.org (Postfix) with ESMTP id 7B46440141 for ; Wed, 2 Mar 2022 13:47:00 +0100 (CET) Received: by mail-il1-f181.google.com with SMTP id v5so1280312ilm.9 for ; Wed, 02 Mar 2022 04:47:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xcTUaR4dg+grIzJs9WBVN4LNcOBPTxNdxoj6KwtJMk8=; b=IFQry8ZTUrQ0bbby3GL47aZcJbRlGtGuQOKbu3ielIG6dRgwkc2onzwHxXwEV7K1mG uRxbMvokOmoTeI99exvRnTFpjmtbNZCbSZ2odZK+RIGwnebJqeEG6mBiAY+D8qWn81pC qfhbNtXh9vicg+Tq/83WldXK0AYIcTKh616qHBRf1bxr/lxPmP/JLwKSJ/IwU+jvd4uH cezrbqKG3kNEK2L7zva97R55wN9Z2aIn8xwyYq/AkyWy3gOuLyvoTtnYF3IfxIOI9JKe +0RA/d4diedGIO7XVWYBxmxMjtLQjBOCaqLZHLRvMfQNQNtOTBR1viGE9UA51Vll4cXv GJLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xcTUaR4dg+grIzJs9WBVN4LNcOBPTxNdxoj6KwtJMk8=; b=d528wYyr3Tq3eyiKqhLy0dZy6gId5GYHKNmQz1e00UTkEtx447/4UGYB6Cif2Rk0is v3jC4sW8mi3g65MQ6pBk989UiG0F01ZEB8F23FJbMIh9PVVpspnQysCwySMj6OS4XU0o 1671D00wpw279agVxbkBJjUu6Z9UpuFNPja0WTIOUf/ZJTt7VQYT1FcupKB6+I5Zd6OS 3JrTM1pSMkFth5m3007TLbu9Abn45IDIlRSyaFkUeXBEkj06dYE+SztShkfDNftSsi0M hKDCi+tbcloGL/oPfzBXuv12z5Yn54nbOhXQoOCNUNwmzybhTO2Xyy++iJdOVqraYKwH GPMw== X-Gm-Message-State: AOAM5332UUGPfO68JAW/74Euar3xBgQDK9c0tGet7YCed6u/S/jw+FOC Yz0xDcOMCAHfzxGh/rMfWAccHAF+9pUCxrfK/pg= X-Google-Smtp-Source: ABdhPJyDoSNhiBIrbw/g90IskVcyvFmlB0y1IWCw25zaWRsdJQBrWXEtnUIGrwNWC9AFhQ1BRX86Kb+bsx45xKwiQpE= X-Received: by 2002:a05:6e02:1584:b0:2b9:7a3d:8937 with SMTP id m4-20020a056e02158400b002b97a3d8937mr27570772ilu.192.1646225219776; Wed, 02 Mar 2022 04:46:59 -0800 (PST) MIME-Version: 1.0 References: <20220302120701.2749772-1-vattunuru@marvell.com> In-Reply-To: <20220302120701.2749772-1-vattunuru@marvell.com> From: Jerin Jacob Date: Wed, 2 Mar 2022 18:16:33 +0530 Message-ID: Subject: Re: [PATCH 1/1] common/cnxk: fix static assertion failure To: Vamsi Attunuru , YuX Cc: dpdk-dev , Jerin Jacob , Nithin Dabilpuram , Srikanth Yalavarthi Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 2, 2022 at 5:37 PM Vamsi Attunuru wrote: > > use dynamically allocated memory for storing soft expiry Use > ring base addresses which fixes the static assertion failure, > size of this dynamic allocation depends on RTE_MAX_ETHPORTS as the size of > which varies based on the build config. > Fill Bugzilla ID: > Fixes: d26185716d3f ("net/cnxk: support outbound soft expiry > notification") Please move word "notification" to same line. Add Cc: stable@dpdk.org + @yux.jiang@intel.com Add Reported-by: > > Signed-off-by: Vamsi Attunuru > Signed-off-by: Srikanth Yalavarthi > --- > + > +/* Add / Sub pointer with scalar and cast to uint64_t */ > +#define PLT_PTR_ADD_U64_CAST(__ptr, __x) PLT_U64_CAST(PLT_PTR_ADD(__ptr, __x)) > +#define PLT_PTR_SUB_U64_CAST(__ptr, __x) PLT_U64_CAST(PLT_PTR_SUB(__ptr, __x)) Since it is not used in this patch, This line can be removed > + > /** Divide ceil */ > #define PLT_DIV_CEIL(x, y) \ > ({ \ > @@ -158,6 +170,10 @@ > #define plt_write64(val, addr) \ > rte_write64_relaxed((val), (volatile void *)(addr)) > > +#define plt_read32(addr) rte_read32_relaxed((volatile void *)(addr)) > +#define plt_write32(val, addr) \ > + rte_write32_relaxed((val), (volatile void *)(addr)) Since it is not used in this patch, This line can be removed