From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92518A034E; Tue, 22 Feb 2022 10:51:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F81B40E64; Tue, 22 Feb 2022 10:51:47 +0100 (CET) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by mails.dpdk.org (Postfix) with ESMTP id A4FFC40DF4 for ; Tue, 22 Feb 2022 10:51:46 +0100 (CET) Received: by mail-io1-f53.google.com with SMTP id h16so19327812iol.11 for ; Tue, 22 Feb 2022 01:51:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=puwianEF/BUlPgP5JIgHQO06jumWLqsRVVIPZ+VOz3Y=; b=PJog0/K86ectL63/46TKTAlHvUaTEwKUeSfQRM8W9v5C0eqeHqrPuGjOCRVNtZ8Pd1 ToQVpTcRXuWrnsICUIXZLYUoWX79bXzQ27coVUsqLeqF0jhLMmGO0aj24ZfS3u02fpnO HAx9TH+p7ox3hIT0iBjz1XrfOdP/n1guDFjr150JmWGJk5NXhfvbHFLEBq3za9FzHIj7 C4+L0UVJlX8jEXTEOFCgFF+DxiXOAGpEifVqgyQpthJnq3o+z4ICo2buwQQlfejJu4sD NIgFK6u+HADAjqE3cYWnnepyHciDxcCYIpnCT2+ZRqwlvrxaik6UawLekdrsZFQvTRvV pTgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=puwianEF/BUlPgP5JIgHQO06jumWLqsRVVIPZ+VOz3Y=; b=7gsjpVQf5vGz5dyjoYwyqMrceFx4VLqNFhZcgFw1h++dkRTLGw0iP3y+V2FJIlfcYL HBqnbIZLvwNlyyxZHkyXZiJBU/hniKu9ZxiqskybChE9VF0ks51w3RjsIBv6DTmflhAr k+iuHfTEE7PDPme/UX6k+ps8S8bpyYyPpJsguhFDRk4+gkq41L+U32iOHEaJLSgc2O6S 05onwkAzUhlrv8/RDwMhoWIHNXB6vkSH6JfDmuRmmQ57j+gCym4gT+DDuFTgH7SiQOjQ cygI3hwGK5pN9SJ/n53mKKEuon9FuG3GNy5JQ3L2dyTmIXtWuUvsLQoiwlWYLL4/aBMd O10Q== X-Gm-Message-State: AOAM531ryoYDQ1vZ2/nJszjYqY34KZiMgNB5tUF7KBM0RF1C9YrBxZ9+ AWwybquyjLvtiwEnS4xjhAdf2c01+4Ol+KA3618= X-Google-Smtp-Source: ABdhPJxuGqo6o76lrw4CDVnzSTrO1mUXzoFGVw2dwnjVmt8mO8Yiw3EaYVZpphS+a6S5S1MPp+B1/1qs+Y1X4lB5ppU= X-Received: by 2002:a05:6638:584:b0:311:9d1c:64b with SMTP id a4-20020a056638058400b003119d1c064bmr19228580jar.158.1645523506054; Tue, 22 Feb 2022 01:51:46 -0800 (PST) MIME-Version: 1.0 References: <20220219121338.2438-1-pbhagavatula@marvell.com> In-Reply-To: <20220219121338.2438-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Tue, 22 Feb 2022 15:21:20 +0530 Message-ID: Subject: Re: [PATCH 1/2] event/cnxk: remove deschedule usage in CN9K To: Pavan Nikhilesh Cc: Jerin Jacob , Shijith Thotton , dpdk-dev Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Feb 19, 2022 at 6:05 PM wrote: > > From: Pavan Nikhilesh > > Using deschedule cmd might incorrectly ignore updates to WQE, GGRP > on CN9K. > Use addwork to pipeline work instead. > > Signed-off-by: Pavan Nikhilesh Series applied to dpdk-next-net-eventdev/for-main. Thanks > --- > drivers/event/cnxk/cn9k_worker.h | 41 +++++++++++++++++++++++++------- > 1 file changed, 32 insertions(+), 9 deletions(-) > > diff --git a/drivers/event/cnxk/cn9k_worker.h b/drivers/event/cnxk/cn9k_worker.h > index 79374b8d95..0905d744cc 100644 > --- a/drivers/event/cnxk/cn9k_worker.h > +++ b/drivers/event/cnxk/cn9k_worker.h > @@ -63,15 +63,18 @@ cn9k_sso_hws_fwd_swtag(uint64_t base, const struct rte_event *ev) > } > > static __rte_always_inline void > -cn9k_sso_hws_fwd_group(uint64_t base, const struct rte_event *ev, > - const uint16_t grp) > +cn9k_sso_hws_new_event_wait(struct cn9k_sso_hws *ws, const struct rte_event *ev) > { > const uint32_t tag = (uint32_t)ev->event; > const uint8_t new_tt = ev->sched_type; > + const uint64_t event_ptr = ev->u64; > + const uint16_t grp = ev->queue_id; > > - plt_write64(ev->u64, base + SSOW_LF_GWS_OP_UPD_WQP_GRP1); > - cnxk_sso_hws_swtag_desched(tag, new_tt, grp, > - base + SSOW_LF_GWS_OP_SWTAG_DESCHED); > + while (ws->xaq_lmt <= __atomic_load_n(ws->fc_mem, __ATOMIC_RELAXED)) > + ; > + > + cnxk_sso_hws_add_work(event_ptr, tag, new_tt, > + ws->grp_base + (grp << 12)); > } > > static __rte_always_inline void > @@ -86,10 +89,12 @@ cn9k_sso_hws_forward_event(struct cn9k_sso_hws *ws, const struct rte_event *ev) > } else { > /* > * Group has been changed for group based work pipelining, > - * Use deschedule/add_work operation to transfer the event to > + * Use add_work operation to transfer the event to > * new group/core > */ > - cn9k_sso_hws_fwd_group(ws->base, ev, grp); > + rte_atomic_thread_fence(__ATOMIC_RELEASE); > + roc_sso_hws_head_wait(ws->base); > + cn9k_sso_hws_new_event_wait(ws, ev); > } > } > > @@ -113,6 +118,22 @@ cn9k_sso_hws_dual_new_event(struct cn9k_sso_hws_dual *dws, > return 1; > } > > +static __rte_always_inline void > +cn9k_sso_hws_dual_new_event_wait(struct cn9k_sso_hws_dual *dws, > + const struct rte_event *ev) > +{ > + const uint32_t tag = (uint32_t)ev->event; > + const uint8_t new_tt = ev->sched_type; > + const uint64_t event_ptr = ev->u64; > + const uint16_t grp = ev->queue_id; > + > + while (dws->xaq_lmt <= __atomic_load_n(dws->fc_mem, __ATOMIC_RELAXED)) > + ; > + > + cnxk_sso_hws_add_work(event_ptr, tag, new_tt, > + dws->grp_base + (grp << 12)); > +} > + > static __rte_always_inline void > cn9k_sso_hws_dual_forward_event(struct cn9k_sso_hws_dual *dws, uint64_t base, > const struct rte_event *ev) > @@ -126,10 +147,12 @@ cn9k_sso_hws_dual_forward_event(struct cn9k_sso_hws_dual *dws, uint64_t base, > } else { > /* > * Group has been changed for group based work pipelining, > - * Use deschedule/add_work operation to transfer the event to > + * Use add_work operation to transfer the event to > * new group/core > */ > - cn9k_sso_hws_fwd_group(base, ev, grp); > + rte_atomic_thread_fence(__ATOMIC_RELEASE); > + roc_sso_hws_head_wait(base); > + cn9k_sso_hws_dual_new_event_wait(dws, ev); > } > } > > -- > 2.17.1 >