From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30B11A04AF; Mon, 4 May 2020 04:47:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F7DF1D14A; Mon, 4 May 2020 04:47:11 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 607411C440 for ; Mon, 4 May 2020 04:47:10 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id k6so10796522iob.3 for ; Sun, 03 May 2020 19:47:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OoVgUw2z5vi4OywYTcB2kfQGFJXCss5arfptwBsSw80=; b=buEB3jSU2rQpT7sLjg/EuSsxuQVNsJz/yScmVFnfdC8y7OotON5gwjbCFTrA/R/gKT PZriLQe1dNylXULQrWDmIElOkkYHfNkOd4K7kiBZmAzxNkng1Nsnv+Pdfu/NxusebYgv EYT6ymMNz/fY7AeCTp9qTfhyZ3QaW43vD3Qqb6I7yQxgYbBDxKI8DjolEQctlMnkNuxr YbzzwWPO2bF5GIppo1KNsmYwerf18lHMiG7QQpb70h0w/EtPoHx8b1NYoygsLrt3YL9E 8GNkHKmLwfp9RKLYLpuDzVZsgoLvtysg3l8cFCROihx1ttWCs+/cUPectk1JGR5JF11z D7aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OoVgUw2z5vi4OywYTcB2kfQGFJXCss5arfptwBsSw80=; b=iIpYNtkherp3MgII1AfjF/NFi6Af1LXP+MASH3aOXnoycOC9O5hjB9taDrRFJg7uUT iQLBkbc8LDqOdKEee9NYnVbcKXdVw2ui5w2z1l3S6apii+cDhqJrO8n4kkhiC6MVpnSE Za48S25H9wP0Rf/nRpbsRRKGHAPn/RgbHaJ/fAO/DnKq8aRPVYWCelrccmhdJwtoWS4G vwz4Bj6nCzIOIGZKKuczJY9eKJYM6+49kyybxBTXOUn2ZzZ+3t+ar7M4DM4eXBfTbdLb c7ZmAJA0SwakfCVMqhz1NtaicHuJsN+SpNywHH5UgEXXr7rOQ2yR1nwOjd3rlmYt+AsJ kPrg== X-Gm-Message-State: AGi0PuY3cX2O9RHOW0S9dz+2MxIdQQ3EiP2zd+2dM/rRusGk0kmDsEIe Vrsm+hnw29fnYEhlDnYuTP22d17eaAnE5QIyPKU= X-Google-Smtp-Source: APiQypLALwkldx7MaNhgxiSMEtoACIwwp5eMYCC9p/W3cBr/tlVgeGQGV2LNjm/OgKvaGJZj5CrmC6iiK9KQQgs5sHY= X-Received: by 2002:a05:6602:2e0b:: with SMTP id o11mr13129092iow.94.1588560429608; Sun, 03 May 2020 19:47:09 -0700 (PDT) MIME-Version: 1.0 References: <20200503203135.6493-1-david.marchand@redhat.com> <20200503203135.6493-3-david.marchand@redhat.com> In-Reply-To: <20200503203135.6493-3-david.marchand@redhat.com> From: Jerin Jacob Date: Mon, 4 May 2020 08:16:53 +0530 Message-ID: To: David Marchand Cc: dpdk-dev , Thomas Monjalon , Jerin Jacob , Sunil Kumar Kori , John McNamara , Marko Kovacevic , Declan Doherty , Ferruh Yigit , Andrew Rybchenko , Olivier Matz Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 4, 2020 at 2:02 AM David Marchand wrote: > > RTE_TRACE_POINT_DEFINE and RTE_TRACE_POINT_REGISTER must come in pairs. > Merge them and let RTE_TRACE_POINT_REGISTER handle the constructor part. Initially, I thought of doing the same. But, later I realized that this largely grows the number of constructors been called. I had concerns about the boot time of the application and/or loading the shared library, that the reason why spitting as two so that constructor registers a burst of traces like rte_log. > > Signed-off-by: David Marchand > --- > app/test/test_trace_register.c | 12 +- > doc/guides/prog_guide/trace_lib.rst | 12 +- > lib/librte_cryptodev/cryptodev_trace_points.c | 84 +++---- > .../common/eal_common_trace_points.c | 164 ++++++-------- > lib/librte_eal/include/rte_eal_trace.h | 122 +++++------ > lib/librte_eal/include/rte_trace_point.h | 14 +- > .../include/rte_trace_point_register.h | 6 +- > lib/librte_ethdev/ethdev_trace_points.c | 44 ++-- > lib/librte_eventdev/eventdev_trace_points.c | 205 +++++++----------- > lib/librte_mempool/mempool_trace_points.c | 124 ++++------- > 10 files changed, 309 insertions(+), 478 deletions(-)