From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C697426B7; Wed, 4 Oct 2023 19:40:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0027C402B3; Wed, 4 Oct 2023 19:40:09 +0200 (CEST) Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by mails.dpdk.org (Postfix) with ESMTP id EBC3F402A9 for ; Wed, 4 Oct 2023 19:40:08 +0200 (CEST) Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-7741109bdeeso3487685a.2 for ; Wed, 04 Oct 2023 10:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696441208; x=1697046008; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UTkwCcFhBLwpOq0ObBmvRqsbMKQ9Oz7nqHn2AcyqvFo=; b=XcMdr8kc9WYkhsgVo1SD+vnlx8JmCaVM6/bTYtVXRerVaQ3EGFsHXGJmgZ2E3WDPez KY98WTJtDuuEu+jzggnCkzCGHrvtlYRl+JCcER1UDVqzOfqp+MXeJawVbBjW49cEEsNo msxyKi9nImoifoFPPFK5ApC+O7hIWjdI0EBLQk9o3yVUTDtQrVlVRoR+C4g8nb2DC6W9 OBLpfKYqMmppUjLpv3myZFb6XZJs08IFlHL2VqDh+EZ2eqKLNG3oj/akaT2YJZpo0M4g tzdjWtbXGDXrwmDhF4NDOAtPV3xSO0jOLYEf3LF+tsFTqea7Jt/RVDig8yfN3nimXmVa ob/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696441208; x=1697046008; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UTkwCcFhBLwpOq0ObBmvRqsbMKQ9Oz7nqHn2AcyqvFo=; b=adHrExPj1RQiDRFVYY1uiva+06x33XwabKQSKpO5KtLP/cfPu+RbJiTMQAKUGAnaLO jBqEoR2WEN67b0SFiO7rv1r3d+WabRWlX0a3qRBW137+FD26vPEu1zwngdokCVQZZUTo fbugTg0218n9C9KxsTekR2TnYFt+RGuDMMX93FQ0qTZZGdBIadMel0K1e+y5yLErNm49 Ygt2Jn433plNEhgebuFsjQaTJP9Qm4aFqMwzR1q3S1s/nC6L3mpCPSmmWbWZZVq/0xt0 BvbKtzu1Wcv7un12+mPm1CVt+ngFoY2aE1M7rokXH5oiITmzoJ39O/9xyW/23p3Ht0/O a2Fg== X-Gm-Message-State: AOJu0Yxtkq8bp3XbMxkmHK/nLQ6CEIop5usdHGsdgZMUPrAgue96gpwC fzCKIrlrmXfLMiu5zpdnbAuCQdT8lDlb8hDSUwU= X-Google-Smtp-Source: AGHT+IFz+K/inagVVFK6w/LmYuzmkY8S7aXqxPbpXpt7FT+SD3B8GCQI/8UEVJmZeRxoFDZuR9BkPcykwtCAq82I+Xw= X-Received: by 2002:a05:620a:f13:b0:775:8fcd:3b03 with SMTP id v19-20020a05620a0f1300b007758fcd3b03mr3740649qkl.3.1696441208225; Wed, 04 Oct 2023 10:40:08 -0700 (PDT) MIME-Version: 1.0 References: <20231003170115.571133-1-bruce.richardson@intel.com> <20231004162834.249828-1-bruce.richardson@intel.com> In-Reply-To: <20231004162834.249828-1-bruce.richardson@intel.com> From: Jerin Jacob Date: Wed, 4 Oct 2023 23:09:41 +0530 Message-ID: Subject: Re: [PATCH v2] eventdev: drop custom OS defines To: Bruce Richardson Cc: dev@dpdk.org, Jerin Jacob , Naga Harish K S V Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 4, 2023 at 10:05=E2=80=AFPM Bruce Richardson wrote: > > The eventdev library doesn't need to put in place its own defines for > Linux and BSD. There are already defines for the OS environment in > rte_config.h that can be re-used, but since these are just for > identifying Linux/non-Linux, we can just check for the standard define > '__linux__' instead. > > Signed-off-by: Bruce Richardson Acked-by: Jerin Jacob Applied to dpdk-next-net-eventdev/for-main. Thanks > --- > lib/eventdev/meson.build | 6 ------ > lib/eventdev/rte_event_eth_rx_adapter.c | 6 +++--- > 2 files changed, 3 insertions(+), 9 deletions(-) > > diff --git a/lib/eventdev/meson.build b/lib/eventdev/meson.build > index 250abcb154..a04bb86f0f 100644 > --- a/lib/eventdev/meson.build > +++ b/lib/eventdev/meson.build > @@ -7,12 +7,6 @@ if is_windows > subdir_done() > endif > > -if is_linux > - cflags +=3D '-DLINUX' > -else > - cflags +=3D '-DBSD' > -endif > - > sources =3D files( > 'eventdev_private.c', > 'eventdev_trace_points.c', > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_e= vent_eth_rx_adapter.c > index ea7106a1fe..6db03adf04 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -5,7 +5,7 @@ > #include > #include > #include > -#if defined(LINUX) > +#if defined(__linux__) > #include > #endif > #include > @@ -1567,11 +1567,11 @@ rxa_default_conf_cb(uint8_t id, uint8_t dev_id, > static int > rxa_epoll_create1(void) > { > -#if defined(LINUX) > +#if defined(__linux__) > int fd; > fd =3D epoll_create1(EPOLL_CLOEXEC); > return fd < 0 ? -errno : fd; > -#elif defined(BSD) > +#else > return -ENOTSUP; > #endif > } > -- > 2.39.2 >