From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11DC241B91; Tue, 31 Jan 2023 19:46:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB5FF40684; Tue, 31 Jan 2023 19:46:46 +0100 (CET) Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by mails.dpdk.org (Postfix) with ESMTP id EFCEE4067B for <dev@dpdk.org>; Tue, 31 Jan 2023 19:46:45 +0100 (CET) Received: by mail-vs1-f43.google.com with SMTP id h19so15309490vsv.13 for <dev@dpdk.org>; Tue, 31 Jan 2023 10:46:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FzNjO4mZmXRufEpDEHlzvry3ZHMqEBlpC9Aq4hH7Jrw=; b=BL1Gemm32jU6593gqMJsqa8SEKKmhvfglezTigevcwMvYm8XM1RQ7btARt5ljFy49T UoiftmASu79vW0xClIgwI58nTrdHWHcYohh9IHytsrjEvQVxNrVf4G3OxgQMR2aI1vU9 vo0N3gmdAMXdx/LXhBPNjnp7LWq6BDOiWx/Ddhx9ZE8cyOmDZTpa03GdeT2ft9ummYzp sGQ7qws58EALmlomEuZALmUyepuwDdHzZuirqbbN2Nb4NXT9ur8gOvxP+mxRN+0HTZ4p M9EEHrOXyMNBpODUXwLWnRssfewmWdA4yuO3IvQtU/axkIXUdALVqHevdbktOmqBW8CT UEEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FzNjO4mZmXRufEpDEHlzvry3ZHMqEBlpC9Aq4hH7Jrw=; b=FJ69URjRzNOY+ZNYmqtjgZ7HPuzubaUPEF5OZgPrVePDeHMK6p/QMc8l4XQEuluAoM VhIgGpDpJsXKu6jFmMuXofBWGdOoRgxwnpHhgvzc9hXobJvrWzaoBlky0PylCfIoQVGt ndgp09PF1v5lB0kPFfULIWGw/BanLPQfXsLjWF64yzp3j4cR7wB+XosWGe9PSmxlwfGX Eb4FhKCruT2zuUl4wDXXZtF8/Gmy0vCdJWol62aA6lrW+8zK6y6DmGOwmZZd+3Ffhr5C Ong3zbGZHbpXh2xCGITw6Xt85jbaVOqFeVw7B83+++73l6l7Vhj2F4k2EHPJtKHnZsn1 4qpg== X-Gm-Message-State: AO0yUKW+EIWZuACnc7s9xU7WntGibr/3g9QqcjCIUbV9bPGKyxu5JJdP wY2NPBnAGu8RByZTsNg2sdCyZfbvg2GKh5RGZIU= X-Google-Smtp-Source: AK7set/Mp12bHBW157W7itgjqja1I4LUuqJr94aNv/dVt6j45bFye//5mGZfjPbGNtKMGEL48Epbe1hqVgT/XsV15jw= X-Received: by 2002:a67:b60a:0:b0:3fe:3011:1976 with SMTP id d10-20020a67b60a000000b003fe30111976mr462925vsm.52.1675190805317; Tue, 31 Jan 2023 10:46:45 -0800 (PST) MIME-Version: 1.0 References: <20230112112140.807233-1-adwivedi@marvell.com> <20230120084059.2926575-1-adwivedi@marvell.com> <20230120084059.2926575-3-adwivedi@marvell.com> <614e22c6-8485-0e8d-742e-b3d100f96468@amd.com> <CO3PR18MB5005D5C60D32EF5564A2C46EDDD39@CO3PR18MB5005.namprd18.prod.outlook.com> <91a635b5-3fe5-b47d-d8ba-44f9b1614bf9@amd.com> In-Reply-To: <91a635b5-3fe5-b47d-d8ba-44f9b1614bf9@amd.com> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Wed, 1 Feb 2023 00:16:19 +0530 Message-ID: <CALBAE1Mwatb61An19g1gR4WUhG5TCaihtUEZJs8fsp=GGJtEvQ@mail.gmail.com> Subject: Re: [EXT] Re: [PATCH v6 2/6] ethdev: add trace points for ethdev (part one) To: Ferruh Yigit <ferruh.yigit@amd.com> Cc: Ankur Dwivedi <adwivedi@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>, David Marchand <david.marchand@redhat.com>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, "thomas@monjalon.net" <thomas@monjalon.net>, "mdr@ashroe.eu" <mdr@ashroe.eu>, "orika@nvidia.com" <orika@nvidia.com>, "chas3@att.com" <chas3@att.com>, "humin29@huawei.com" <humin29@huawei.com>, "linville@tuxdriver.com" <linville@tuxdriver.com>, "ciara.loftus@intel.com" <ciara.loftus@intel.com>, "qi.z.zhang@intel.com" <qi.z.zhang@intel.com>, "mw@semihalf.com" <mw@semihalf.com>, "mk@semihalf.com" <mk@semihalf.com>, "shaibran@amazon.com" <shaibran@amazon.com>, "evgenys@amazon.com" <evgenys@amazon.com>, "igorch@amazon.com" <igorch@amazon.com>, "chandu@amd.com" <chandu@amd.com>, Igor Russkikh <irusskikh@marvell.com>, "shepard.siegel@atomicrules.com" <shepard.siegel@atomicrules.com>, "ed.czeck@atomicrules.com" <ed.czeck@atomicrules.com>, "john.miller@atomicrules.com" <john.miller@atomicrules.com>, "ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>, "somnath.kotur@broadcom.com" <somnath.kotur@broadcom.com>, "Maciej Czekaj [C]" <mczekaj@marvell.com>, Shijith Thotton <sthotton@marvell.com>, Srisivasubramanian Srinivasan <srinivasan@marvell.com>, Harman Kalra <hkalra@marvell.com>, "rahul.lakkireddy@chelsio.com" <rahul.lakkireddy@chelsio.com>, "johndale@cisco.com" <johndale@cisco.com>, "hyonkim@cisco.com" <hyonkim@cisco.com>, "liudongdong3@huawei.com" <liudongdong3@huawei.com>, "yisen.zhuang@huawei.com" <yisen.zhuang@huawei.com>, "xuanziyang2@huawei.com" <xuanziyang2@huawei.com>, "cloud.wangxiaoyun@huawei.com" <cloud.wangxiaoyun@huawei.com>, "zhouguoyang@huawei.com" <zhouguoyang@huawei.com>, "simei.su@intel.com" <simei.su@intel.com>, "wenjun1.wu@intel.com" <wenjun1.wu@intel.com>, "qiming.yang@intel.com" <qiming.yang@intel.com>, "Yuying.Zhang@intel.com" <Yuying.Zhang@intel.com>, "beilei.xing@intel.com" <beilei.xing@intel.com>, "xiao.w.wang@intel.com" <xiao.w.wang@intel.com>, "jingjing.wu@intel.com" <jingjing.wu@intel.com>, "junfeng.guo@intel.com" <junfeng.guo@intel.com>, "rosen.xu@intel.com" <rosen.xu@intel.com>, Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar Kokkilagadda <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>, Liron Himi <lironh@marvell.com>, "zr@semihalf.com" <zr@semihalf.com>, Radha Chintakuntla <radhac@marvell.com>, Veerasenareddy Burru <vburru@marvell.com>, Sathesh B Edara <sedara@marvell.com>, "matan@nvidia.com" <matan@nvidia.com>, "viacheslavo@nvidia.com" <viacheslavo@nvidia.com>, "longli@microsoft.com" <longli@microsoft.com>, "spinler@cesnet.cz" <spinler@cesnet.cz>, "chaoyong.he@corigine.com" <chaoyong.he@corigine.com>, "niklas.soderlund@corigine.com" <niklas.soderlund@corigine.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "sachin.saxena@oss.nxp.com" <sachin.saxena@oss.nxp.com>, "g.singh@nxp.com" <g.singh@nxp.com>, "apeksha.gupta@nxp.com" <apeksha.gupta@nxp.com>, "sachin.saxena@nxp.com" <sachin.saxena@nxp.com>, "aboyer@pensando.io" <aboyer@pensando.io>, Rasesh Mody <rmody@marvell.com>, Shahed Shaikh <shshaikh@marvell.com>, Devendra Singh Rawat <dsinghrawat@marvell.com>, "jiawenwu@trustnetic.com" <jiawenwu@trustnetic.com>, "jianwang@trustnetic.com" <jianwang@trustnetic.com>, "jbehrens@vmware.com" <jbehrens@vmware.com>, "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>, "chenbo.xia@intel.com" <chenbo.xia@intel.com>, "steven.webster@windriver.com" <steven.webster@windriver.com>, "matt.peters@windriver.com" <matt.peters@windriver.com>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, "mtetsuyah@gmail.com" <mtetsuyah@gmail.com>, "grive@u256.net" <grive@u256.net>, "jasvinder.singh@intel.com" <jasvinder.singh@intel.com>, "cristian.dumitrescu@intel.com" <cristian.dumitrescu@intel.com>, "jgrajcia@cisco.com" <jgrajcia@cisco.com>, "mb@smartsharesystems.com" <mb@smartsharesystems.com> Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Wed, Feb 1, 2023 at 12:09 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote: > > On 1/30/2023 4:01 PM, Ankur Dwivedi wrote: > > <...> > > >>> diff --git a/lib/ethdev/meson.build b/lib/ethdev/meson.build index > >>> 39250b5da1..f5c0865023 100644 > >>> --- a/lib/ethdev/meson.build > >>> +++ b/lib/ethdev/meson.build > >>> @@ -24,6 +24,7 @@ headers = files( > >>> 'rte_ethdev.h', > >>> 'rte_ethdev_trace.h', > >>> 'rte_ethdev_trace_fp.h', > >>> + 'rte_ethdev_trace_fp_burst.h', > >> > >> Why these trace headers are public? > >> Aren't trace points only used by the APIs, so I expect them to be internal, so > >> applications shouldn't need them. Why they are expsed to user. > > 'rte_ethdev_trace.h' can be made as internal. Not sure about 'rte_ethdev_trace_fp.h' and 'rte_ethdev_trace_fp_burst.h' as the tracepoints in fast path may be called from public inline functions. > > Trace calls used by inline functions needs to be public, in this case at > least 'rte_ethdev_trace_fp_burst.h' needs to be public. > > Can you please at least move all trace points that are called by inline > functions to the same file, 'rte_ethdev_trace_fp_burst.h', to reduce > number of the header files to make public? Feel free to rename header if > required. > > Meanwhile not sure about adding new header as dependency to end user. > @Jerin, @Andrew, what do you think rte_ethdev_trace_fp_burst.h will be installed through ninja install and application does not need to directly include this. So this scheme is OK. Right? I dont see any downside. > 1) to move these trace points to 'rte_ethdev_core.h' > OR > 2) disable trace calls in inline functions on compile time, possibly > with existing 'RTE_ETHDEV_DEBUG_*' macro