From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1C5F41C5D; Fri, 10 Feb 2023 09:16:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB8B5410D0; Fri, 10 Feb 2023 09:16:30 +0100 (CET) Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) by mails.dpdk.org (Postfix) with ESMTP id BFE1A40EE6 for ; Fri, 10 Feb 2023 09:16:28 +0100 (CET) Received: by mail-vs1-f44.google.com with SMTP id x8so4868779vso.2 for ; Fri, 10 Feb 2023 00:16:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0bzeJTcqP5outdNQ3MCq/LAi7olAXWoEr79HPlM4A+w=; b=bEbT7OzMjxVbbUUhwQYSGNBLyZ4PLngLjCgbNkaCAGnwGUcPRpN1+dQs+rbIawJuRL d1yIwMLcY/JdbT63jOL6mujJwnzVOwJXPRXSSqnQ+UgsdhR/uTTCVXf7REudxK0jGvLL lZ0CZWoPSLGvjGQ0ZmGqwnFD620EteEizADlPHmQreNv9KRtRZHitDOajr7f5L/v4s0I fxDO6KIaVTBvMnC6SQqkQNEwwlGWBFr4qizhaYCS7rVEolIkCGj1KfMsfjCrk7C0W/4T MM68AkjH2wtybYPhYnb3b5DgFiFJbDvDyGW1c0yAj5gufs2As9kp6a96dX0xBHsTlDRn xSzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0bzeJTcqP5outdNQ3MCq/LAi7olAXWoEr79HPlM4A+w=; b=INA4XF8jQNGnTY2caaMgVpeFS76SChPdj1P5SHlFRmfX9HCWvgld+WZPtSRGy41wTl EDUZNXBotBFigLu5aZac9TzScKWYAxQrvKcZqgXj8pbX+pVaL0Pbadh1y4XlN5SyhCBk BbXl0tK+JvyHf4tYi0/MbU+a1TNQRc0efNidTuVGRPqf/VfPKQytWCm867ncxoMzmnJV 0mSNdHmGDtmeAkTAwPJHSahAHbxWv8MBjhOkjFhbiKC1TM1WEFjoXvI8N8iO8dDwKUWJ J2q+LkJWKEm/uzmdOrGQNbGSq6ryHNep4IumnkwWZrpUVfYcIUeQBJBazcRihmnemmi/ z64w== X-Gm-Message-State: AO0yUKVEQAHHpjd1kDMWGdi5Vx4xLutmhyBeMbO6PXIqTnAs8/+MTcKc acbvJzbtaClLVvOqJ5AGZHuocE9KfeedYZw/O7Y= X-Google-Smtp-Source: AK7set99TrIWrjSZ1wcg3mnarJvuWxpNVHNXAx+kMYOhIHi/+wwtbqjDS0XadoSHZAJe64sBaJX2KnwsMNNTEqAb+UQ= X-Received: by 2002:a05:6102:5c1a:b0:3fe:3011:1976 with SMTP id ds26-20020a0561025c1a00b003fe30111976mr3103171vsb.52.1676016988070; Fri, 10 Feb 2023 00:16:28 -0800 (PST) MIME-Version: 1.0 References: <20230209083558.958566-1-rkudurumalla@marvell.com> <20230210081422.1004901-1-rkudurumalla@marvell.com> In-Reply-To: <20230210081422.1004901-1-rkudurumalla@marvell.com> From: Jerin Jacob Date: Fri, 10 Feb 2023 13:46:02 +0530 Message-ID: Subject: Re: [PATCH v5 1/3] ethdev: skip congestion management configuration To: Rakesh Kudurumalla Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Ferruh Yigit , Ori Kam , Thomas Monjalon , Andrew Rybchenko , jerinj@marvell.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 10, 2023 at 1:44 PM Rakesh Kudurumalla wrote: > > Introduce new flow action to skip congestion management configuration > This feature helps to skip the congestion management processing > based on per flow or the packet color identified by > rte_flow meter object. For example, If one Rx queue configured as > RED congestion and application wants tobypass the RED congestion > processing for all GREEN color packet can be expressed though > RTE_FLOW_ACTION_TYPE_SKIP_CMAN flow action > > Signed-off-by: Rakesh Kudurumalla > Acked-by: Ori Kam > --- > v5: Updated doc > doc/guides/nics/features/cnxk.ini | 1 + > doc/guides/nics/features/cnxk_vf.ini | 1 + > doc/guides/nics/features/default.ini | 1 + > doc/guides/prog_guide/rte_flow.rst | 22 ++++++++++++++++++++++ > lib/ethdev/rte_flow.h | 11 +++++++++++ > 5 files changed, 36 insertions(+) > > diff --git a/doc/guides/nics/features/cnxk.ini b/doc/guides/nics/features/cnxk.ini > index f81628da77..7947c044bb 100644 > --- a/doc/guides/nics/features/cnxk.ini > +++ b/doc/guides/nics/features/cnxk.ini > @@ -94,4 +94,5 @@ queue = Y > represented_port = Y > rss = Y > security = Y > +skip_cman = Y > vf = Y > diff --git a/doc/guides/nics/features/cnxk_vf.ini b/doc/guides/nics/features/cnxk_vf.ini > index c4ee32a9ad..873e1dcc0a 100644 > --- a/doc/guides/nics/features/cnxk_vf.ini > +++ b/doc/guides/nics/features/cnxk_vf.ini > @@ -83,4 +83,5 @@ pf = Y > queue = Y > rss = Y > security = Y > +skip_cman = Y > vf = Y cnxk specific . Move to 3/3 patch. > diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini > index 510cc6679d..b93f053a2b 100644 > --- a/doc/guides/nics/features/default.ini > +++ b/doc/guides/nics/features/default.ini > @@ -198,6 +198,7 @@ set_tag = > set_tp_dst = > set_tp_src = > set_ttl = > +skip_cman = > vf = > vxlan_decap = > vxlan_encap = > diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst > index 3e6242803d..4efadcc87b 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -1840,6 +1840,28 @@ Drop packets. > | no properties | > +---------------+ > > + > +Action: ``SKIP_CMAN`` > +^^^^^^^^^^^^^^^^^^^^^ > + > +Skip congestion management on received packets > + > +- Using ``rte_eth_cman_config_set()``, application can configure ethdev Rx > + queue's congestion mechanism.Once applied packets congestion configuration > + is bypassed on that particular ethdev Rx queue for all packets directed > + to that receive queue > + > +.. _table_rte_flow_action_skip_cman: > + > +.. table:: SKIP_CMAN > + > + +---------------+ > + | Field | > + +===============+ > + | no properties | > + +---------------+ > + > + > Action: ``COUNT`` > ^^^^^^^^^^^^^^^^^ > > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index b60987db4b..f4eb4232d4 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -2203,6 +2203,17 @@ enum rte_flow_action_type { > */ > RTE_FLOW_ACTION_TYPE_DROP, > > + /** > + * Skip congestion management configuration > + * > + * Using rte_eth_cman_config_set() API the application > + * can configure ethdev Rx queue's congestion mechanism. > + * Introducing RTE_FLOW_ACTION_TYPE_SKIP_CMAN flow action to skip the > + * congestion configuration applied to the given ethdev Rx queue. > + * > + */ > + RTE_FLOW_ACTION_TYPE_SKIP_CMAN, > + > /** > * Enables counters for this flow rule. > * > -- > 2.25.1 >