From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE7BAA00C2; Wed, 28 Sep 2022 13:14:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A297D4113D; Wed, 28 Sep 2022 13:14:42 +0200 (CEST) Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by mails.dpdk.org (Postfix) with ESMTP id 7A4174113C for <dev@dpdk.org>; Wed, 28 Sep 2022 13:14:40 +0200 (CEST) Received: by mail-qk1-f170.google.com with SMTP id d17so7590012qko.13 for <dev@dpdk.org>; Wed, 28 Sep 2022 04:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=UYfUjkyg8u/93jXANwQMU4fsqaoTssmDe9n3No5kgaE=; b=bHsx2/A+O+MlZ/oUW9mkgF+fxlBvxgtoAF4ZnK/oFDsLmNM/Jzg76IZvB8HR56R/Za qlSh2C/NiiOZLhKqAioN8agTtaT+WY5pi17R/RHrt5B9lQbb85ffqCbovHHIPrrQ5X2m F1ieorTDvEdIOF0emH0zZKoZCccyriC+dt0tNGCyWy4w7M1EenPpi8Ye4ZZ5y0cA3KhD oliBUyUkxXkgWmFp0R1tZjxYc3gWIQdxgbq9y0V0N7xK4i9std1krWS7EjWTR1nGSU+K 8zcm6Yh/1epguoWTB7P9KSEvnzRWZLHTYaO2MzKQQISKmZBYiUe3hHSqHNAjG+AKnzcb D3/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=UYfUjkyg8u/93jXANwQMU4fsqaoTssmDe9n3No5kgaE=; b=fNOHDBhefJmHYuUNKbrjhtyJrktWSCpNyxuZzv46qvhjN95kBhHyYQ9xjOruakoiJe wtGpakegso3Dt3C/lmp4kisuVp7y516xnPFJlxv/qlWoJQbkSFqmrHk/5u0SeZum2byr rlIyJjp4m11SKF/rYvVMN64/qzl9UIe+Tg/7L0JFtAuWIyP9MR7WXkd3p49cXEMlnNGU w1Iod3M8Y/+Roy/UHaQ4OjglPghcanr0NWieIljVhyLxXR7Oq0F4LRsmy3rwoeocnsh4 y9z/rHqVjORECtJhpTDa66Mh0yFLBdgM09oADekZxAu74P8FZUZCKoDowL3Jd6Wo/tDT zUsA== X-Gm-Message-State: ACrzQf16W1+GY1nMvTuQkr23TDIvn+GTKzMgmeAq/NFvhbKeqhuImxCI Yk1HRLV58nKYbTiLWZFY6I3RqHSHF8Rq2IPrVqs= X-Google-Smtp-Source: AMsMyM52wYxqzNDpz6HzXxpRJ7SnDYATTyJ6wGuQ9e3XRh5vnhkKWilVXNt5HdxaH0EyWaECL5f9zretb5kg/2x7TQM= X-Received: by 2002:a05:620a:198a:b0:6ce:7f32:9f3f with SMTP id bm10-20020a05620a198a00b006ce7f329f3fmr21478721qkb.90.1664363679847; Wed, 28 Sep 2022 04:14:39 -0700 (PDT) MIME-Version: 1.0 References: <20220713130340.2886839-1-jerinj@marvell.com> <20220919121534.1058884-1-skori@marvell.com> <2199859.3ZeAukHxDK@thomas> <YzMSI29hwFbB3go2@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <YzMSI29hwFbB3go2@bricha3-MOBL.ger.corp.intel.com> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Wed, 28 Sep 2022 16:44:13 +0530 Message-ID: <CALBAE1Mxkb4g3bVz4bz88xR+XEpDcYaF2Nx+1B4ZoNw8JZXpzQ@mail.gmail.com> Subject: Re: [PATCH v2 1/1] ethdev: support congestion management To: Bruce Richardson <bruce.richardson@intel.com>, Olivier Matz <olivier.matz@6wind.com> Cc: Thomas Monjalon <thomas@monjalon.net>, Jerin Jacob <jerinj@marvell.com>, skori@marvell.com, Ferruh Yigit <ferruh.yigit@xilinx.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, dev@dpdk.org, david.marchand@redhat.com, orika@nvidia.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, Sep 27, 2022 at 8:39 PM Bruce Richardson <bruce.richardson@intel.com> wrote: > > On Tue, Sep 27, 2022 at 04:36:18PM +0200, Thomas Monjalon wrote: > > > ++ > > > > I feel EAL is not the right place for CMAN definitions. > > > > After a discussion with Jerin, I understand we could use the same > > definitions in other API classes, not only ethdev. However I think this > > .h file should be better hosted in lib/ethdev/ with its own namespace > > rte_cman. Then other libs could include this rte_cman.h without having a > > strong dependency on ethdev. > > > > Deal? > > > Would rte_net also be an option? Alternatively, is this related to the work Looks like the net is a good option. Since it is just a header file any place would be OK. + @Olivier Matz Any objections to keeping rte_cman.h to lib/net? > and structures defined in the meter library header, since it seems also > related to congestion management on ingress? > > /Bruce