From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1C66A0548; Tue, 17 Aug 2021 14:55:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37C53407FF; Tue, 17 Aug 2021 14:55:09 +0200 (CEST) Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by mails.dpdk.org (Postfix) with ESMTP id C8E794014E for ; Tue, 17 Aug 2021 14:55:07 +0200 (CEST) Received: by mail-il1-f178.google.com with SMTP id y3so22086694ilm.6 for ; Tue, 17 Aug 2021 05:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LFhbN2unEEdNyiy5b7ZAvzVA5qXaAep9ThALtVedIJI=; b=nOQoWHvpsfSlsfSEsC5nWU7hsKDb1BG+vLQO+ntRUF9LnzVSLzGcQ96fXjxBZeUn3i IaghBcE8pXOBE62jifKuOMMKXrwy/W06pHZvHIltV4Gy4rPskHWoFsOtEYBX9rgG9pZp qQkqlnHRUxENhV2jxQPkoZYrQz7jD/KCDej8DxT25/MjU5Zkk1dKfT1K1o84gpHj9PYz EdFAfxlvG74YUL/Fofth4zlZzfLg8ZfS+U+0V98oc/UMRVBVF9tgxcsGTtKM3Yr3+/jB 0WtJ4ILxXaNevYXUAONmnYvGeW/ZfgheZutu+9eWicVdyqv5YyWgyRPijfdS3+XBUg+P fIAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LFhbN2unEEdNyiy5b7ZAvzVA5qXaAep9ThALtVedIJI=; b=LOYiDyOtgET71Qd4D3Muul9MR+eU07K0S5gbSuc4xKv/Q83iwfXcSkbEYhx41SdKrk s0+ZNfFgmVxF+/Q9BerIhWH3Y/9sLJJEi0+eOnGqs1GmP+7vYYLN4+qT8XFzN/QIqoGc mdI2tyaP1x69OFoI2qyUtIdLTox68YY1kezyxDzqOBtNTgAYWUcHOgeRHnWs2C2nqfqQ XunYAOy9a1wXxVvlkGf0SepNNsY+11i7tMf7I2/YeVjOjYfCfr93wFWSmpOnls82185L xNe64xQqBUznCQCxR3hhote+UrdBYE74+qRHcSjLizbm80iaAskb2Qpqr3+t10QGlbA4 axCg== X-Gm-Message-State: AOAM533WSrVrFQ748QMdW7mhr0sJ7VGnPrr12oMG15VxQOxx6uRl3wKJ /y0+yV/AtLfsdp7uij02DahtIVJa67WdsKL6qJc= X-Google-Smtp-Source: ABdhPJwcgUnH6PS3gHTWGIz6VtaM8U3W8QyUMH2kwlTM+qavfyZ0hP8qENaXCsS9s3aguHAN6KqP7fmYTQDG+rVIarg= X-Received: by 2002:a92:d70f:: with SMTP id m15mr2293486iln.162.1629204906991; Tue, 17 Aug 2021 05:55:06 -0700 (PDT) MIME-Version: 1.0 References: <20210730052434.2627818-1-jerinj@marvell.com> <20210730073548.3596659-1-jerinj@marvell.com> In-Reply-To: From: Jerin Jacob Date: Tue, 17 Aug 2021 18:24:40 +0530 Message-ID: To: Bruce Richardson Cc: Jerin Jacob , Andrew Rybchenko , Haiyue Wang , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Qiming Yang , Jiawen Wu , Harman Kalra , Rasesh Mody , Devendra Singh Rawat , Igor Russkikh , Maciej Czekaj , Jian Wang , Rosen Xu , Tianfei zhang , dpdk-dev , Thomas Monjalon , David Marchand Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Aug 17, 2021 at 5:59 PM Bruce Richardson wrote: > > On Fri, Jul 30, 2021 at 01:05:48PM +0530, jerinj@marvell.com wrote: > > From: Jerin Jacob > > > > Since meson 0.59.0 version, the extract_all_objects() API > > need to pass explicit boolean value. > > > > To remove the following warning[1], added explicit `true` for > > extract_all_objects() use in codebase whever there is > > no argument. > > > > [1] > > WARNING: extract_all_objects called without setting recursive > > keyword argument. Meson currently defaults to > > non-recursive to maintain backward compatibility but > > the default will be changed in the future. > > > > Technically this is changing the default behaviour since it previously > defaulted to "false". However, since there should be no recursion involved > here anyway, I don't think it matters, correct? Yes. To be on the safer side, I just put "true" in case some drivers using for a recursive way. > > > Signed-off-by: Jerin Jacob > > --- > > v2..v1 > > - Corrrect the meson version number in git commit log(0.46.0 to 0.59.0) > > > > drivers/common/sfc_efx/base/meson.build | 2 +- > > drivers/meson.build | 2 +- > > drivers/net/e1000/base/meson.build | 2 +- > > drivers/net/fm10k/base/meson.build | 2 +- > > drivers/net/hinic/base/meson.build | 2 +- > > drivers/net/i40e/base/meson.build | 2 +- > > drivers/net/ice/base/meson.build | 2 +- > > drivers/net/igc/base/meson.build | 2 +- > > drivers/net/ixgbe/base/meson.build | 2 +- > > drivers/net/ngbe/base/meson.build | 2 +- > > drivers/net/octeontx/base/meson.build | 2 +- > > drivers/net/qede/base/meson.build | 2 +- > > drivers/net/thunderx/base/meson.build | 2 +- > > drivers/net/txgbe/base/meson.build | 2 +- > > drivers/raw/ifpga/base/meson.build | 2 +- > > 15 files changed, 15 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/common/sfc_efx/base/meson.build b/drivers/common/sfc_efx/base/meson.build > > index 9fba47b1cc..ff7f33fb44 100644 > > --- a/drivers/common/sfc_efx/base/meson.build > > +++ b/drivers/common/sfc_efx/base/meson.build > > @@ -86,7 +86,7 @@ if build > > dependencies: static_rte_eal, > > c_args: c_args) > > > > - base_objs = base_lib.extract_all_objects() > > + base_objs = base_lib.extract_all_objects(recursive: true) > > else > > base_objs = [] > > endif > > diff --git a/drivers/meson.build b/drivers/meson.build > > index bc6f4f567f..d9e331ec85 100644 > > --- a/drivers/meson.build > > +++ b/drivers/meson.build > > @@ -160,7 +160,7 @@ foreach subpath:subdirs > > include_directories: includes, > > dependencies: static_deps, > > c_args: cflags) > > - objs += tmp_lib.extract_all_objects() > > + objs += tmp_lib.extract_all_objects(recursive: true) > > sources = custom_target(out_filename, > > command: [pmdinfo, tmp_lib.full_path(), '@OUTPUT@', pmdinfogen], > > output: out_filename, > > diff --git a/drivers/net/e1000/base/meson.build b/drivers/net/e1000/base/meson.build > > index 317692dfab..528a33f958 100644 > > --- a/drivers/net/e1000/base/meson.build > > +++ b/drivers/net/e1000/base/meson.build > > @@ -35,4 +35,4 @@ endforeach > > base_lib = static_library('e1000_base', sources, > > dependencies: static_rte_eal, > > c_args: c_args) > > -base_objs = base_lib.extract_all_objects() > > +base_objs = base_lib.extract_all_objects(recursive: true) > > diff --git a/drivers/net/fm10k/base/meson.build b/drivers/net/fm10k/base/meson.build > > index ca98d34d4e..bd19df27f7 100644 > > --- a/drivers/net/fm10k/base/meson.build > > +++ b/drivers/net/fm10k/base/meson.build > > @@ -25,4 +25,4 @@ endforeach > > base_lib = static_library('fm10k_base', sources, > > dependencies: static_rte_eal, > > c_args: c_args) > > -base_objs = base_lib.extract_all_objects() > > +base_objs = base_lib.extract_all_objects(recursive: true) > > diff --git a/drivers/net/hinic/base/meson.build b/drivers/net/hinic/base/meson.build > > index a00c90c14e..3aa53df881 100644 > > --- a/drivers/net/hinic/base/meson.build > > +++ b/drivers/net/hinic/base/meson.build > > @@ -34,4 +34,4 @@ c_args = cflags > > base_lib = static_library('hinic_base', sources, > > dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci, static_rte_hash], > > c_args: c_args) > > -base_objs = base_lib.extract_all_objects() > > +base_objs = base_lib.extract_all_objects(recursive: true) > > diff --git a/drivers/net/i40e/base/meson.build b/drivers/net/i40e/base/meson.build > > index 79a887a297..d94108629b 100644 > > --- a/drivers/net/i40e/base/meson.build > > +++ b/drivers/net/i40e/base/meson.build > > @@ -27,4 +27,4 @@ endforeach > > base_lib = static_library('i40e_base', sources, > > dependencies: static_rte_eal, > > c_args: c_args) > > -base_objs = base_lib.extract_all_objects() > > +base_objs = base_lib.extract_all_objects(recursive: true) > > diff --git a/drivers/net/ice/base/meson.build b/drivers/net/ice/base/meson.build > > index 3305e5dd18..30e251876d 100644 > > --- a/drivers/net/ice/base/meson.build > > +++ b/drivers/net/ice/base/meson.build > > @@ -43,4 +43,4 @@ endforeach > > base_lib = static_library('ice_base', sources, > > dependencies: static_rte_eal, > > c_args: c_args) > > -base_objs = base_lib.extract_all_objects() > > +base_objs = base_lib.extract_all_objects(recursive: true) > > diff --git a/drivers/net/igc/base/meson.build b/drivers/net/igc/base/meson.build > > index 8affc72e65..f52421f7a9 100644 > > --- a/drivers/net/igc/base/meson.build > > +++ b/drivers/net/igc/base/meson.build > > @@ -16,4 +16,4 @@ base_lib = static_library('igc_base', sources, > > dependencies: static_rte_eal, > > c_args: cflags) > > > > -base_objs = base_lib.extract_all_objects() > > +base_objs = base_lib.extract_all_objects(recursive: true) > > diff --git a/drivers/net/ixgbe/base/meson.build b/drivers/net/ixgbe/base/meson.build > > index 7d3cec002d..22972c6b56 100644 > > --- a/drivers/net/ixgbe/base/meson.build > > +++ b/drivers/net/ixgbe/base/meson.build > > @@ -31,4 +31,4 @@ endforeach > > base_lib = static_library('ixgbe_base', sources, > > dependencies: static_rte_eal, > > c_args: c_args) > > -base_objs = base_lib.extract_all_objects() > > +base_objs = base_lib.extract_all_objects(recursive: true) > > diff --git a/drivers/net/ngbe/base/meson.build b/drivers/net/ngbe/base/meson.build > > index a1a9c2ff65..6081281135 100644 > > --- a/drivers/net/ngbe/base/meson.build > > +++ b/drivers/net/ngbe/base/meson.build > > @@ -18,4 +18,4 @@ c_args = cflags > > base_lib = static_library('ngbe_base', sources, > > dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci], > > c_args: c_args) > > -base_objs = base_lib.extract_all_objects() > > +base_objs = base_lib.extract_all_objects(recursive: true) > > diff --git a/drivers/net/octeontx/base/meson.build b/drivers/net/octeontx/base/meson.build > > index c86a726704..8e5e8c1b55 100644 > > --- a/drivers/net/octeontx/base/meson.build > > +++ b/drivers/net/octeontx/base/meson.build > > @@ -22,4 +22,4 @@ base_lib = static_library('octeontx_base', sources, > > dependencies: static_objs, > > ) > > > > -base_objs = base_lib.extract_all_objects() > > +base_objs = base_lib.extract_all_objects(recursive: true) > > diff --git a/drivers/net/qede/base/meson.build b/drivers/net/qede/base/meson.build > > index 614a0c3808..4ad177b478 100644 > > --- a/drivers/net/qede/base/meson.build > > +++ b/drivers/net/qede/base/meson.build > > @@ -54,4 +54,4 @@ endforeach > > base_lib = static_library('qede_base', sources, > > dependencies: [static_rte_net, static_rte_bus_pci], > > c_args: c_args) > > -base_objs = base_lib.extract_all_objects() > > +base_objs = base_lib.extract_all_objects(recursive: true) > > diff --git a/drivers/net/thunderx/base/meson.build b/drivers/net/thunderx/base/meson.build > > index 704ee65771..cec45d0ae1 100644 > > --- a/drivers/net/thunderx/base/meson.build > > +++ b/drivers/net/thunderx/base/meson.build > > @@ -13,4 +13,4 @@ base_lib = static_library('nicvf_base', sources, > > dependencies: static_rte_ethdev > > ) > > > > -base_objs = base_lib.extract_all_objects() > > +base_objs = base_lib.extract_all_objects(recursive: true) > > diff --git a/drivers/net/txgbe/base/meson.build b/drivers/net/txgbe/base/meson.build > > index c6816b4279..7a30191472 100644 > > --- a/drivers/net/txgbe/base/meson.build > > +++ b/drivers/net/txgbe/base/meson.build > > @@ -24,4 +24,4 @@ endforeach > > base_lib = static_library('txgbe_base', sources, > > dependencies: static_rte_eal, > > c_args: c_args) > > -base_objs = base_lib.extract_all_objects() > > +base_objs = base_lib.extract_all_objects(recursive: true) > > diff --git a/drivers/raw/ifpga/base/meson.build b/drivers/raw/ifpga/base/meson.build > > index 8d27c60213..db602cee69 100644 > > --- a/drivers/raw/ifpga/base/meson.build > > +++ b/drivers/raw/ifpga/base/meson.build > > @@ -40,4 +40,4 @@ ext_deps += rtdep > > base_lib = static_library('ifpga_rawdev_base', sources, > > dependencies: static_rte_eal, > > c_args: cflags) > > -base_objs = base_lib.extract_all_objects() > > +base_objs = base_lib.extract_all_objects(recursive: true) > > -- > > 2.32.0 > >