From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B016A0501; Sat, 21 May 2022 15:00:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1F7440156; Sat, 21 May 2022 15:00:32 +0200 (CEST) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by mails.dpdk.org (Postfix) with ESMTP id A3A6840040 for ; Sat, 21 May 2022 15:00:30 +0200 (CEST) Received: by mail-io1-f54.google.com with SMTP id y12so11172779ior.7 for ; Sat, 21 May 2022 06:00:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vHFdCF/TSxChybBeF/2d1vW4YOHp+yMpV4Et5u2qGBc=; b=AY1QrctxkwwNQ+ZygtSWjnzvMjMHJawvBQhp0zAc8bQBo/w8fy8veNDk5AYp+Jd68G novmWPWM/khFUxfikLy+mjuhyO4PPGFP7zayCljFxk+53Vsuw9PMO7VLJUlZgOnbljr2 c7ox4iWlv7LIyh8V63ecqxDWkcj9/nBRKX6Y7LTR9lAqzxzxXTTuBpkSN3FQcAimk3H0 vWl8wBuX/eUhixni/GK40K49XS39UEsoDdiPhGIUcspKoFNse+1lTEsO4dK2EG6R/xUj iD4LMBH23y4OYca5XR5UwMniUCSxrU1BK1kLIqpL77ae1QWW0w2TduXRa2SOmZE/38tM LqJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vHFdCF/TSxChybBeF/2d1vW4YOHp+yMpV4Et5u2qGBc=; b=5qGhlV6MpauD/aWLcFMVaGj3B80jb1WmZ94vcbk5lu/PCCNja6l5PulgB7/v+7SqlA 4iJtl9o9JFhvB1TkEzu06qz+z8vms0N7+9FdBVvL0KaKdrJ5ijLqVQvDp3yVIKOoxDKc ghr24qrPmi+1qtuRZ32CkSlTBsgRV1wkExuevMPIUT/jLW0GjS8nzyGT/Tbwg1gAjP0H oonlQy23EIv0ffCzntg43QxqIL9EmQ1MFMs3AaIT81dTmq5vIwEwKfRdLYjry25jOFUY NDWLr8ahDRVgydiP0w8YLD8ytq+oh1mEtNfB8lmFfeJKvyDNhBhBzU8wUO7YrpU7jBTD HucQ== X-Gm-Message-State: AOAM531E7CLYfDx6Hexx6riRu+nfc1xc+JIz+24QNKDl0s6GEeS0/jDI zSH6ipfdikClGWl9dMLwIjakRArQfNvPOMQNaRc= X-Google-Smtp-Source: ABdhPJznR50Y+hMwNz+AWHyCzvzC+h7N5aigOEHF7M/Q412XdqTkwaIT2Dg+vuZOLjRcNIA6U8P/YXGZvKWOIoZGJ24= X-Received: by 2002:a02:3f49:0:b0:32d:e239:e246 with SMTP id c9-20020a023f49000000b0032de239e246mr7806405jaf.79.1653138029941; Sat, 21 May 2022 06:00:29 -0700 (PDT) MIME-Version: 1.0 References: <20220519200111.3605782-1-timothy.mcdaniel@intel.com> In-Reply-To: <20220519200111.3605782-1-timothy.mcdaniel@intel.com> From: Jerin Jacob Date: Sat, 21 May 2022 18:30:04 +0530 Message-ID: Subject: Re: [PATCH v2] event/dlb2: add support for single 512B write of 4 QEs To: Timothy McDaniel Cc: Jerin Jacob , "Richardson, Bruce" , dpdk-dev , Kent Wires Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, May 20, 2022 at 1:31 AM Timothy McDaniel wrote: > > On Xeon, as 512b accesses are available, movdir64 instruction is able to > perform 512b read and write to DLB producer port. In order for movdir64 > to be able to pull its data from store buffers (store-buffer-forwarding) > (before actual write), data should be in single 512b write format. > This commit add change when code is built for Xeon with 512b AVX support > to make single 512b write of all 4 QEs instead of 4x64b writes. > > Signed-off-by: Timothy McDaniel > Acked-by: Kent Wires > === > > Changes since V1: > 1) Split out dlb2_event_build_hcws into two implementations, one > that uses AVX512 instructions, and one that does not. Each implementation > is in its own source file in order to avoid build errors if the compiler > does not support the newer AVX512 instructions. > 2) Update meson.build to and pull in appropriate source file based on > whether the compiler supports AVX512VL > 3) Check if target supports AVX512VL, and use appropriate implementation > based on this runtime check. > --- > drivers/event/dlb2/dlb2.c | 206 +--------------------- > drivers/event/dlb2/dlb2_avx512.c | 267 +++++++++++++++++++++++++++++ > drivers/event/dlb2/dlb2_noavx512.c | 219 +++++++++++++++++++++++ Could you change the file name to dlb2_sve.c as noavx512 means it can be NEON too. Rest looks good to me. Will merge the next version.