From: Jerin Jacob <jerinjacobk@gmail.com>
To: Tomasz Duszynski <tduszynski@marvell.com>
Cc: dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 00/32] add support for baseband phy
Date: Mon, 21 Jun 2021 14:13:50 +0530 [thread overview]
Message-ID: <CALBAE1MzK7LaZiYr=-NXYdf1EppfGjb1dBVoAnXEmpNaaBT9DQ@mail.gmail.com> (raw)
In-Reply-To: <20210615110345.11057-1-tduszynski@marvell.com>
On Tue, Jun 15, 2021 at 4:33 PM Tomasz Duszynski <tduszynski@marvell.com> wrote:
>
> This series adds initial support for baseband PHY available on SOCs
> belonging to Fusion family. BPHY is a hardware block comprising
> accelerators and DSPs specifically tailored for 5G/LTE inline usecases.
>
> This series introduces two rawdev PMDs along with low level common code.
>
> CGX/RPM PMD allows one to configure Ethernet I/O interfaces attached to
> BPHY via standard enqueue/dequeue operations.
>
> BPHY PMD provides an out-of-band access to PCI device BARs and a set of
> experimental APIs allowing one to setup custom IRQs handlers. This
> functionality is backed by kernel module using ioctl() mechanism. Series
> has nothing to do with 5G/LTE baseband protocol processing.
This series looks good to me.
Feel free to add my reviewed by for the series after fix the following
1) Typo
diff --git a/doc/guides/rawdevs/cnxk_bphy.rst b/doc/guides/rawdevs/cnxk_bphy.rst
-``CNXK_BPHY_CGX_MSG_TYPE_INTLBK_DISABLE``. Former will activate
internal loobback while the latter
+``CNXK_BPHY_CGX_MSG_TYPE_INTLBK_DISABLE``. Former will activate
internal loopback while the latter
2) checkpatch
WARNING:LONG_LINE: line length of 85 exceeds 80 columns
#88: FILE: drivers/common/cnxk/roc_bphy_cgx.c:77:
+ if (FIELD_GET(SCR0_ETH_EVT_STS_S_EVT_TYPE, *scr0) ==
ETH_EVT_ASYNC &&
3) In the release notes, the following items can be removed.
+ Added new Baseband phy PMD which provides means for configuring
baseband hardware via
+ standard rawdev enq/deq operations. Baseband phy is a hardware
subsystem accelerating
+ 5G/LTE related tasks.
+
+ Both BPHY and BPHY CGX/RPM drivers are related hence kept together
to ease maintenance.
>
> v2:
> - change some errors to more relevant ones (-EINVAL/-ENODEV)
> - fix MAINTAINERS styling issues
> - fix dpdk-devbind.py
> - fix meson.build styling issues
> - fix warning related to possibly uninitialized scr0 variable
> - fix warning releated to unused function
> - improve documentation
> - improve enums items naming
> - spread documentation across relevant patches
>
> Tomasz Duszynski (28):
> common/cnxk: add bphy cgx/rpm initialization and cleanup
> common/cnxk: support for communication with atf
> common/cnxk: support for getting link information
> common/cnxk: support for changing internal loopback
> common/cnxk: support for changing ptp mode
> common/cnxk: support for setting link mode
> common/cnxk: support for changing link state
> common/cnxk: support for lmac start/stop
> raw/cnxk_bphy: add bphy cgx/rpm skeleton driver
> raw/cnxk_bphy: support for reading queue configuration
> raw/cnxk_bphy: support for reading queue count
> raw/cnxk_bphy: support for enqueue operation
> raw/cnxk_bphy: support for dequeue operation
> raw/cnxk_bphy: support for performing selftest
> common/cnxk: support for device init and fini
> common/cnxk: support for baseband PHY irq setup
> common/cnxk: support for checking irq availability
> common/cnxk: support for retrieving irq stack
> common/cnxk: support for removing irq stack
> common/cnxk: support for setting bphy irq handler
> common/cnxk: support for clearing bphy irq handler
> common/cnxk: support for registering bphy irq
> raw/cnxk_bphy: add baseband PHY skeleton driver
> raw/cnxk_bphy: support for reading bphy queue configuration
> raw/cnxk_bphy: support for reading bphy queue count
> raw/cnxk_bphy: support for bphy enqueue operation
> raw/cnxk_bphy: support for bphy dequeue operation
> raw/cnxk_bphy: support for interrupt init and cleanup
> raw/cnxk_bphy: support for reading number of bphy irqs
> raw/cnxk_bphy: support for retrieving bphy device memory
> raw/cnxk_bphy: support for registering bphy irq handlers
> raw/cnxk_bphy: support for bphy selftest
>
> MAINTAINERS | 7 +-
> doc/guides/rawdevs/cnxk_bphy.rst | 154 ++++++++
> doc/guides/rawdevs/index.rst | 1 +
> doc/guides/rel_notes/release_21_08.rst | 13 +
> drivers/common/cnxk/meson.build | 3 +
> drivers/common/cnxk/roc_api.h | 7 +
> drivers/common/cnxk/roc_bphy.c | 40 ++
> drivers/common/cnxk/roc_bphy.h | 17 +
> drivers/common/cnxk/roc_bphy_cgx.c | 396 +++++++++++++++++++
> drivers/common/cnxk/roc_bphy_cgx.h | 120 ++++++
> drivers/common/cnxk/roc_bphy_cgx_priv.h | 131 +++++++
> drivers/common/cnxk/roc_bphy_irq.c | 422 +++++++++++++++++++++
> drivers/common/cnxk/roc_bphy_irq.h | 49 +++
> drivers/common/cnxk/roc_idev.c | 1 +
> drivers/common/cnxk/roc_idev_priv.h | 2 +
> drivers/common/cnxk/roc_io.h | 9 +
> drivers/common/cnxk/roc_io_generic.h | 5 +
> drivers/common/cnxk/roc_priv.h | 3 +
> drivers/common/cnxk/version.map | 22 ++
> drivers/raw/cnxk_bphy/cnxk_bphy.c | 329 ++++++++++++++++
> drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 321 ++++++++++++++++
> drivers/raw/cnxk_bphy/cnxk_bphy_cgx.h | 10 +
> drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c | 206 ++++++++++
> drivers/raw/cnxk_bphy/cnxk_bphy_irq.c | 100 +++++
> drivers/raw/cnxk_bphy/cnxk_bphy_irq.h | 41 ++
> drivers/raw/cnxk_bphy/meson.build | 12 +
> drivers/raw/cnxk_bphy/rte_pmd_bphy.h | 233 ++++++++++++
> drivers/raw/cnxk_bphy/version.map | 3 +
> drivers/raw/meson.build | 1 +
> usertools/dpdk-devbind.py | 6 +-
> 30 files changed, 2662 insertions(+), 2 deletions(-)
> create mode 100644 doc/guides/rawdevs/cnxk_bphy.rst
> create mode 100644 drivers/common/cnxk/roc_bphy.c
> create mode 100644 drivers/common/cnxk/roc_bphy.h
> create mode 100644 drivers/common/cnxk/roc_bphy_cgx.c
> create mode 100644 drivers/common/cnxk/roc_bphy_cgx.h
> create mode 100644 drivers/common/cnxk/roc_bphy_cgx_priv.h
> create mode 100644 drivers/common/cnxk/roc_bphy_irq.c
> create mode 100644 drivers/common/cnxk/roc_bphy_irq.h
> create mode 100644 drivers/raw/cnxk_bphy/cnxk_bphy.c
> create mode 100644 drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c
> create mode 100644 drivers/raw/cnxk_bphy/cnxk_bphy_cgx.h
> create mode 100644 drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c
> create mode 100644 drivers/raw/cnxk_bphy/cnxk_bphy_irq.c
> create mode 100644 drivers/raw/cnxk_bphy/cnxk_bphy_irq.h
> create mode 100644 drivers/raw/cnxk_bphy/meson.build
> create mode 100644 drivers/raw/cnxk_bphy/rte_pmd_bphy.h
> create mode 100644 drivers/raw/cnxk_bphy/version.map
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-06-21 8:44 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 21:41 [dpdk-dev] [PATCH 00/28] " Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 01/28] common/cnxk: add bphy cgx/rpm initialization and cleanup Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 02/28] common/cnxk: add support for communication with atf Tomasz Duszynski
2021-06-10 5:06 ` Jerin Jacob
2021-05-31 21:41 ` [dpdk-dev] [PATCH 03/28] common/cnxk: add support for getting link information Tomasz Duszynski
2021-06-10 5:09 ` Jerin Jacob
2021-05-31 21:41 ` [dpdk-dev] [PATCH 04/28] common/cnxk: add support for changing internal loopback Tomasz Duszynski
2021-06-10 6:19 ` Jerin Jacob
2021-05-31 21:41 ` [dpdk-dev] [PATCH 05/28] common/cnxk: add support for changing ptp mode Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 06/28] common/cnxk: add support for setting link mode Tomasz Duszynski
2021-06-10 6:21 ` Jerin Jacob
2021-05-31 21:41 ` [dpdk-dev] [PATCH 07/28] common/cnxk: add support for changing link state Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 08/28] common/cnxk: add support for lmac start/stop Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 09/28] raw/cnxk_bphy: add bphy cgx/rpm skeleton driver Tomasz Duszynski
2021-06-01 7:30 ` Thomas Monjalon
2021-06-10 6:40 ` Jerin Jacob
2021-05-31 21:41 ` [dpdk-dev] [PATCH 10/28] raw/cnxk_bphy: add support for reading queue configuration Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 11/28] raw/cnxk_bphy: add support for reading queue count Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 12/28] raw/cnxk_bphy: add support for enqueue operation Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 13/28] raw/cnxk_bphy: add support for dequeue operation Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 14/28] raw/cnxk_bphy: add support for performing selftest Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 15/28] common/cnxk: add support for device init and fini Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 16/28] common/cnxk: add support for baseband phy irq setup Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 17/28] common/cnxk: add support for checking irq availability Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 18/28] common/cnxk: add support for retrieving irq stack Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 19/28] common/cnxk: add support for removing " Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 20/28] common/cnxk: add support for setting bphy irq handler Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 21/28] common/cnxk: add support for clearing " Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 22/28] common/cnxk: add support for registering bphy irq Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 23/28] raw/cnxk_bphy: add baseband phy skeleton driver Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 24/28] raw/cnxk_bphy: add support for interrupt init and cleanup Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 25/28] raw/cnxk_bphy: add support for reading number of irqs Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 26/28] raw/cnxk_bphy: add support for retrieving device memory Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 27/28] raw/cnxk_bphy: add support for registering irq handlers Tomasz Duszynski
2021-05-31 21:41 ` [dpdk-dev] [PATCH 28/28] raw/cnxk_bphy: add support for selftest Tomasz Duszynski
2021-06-10 6:54 ` [dpdk-dev] [PATCH 00/28] add support for baseband phy Jerin Jacob
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 00/32] " Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 01/32] common/cnxk: add bphy cgx/rpm initialization and cleanup Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 02/32] common/cnxk: support for communication with atf Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 03/32] common/cnxk: support for getting link information Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 04/32] common/cnxk: support for changing internal loopback Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 05/32] common/cnxk: support for changing ptp mode Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 06/32] common/cnxk: support for setting link mode Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 07/32] common/cnxk: support for changing link state Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 08/32] common/cnxk: support for lmac start/stop Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 09/32] raw/cnxk_bphy: add bphy cgx/rpm skeleton driver Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 10/32] raw/cnxk_bphy: support for reading queue configuration Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 11/32] raw/cnxk_bphy: support for reading queue count Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 12/32] raw/cnxk_bphy: support for enqueue operation Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 13/32] raw/cnxk_bphy: support for dequeue operation Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 14/32] raw/cnxk_bphy: support for performing selftest Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 15/32] common/cnxk: support for device init and fini Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 16/32] common/cnxk: support for baseband PHY irq setup Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 17/32] common/cnxk: support for checking irq availability Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 18/32] common/cnxk: support for retrieving irq stack Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 19/32] common/cnxk: support for removing " Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 20/32] common/cnxk: support for setting bphy irq handler Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 21/32] common/cnxk: support for clearing " Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 22/32] common/cnxk: support for registering bphy irq Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 23/32] raw/cnxk_bphy: add baseband PHY skeleton driver Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 24/32] raw/cnxk_bphy: support for reading bphy queue configuration Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 25/32] raw/cnxk_bphy: support for reading bphy queue count Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 26/32] raw/cnxk_bphy: support for bphy enqueue operation Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 27/32] raw/cnxk_bphy: support for bphy dequeue operation Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 28/32] raw/cnxk_bphy: support for interrupt init and cleanup Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 29/32] raw/cnxk_bphy: support for reading number of bphy irqs Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 30/32] raw/cnxk_bphy: support for retrieving bphy device memory Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 31/32] raw/cnxk_bphy: support for registering bphy irq handlers Tomasz Duszynski
2021-06-15 11:03 ` [dpdk-dev] [PATCH v2 32/32] raw/cnxk_bphy: support for bphy selftest Tomasz Duszynski
2021-06-21 8:43 ` Jerin Jacob [this message]
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 00/32] add support for baseband phy Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 01/32] common/cnxk: add bphy cgx/rpm initialization and cleanup Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 02/32] common/cnxk: support for communication with atf Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 03/32] common/cnxk: support for getting link information Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 04/32] common/cnxk: support for changing internal loopback Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 05/32] common/cnxk: support for changing ptp mode Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 06/32] common/cnxk: support for setting link mode Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 07/32] common/cnxk: support for changing link state Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 08/32] common/cnxk: support for lmac start/stop Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 09/32] raw/cnxk_bphy: add bphy cgx/rpm skeleton driver Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 10/32] raw/cnxk_bphy: support for reading queue configuration Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 11/32] raw/cnxk_bphy: support for reading queue count Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 12/32] raw/cnxk_bphy: support for enqueue operation Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 13/32] raw/cnxk_bphy: support for dequeue operation Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 14/32] raw/cnxk_bphy: support for performing selftest Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 15/32] common/cnxk: support for device init and fini Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 16/32] common/cnxk: support for baseband PHY irq setup Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 17/32] common/cnxk: support for checking irq availability Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 18/32] common/cnxk: support for retrieving irq stack Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 19/32] common/cnxk: support for removing " Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 20/32] common/cnxk: support for setting bphy irq handler Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 21/32] common/cnxk: support for clearing " Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 22/32] common/cnxk: support for registering bphy irq Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 23/32] raw/cnxk_bphy: add baseband PHY skeleton driver Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 24/32] raw/cnxk_bphy: support for reading bphy queue configuration Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 25/32] raw/cnxk_bphy: support for reading bphy queue count Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 26/32] raw/cnxk_bphy: support for bphy enqueue operation Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 27/32] raw/cnxk_bphy: support for bphy dequeue operation Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 28/32] raw/cnxk_bphy: support for interrupt init and cleanup Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 29/32] raw/cnxk_bphy: support for reading number of bphy irqs Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 30/32] raw/cnxk_bphy: support for retrieving bphy device memory Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 31/32] raw/cnxk_bphy: support for registering bphy irq handlers Tomasz Duszynski
2021-06-21 15:04 ` [dpdk-dev] [PATCH v3 32/32] raw/cnxk_bphy: support for bphy selftest Tomasz Duszynski
2021-07-05 21:12 ` [dpdk-dev] [PATCH v3 00/32] add support for baseband phy Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1MzK7LaZiYr=-NXYdf1EppfGjb1dBVoAnXEmpNaaBT9DQ@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=tduszynski@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).