From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 66885A0C41;
	Tue,  3 Aug 2021 09:25:54 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2AC6840E32;
	Tue,  3 Aug 2021 09:25:54 +0200 (CEST)
Received: from mail-il1-f171.google.com (mail-il1-f171.google.com
 [209.85.166.171])
 by mails.dpdk.org (Postfix) with ESMTP id 66DE440683
 for <dev@dpdk.org>; Tue,  3 Aug 2021 09:25:52 +0200 (CEST)
Received: by mail-il1-f171.google.com with SMTP id a14so18749264ila.1
 for <dev@dpdk.org>; Tue, 03 Aug 2021 00:25:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=B5add8C3fSlOjUQD6gx68XHgBUXJbIPpQW18QOjTfJI=;
 b=gG2PUKLsRBC21bwTijDAagr3bHowlsTCnSJgRzCEo8ljOALOZ680tdr9z47b72mxDP
 TjxkYhw9psyeKaB1TiXdbi933MzYyxockyO+0KnskQQFWnw1y1L+c92qFaTHuOINIX7v
 3s5N2+3kUObCgkgiB8Vj/VkIg8kzyDXyt/3KaN/7EVQv0DQen3jMGftog7nQTrL1dWoG
 nhkSSNggK2ZF4bkBHbiu//EkS+JRVk2HPXsy8JEqoc6TKaiuRQkgdYa1S5I3tCg8sbmc
 cvWcWaRGeCEtJTzVAmhFzyqpZO0Vq8PYEhuAaD7xT5cPXvKOBdCTFD39sS7aLnq6uvlC
 c0KA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=B5add8C3fSlOjUQD6gx68XHgBUXJbIPpQW18QOjTfJI=;
 b=qpvrssOhfIt7P00L0i26aQqOxh90p1sj5CSuXqYptgta4ZHdpMn7LsviguRiZAGTaM
 /HRztq2iKfg4wTUXORvaoUne/tMaeu3F1xRf45krOFAl3Yca0BxQbcibmmIW3erL21nT
 x9jMbTr9nH3ghyMT8fhK5ANZWQRf6SYlYBKBUdTzzoyRABVCabQQILWQyJbyZYETbKZl
 w88QGg/c1ZF3buzTypxlGabENXNL5RqFKPhJdKmpmUN6MVvs6CWYHn8RDYNS0JHsWct3
 2PpX2qoAgryT+jwn9gXRHCwFN5ciQ+QrcDL9FbIxhN9lKLjlC7XoShUTtEHUUkKohNZq
 bkTA==
X-Gm-Message-State: AOAM5338yqV5MsoftgShfIH1Ibl1MRv7izI3Rq+b9GYQZg4X0RRIA4hN
 vMeDDRw7cw2o4jHh4LvwCA/nAmvf4CQVb5JB09I=
X-Google-Smtp-Source: ABdhPJxeXP5jMw1nE3t8DV9A4DsxqTzRCVrWSnmIoGNljuAlznmpSSaTPG07aYRmGw5xQOFIh299Yk0ZxVFKz2BMg6I=
X-Received: by 2002:a05:6e02:5cc:: with SMTP id
 l12mr2818951ils.60.1627975551788; 
 Tue, 03 Aug 2021 00:25:51 -0700 (PDT)
MIME-Version: 1.0
References: <20210730214453.19975-1-honnappa.nagarahalli@arm.com>
 <AM5PR0802MB246596B32B7CEDBD234C0C619EF09@AM5PR0802MB2465.eurprd08.prod.outlook.com>
In-Reply-To: <AM5PR0802MB246596B32B7CEDBD234C0C619EF09@AM5PR0802MB2465.eurprd08.prod.outlook.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Tue, 3 Aug 2021 12:55:25 +0530
Message-ID: <CALBAE1N-3tPFHkKw6MGWOQLQAN4OJwviLq47ngS_27KQ5N3yLA@mail.gmail.com>
To: Ruifeng Wang <Ruifeng.Wang@arm.com>
Cc: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
 "dev@dpdk.org" <dev@dpdk.org>, 
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
 "lucp.at.work@gmail.com" <lucp.at.work@gmail.com>, 
 "david.marchand@redhat.com" <david.marchand@redhat.com>,
 "thomas@monjalon.net" <thomas@monjalon.net>, nd <nd@arm.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] doc: abstract the behaviour of
 rte_ctrl_thread_create
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Aug 3, 2021 at 11:24 AM Ruifeng Wang <Ruifeng.Wang@arm.com> wrote:
>
> > -----Original Message-----
> > From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Sent: Saturday, July 31, 2021 5:45 AM
> > To: dev@dpdk.org; Honnappa Nagarahalli
> > <Honnappa.Nagarahalli@arm.com>; olivier.matz@6wind.com;
> > lucp.at.work@gmail.com; david.marchand@redhat.com;
> > thomas@monjalon.net
> > Cc: Ruifeng Wang <Ruifeng.Wang@arm.com>; nd <nd@arm.com>
> > Subject: [PATCH] doc: abstract the behaviour of rte_ctrl_thread_create
> >
> > The current expected behaviour of the function rte_ctrl_thread_create is
> > rigid which makes the implementation of the function complex.
> > Make the expected behaviour abstract to allow for simplified
> > implementation.
> >
> > With this change, the calls to pthread_setaffinity_np can be moved to the
> > control thread. This will avoid the use of pthread_barrier_wait and simplify
> > the synchronization mechanism between rte_ctrl_thread_create and the
> > calling thread.
> >
> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > ---
> > Possible patch is at:
> > http://patches.dpdk.org/project/dpdk/patch/20210730213709.19400-1-
> > honnappa.nagarahalli@arm.com/
> >
> >  doc/guides/rel_notes/deprecation.rst | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index 9584d6bfd7..1960e3c8bf 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -11,6 +11,13 @@ here.
> >  Deprecation Notices
> >  -------------------
> >
> > +* eal: The expected behaviour of the function
> > +``rte_ctrl_thread_create``
> > +  abstracted to allow for simplified implementation. The new behaviour
> > +is
> > +  as follows:
> > +  Creates a control thread with the given name. The affinity of the new
> > +  thread is based on the CPU affinity retrieved at the time
> > +rte_eal_init()
> > +  was called, the dataplane and service lcores are then excluded.
> > +
> >  * kvargs: The function ``rte_kvargs_process`` will get a new parameter
> >    for returning key match count. It will ease handling of no-match case.
> >
> > --
> > 2.17.1
> Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>