From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 474EDA034E; Thu, 6 Jan 2022 13:25:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 340364114E; Thu, 6 Jan 2022 13:25:52 +0100 (CET) Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by mails.dpdk.org (Postfix) with ESMTP id A4D364114E for ; Thu, 6 Jan 2022 13:25:50 +0100 (CET) Received: by mail-il1-f182.google.com with SMTP id x15so1922137ilc.5 for ; Thu, 06 Jan 2022 04:25:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9Rz8AYZ5hCPhTpA6eOgoAJZk/XvxEuJBqS5QTZA9jF0=; b=AWQZ7LICtmL4XgLHrttVQFE3ImR1fQRdeNj/v/o2BcWTGyWhQhAPzSzo3jj+8Q/Ghq 4HKwz8EiRlBvUTvCANIwsNQT6haa02Oj/m5WRV6EbT+vXyZvahzaEBMBgrF0zO0YeRRl LdGMyaOWQFJWb8Ey7PjPBkY+5tLJrImNmjzkuGD5PYJETvNfckiNJzzJvpk3+QlYp7AZ 7q9TCXWjEdF9rN5q37KWk7aBy8aYUJCnS+mMtjIj4G09d/VfSejDbXLCb9VRfPHganM4 5LfOYgq9OyFNsynwB+hC5i3M+W8SZgk7ErXyMF0qGswuSG0pyjKvWHgVaZZQFFlwip7C oixA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9Rz8AYZ5hCPhTpA6eOgoAJZk/XvxEuJBqS5QTZA9jF0=; b=fq7Veir5kleah8JWva4YQy/Zmomd24czgm2xan+GgRB5n9omPPOV3917/ecfovDt87 RA0HSr/hx459vcC9F5Tt77958ZM46Vxw5BZOkIobFNo6MSzYcwGGlfPdItQyfzlBZf1F O5aJPlc3qhOrERzS17DjrGuA+EZrQ/IM2HpL7Y7pyu4LM4AIgDRvtyrt3JezK6G/n5Uw wWeK/KM51NuqBo1YaB3wjczAdT5T/AhrXrsIdgab/Ktziu0+R0+eAg7Trf0cuULXVmir gnB/TL//9KVLMAU2IuD5vgvNoZdsKJawva5bnHo8xlttoYernEFec7LRpEi+3rIicOfj 8yEQ== X-Gm-Message-State: AOAM531yLICoY3PKKpUl5/2kVD2DoxYGT6b1BVUUlV29j6lqQQHqNvyx Pn1uYUuvEaQ8T1GKkdugbI3sRzXZ/AemrtQQhq4= X-Google-Smtp-Source: ABdhPJyGZcoA4qwBsal5ZvL5THk87HU7uQlG9Hh8V4m7araJkoWnoE9gYy9rr1Wgx+IXAbgsR5w3sse3ndSVNpfZjRk= X-Received: by 2002:a05:6e02:dcc:: with SMTP id l12mr29626087ilj.75.1641471950004; Thu, 06 Jan 2022 04:25:50 -0800 (PST) MIME-Version: 1.0 References: <20211130053822.2696736-1-asekhar@marvell.com> In-Reply-To: <20211130053822.2696736-1-asekhar@marvell.com> From: Jerin Jacob Date: Thu, 6 Jan 2022 17:55:23 +0530 Message-ID: Subject: Re: [PATCH] common/cnxk: ensure ROC cache alignment of NPA stack size To: Ashwin Sekhar T K , Andrew Rybchenko , Ferruh Yigit Cc: dpdk-dev , Nithin Dabilpuram , Jerin Jacob , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Pavan Nikhilesh , Kiran Kumar K , Satheesh Paul , Anoob Joseph , Akhil Goyal Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 30, 2021 at 11:11 AM Ashwin Sekhar T K wrote: > > When PLT_CACHE_LINE_SIZE is set to 64B, the memzone size reserved for > NPA stack could be a multiple of 64B. In such a case, when NDC SYNC > is initiated for the NPA LF, it could go and corrupt an additional > 64B bytes as NDC flushes in multiples of ROC cache line size (128B). > > So ensure that NPA stack size requested is a multiple of 128B. > > Signed-off-by: Ashwin Sekhar T K Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/common/cnxk/roc_npa.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c > index efcb7582eb..75fc22442f 100644 > --- a/drivers/common/cnxk/roc_npa.c > +++ b/drivers/common/cnxk/roc_npa.c > @@ -205,6 +205,7 @@ static inline const struct plt_memzone * > npa_stack_dma_alloc(struct npa_lf *lf, char *name, int pool_id, size_t size) > { > const char *mz_name = npa_stack_memzone_name(lf, pool_id, name); > + size = PLT_ALIGN_CEIL(size, ROC_ALIGN); > > return plt_memzone_reserve_aligned(mz_name, size, 0, ROC_ALIGN); > } > -- > 2.32.0 >