From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EA5DA00C4; Fri, 30 Sep 2022 11:03:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7143841109; Fri, 30 Sep 2022 11:03:09 +0200 (CEST) Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by mails.dpdk.org (Postfix) with ESMTP id 67A8440684; Fri, 30 Sep 2022 11:03:08 +0200 (CEST) Received: by mail-qk1-f171.google.com with SMTP id x18so2414194qkn.6; Fri, 30 Sep 2022 02:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=5svhGJI5w05QJPdK8nGIOIECUTz89UETM/031cWT39c=; b=VpIpV7mABu6ZEDsRVm6ge1cfay4P+brUfnNYjOLgsGrk/sGDcgOq5EehoqR+jdwgYj dPAFVaTalET2lhNGrFUifHN02eT/foUtO5ASRRORPejiFNf3znf/e2cSsNLCMLJAqlSK Rs5YUftODF1HTPwoa8CcZ6zXnREju/h9ipbKeCQ4WmEEXim6AsqEOw1d81Nb2ERH6cSj oYG4JDEKPfsZVZy00xjrr/Aql/4bGRjS39BsRtsOzxu0nXuj6/dnt6cglOVTtClrf8vB i5xbc8WuuWfc8/qujLxyprsjw3ka/KZZ0Ae1Px/3TYEEfuvS0Bd0nhyYMxMtfEhjZYP/ LEEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=5svhGJI5w05QJPdK8nGIOIECUTz89UETM/031cWT39c=; b=Q8eJPHMi/b6gmoTuushuj6YYAuuoE9ctjoO3na+Z65KQ7GbJoO25pAxLV4JkR4wL5O IoQk2zp5rn3PfyCe2YMXTTdXv3u3HypOVnWEUgK0G6LfSueWAftKPlK/gBscy/OyyS8l 04ZTTnkfQ7zT+0+FHM3U11XYwDNo/BL1kAb2l8hHDMK6sE0f6No7nIs6yElIrItPD8gi i5+Rgyv29AAsDmaNrhSqvMJXSEgfBkQgnCV0o8ao17Rs6hq5qwYCeSYZwgGK9cTLEw7r G74bF7dW/LSaIPAqjvXRfNQrP2Zrn+7ZYROLcuc2tI0qYGlkaB4s+/DIweS2LlMvhlJ4 V9hA== X-Gm-Message-State: ACrzQf1UtTKY0Nm6sgR8GMYu4hxp1Mfj9XXOdaTfkaAwrba0cLD8oLjQ g4JRvXd1btQ6+HEOq4aif7579lfZRgk4+6Djrj4= X-Google-Smtp-Source: AMsMyM47DMTR6/iHiSTu/52FBfweaLc+qp3mKuHahRZUL2DvsJwoUd4WUoakFhOSXCzyGa0/hondv+bF8dYymJgnabY= X-Received: by 2002:a37:e319:0:b0:6cd:f643:b6d6 with SMTP id y25-20020a37e319000000b006cdf643b6d6mr5255953qki.616.1664528587779; Fri, 30 Sep 2022 02:03:07 -0700 (PDT) MIME-Version: 1.0 References: <20220927150537.1464936-1-abdullah.sevincer@intel.com> <20220928184419.1618909-1-abdullah.sevincer@intel.com> In-Reply-To: <20220928184419.1618909-1-abdullah.sevincer@intel.com> From: Jerin Jacob Date: Fri, 30 Sep 2022 14:32:41 +0530 Message-ID: Subject: Re: [PATCH v5] event/dlb2: fix max enqueue and dequeue cli override To: Abdullah Sevincer Cc: dev@dpdk.org, jerinj@marvell.com, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 29, 2022 at 12:14 AM Abdullah Sevincer wrote: > > This patch addresses an issue of enqueuing more than > max_enq_depth and not able to dequeuing events equal > to max_cq_depth in a single call of rte_event_enqueue_burst > and rte_event_dequeue_burst. > > Apply fix for restricting enqueue of events to max_enq_depth > so that in a single rte_event_enqueue_burst() call at most > max_enq_depth events are enqueued. > > Also set per port and domain history list sizes based on > cq_depth. This results in dequeuing correct number of > events as set by max_cq_depth. > > Fixes: f3cad285bb88 ("event/dlb2: add infos get and configure") > Cc: stable@dpdk.org > > Signed-off-by: Abdullah Sevincer Not sure what "cli" means in the subject. Changed the subject as " event/dlb2: handle enqueuing more than max enq depth" Applied to dpdk-next-net-eventdev/for-main. Thanks > --- > drivers/event/dlb2/dlb2.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c > index 759578378f..dbb8284135 100644 > --- a/drivers/event/dlb2/dlb2.c > +++ b/drivers/event/dlb2/dlb2.c > @@ -813,7 +813,7 @@ dlb2_hw_create_sched_domain(struct dlb2_eventdev *dlb2, > cfg->num_ldb_queues; > > cfg->num_hist_list_entries = resources_asked->num_ldb_ports * > - DLB2_NUM_HIST_LIST_ENTRIES_PER_LDB_PORT; > + evdev_dlb2_default_info.max_event_port_dequeue_depth; > > if (device_version == DLB2_HW_V2_5) { > DLB2_LOG_DBG("sched domain create - ldb_qs=%d, ldb_ports=%d, dir_ports=%d, atomic_inflights=%d, hist_list_entries=%d, credits=%d\n", > @@ -1538,7 +1538,7 @@ dlb2_hw_create_ldb_port(struct dlb2_eventdev *dlb2, > cfg.cq_depth = rte_align32pow2(dequeue_depth); > cfg.cq_depth_threshold = 1; > > - cfg.cq_history_list_size = DLB2_NUM_HIST_LIST_ENTRIES_PER_LDB_PORT; > + cfg.cq_history_list_size = cfg.cq_depth; > > cfg.cos_id = ev_port->cos_id; > cfg.cos_strict = 0;/* best effots */ > @@ -2966,6 +2966,7 @@ __dlb2_event_enqueue_burst(void *event_port, > struct dlb2_port *qm_port = &ev_port->qm_port; > struct process_local_port_data *port_data; > int retries = ev_port->enq_retries; > + int num_tx; > int i; > > RTE_ASSERT(ev_port->enq_configured); > @@ -2974,8 +2975,8 @@ __dlb2_event_enqueue_burst(void *event_port, > i = 0; > > port_data = &dlb2_port[qm_port->id][PORT_TYPE(qm_port)]; > - > - while (i < num) { > + num_tx = RTE_MIN(num, ev_port->conf.enqueue_depth); > + while (i < num_tx) { > uint8_t sched_types[DLB2_NUM_QES_PER_CACHE_LINE]; > uint8_t queue_ids[DLB2_NUM_QES_PER_CACHE_LINE]; > int pop_offs = 0; > -- > 2.25.1 >