Re: [PATCH v1] eventdev/eth_rx: sub event type gets reset

[Jerin Jacob <jerinjacobk@gmail.com>]

On Wed, Sep 14, 2022 at 11:52 AM Kundapura, Ganapati
<ganapati.kundapura@intel.com> wrote:
>
> Hi Jay,
>
> > -----Original Message-----
> > From: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > Sent: 13 September 2022 22:32
> > To: Kundapura, Ganapati <ganapati.kundapura@intel.com>; dev@dpdk.org;
> > jerinj@marvell.com
> > Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > Subject: RE: [PATCH v1] eventdev/eth_rx: sub event type gets reset
> >
> > > -----Original Message-----
> > > From: Kundapura, Ganapati <ganapati.kundapura@intel.com>
> > > Sent: Tuesday, September 13, 2022 12:32 PM
> > > To: dev@dpdk.org; jerinj@marvell.com
> > > Cc: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Naga Harish K, S
> > > V <s.v.naga.harish.k@intel.com>
> > > Subject: [PATCH v1] eventdev/eth_rx: sub event type gets reset
> > >
> > > In rte_event_eth_rx_adapter_queue_add(), sub_event_type of
> > rte_event
> > > structure is reset which is used by the application
> >
> > Just a minor comment - application may or may not use this field. "which can
> > be used" is better suited. Rest looks good. Thanks for posting.
> Updated commit message as suggested in V2
> >
> > With this change,
> > Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
> >
> Added Ack with commit header change in V2

Updated the git commit as follows and applied v2 to
dpdk-next-net-eventdev/for-main. Thanks


    eventdev/eth_rx: remove resetting sub event type

    In rte_event_eth_rx_adapter_queue_add(), sub_event_type of
    rte_event structure is reset which can be used by the
    application to determine the processing function.

    Removed resetting of rte_event::sub_event_type

    Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
    Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>


> > > to determine the processing function.
> > >
> > > Removed resetting of rte_event::sub_event_type
> > >
> > > Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
> > >
> > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c
> > > b/lib/eventdev/rte_event_eth_rx_adapter.c
> > > index 64a6add..e42e41c 100644
> > > --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> > > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> > > @@ -2054,7 +2054,6 @@ rxa_add_queue(struct event_eth_rx_adapter
> > *rx_adapter,
> > >     qi_ev->event = ev->event;
> > >     qi_ev->op = RTE_EVENT_OP_NEW;
> > >     qi_ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER;
> > > -   qi_ev->sub_event_type = 0;
> > >
> > >     if (conf->rx_queue_flags &
> > >
> >       RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) {
> > > --
> > > 2.6.4
>