From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39244A00C5; Wed, 14 Sep 2022 15:42:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C34D84021D; Wed, 14 Sep 2022 15:42:30 +0200 (CEST) Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by mails.dpdk.org (Postfix) with ESMTP id 5E01440156 for ; Wed, 14 Sep 2022 15:42:29 +0200 (CEST) Received: by mail-qk1-f172.google.com with SMTP id k12so10823737qkj.8 for ; Wed, 14 Sep 2022 06:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=OaXysWdK4Z2C7riKR8iCcsbf2lqJ+0AOwgIxFuGkwWc=; b=b3QHnlcsXO1O5kBYCU31J3dy0fWGJi8bWg4LcvFyASyqBf1qimVdu2yFHG/A56fyVS zC8uNRGMYldYUy1hOHUZj+ZXSpxgzDomB+09TBVmeAhPY61h+raDus2pfE9H4HrwaoyW vJ8KLfQK+6vQBeHuiyB9M6rRkQOmGG2rpYgbQ4b+AyVNGZN5c2BDJbMmHVOen+Kdd8O7 R9l6KQoh9p38W32iJtzX0jMmR6YqMi+Vw8pFsGrPtlJInOaNQTZN5p10rb9Sg0hLvMbI sYRg3Iap4XljdDznVoVQ58+hzNa5Uyt45jMPucqY+0TSJpKL0GRwl7Dpom4rLZJmok7C rIzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=OaXysWdK4Z2C7riKR8iCcsbf2lqJ+0AOwgIxFuGkwWc=; b=PCkNlm8Qncgg+8fQDyAy7SPZ3pmOZqu+1prkLxiHJbgzJagcIoE9SK140Njo50CyAm kJ/VJgYJdq+QUOY5wJilbHFw3AumzT+zgI6L1n9qnfxQZDy9JdPJ40deGvVup0dbw6Vu AfMhtlCHM4J7+VJyLnod1nuhNZLQD9h1cxr5CeSvhfPOQhlM2ADfmfyDSteLfA6b4tY+ duVb9+UjmlDxPw8HZMIPQflKrjMguOQwB6NnyRaa6xzHygkB8bgWyCQK6xUBT7Ieldzk F8JCecmNBvNJwvQiySI0gdL5daVXNUHyvrWmmwZIv2xQQqg+E92u4VF8o62mRWxG8q2m RLvA== X-Gm-Message-State: ACgBeo0GlnMULcho+FHvhKJ//w2jFAyt/FRs/yerYfo3z7wwyrL1Q4CD 5QiTgzeaTa6VcZwxpDH6SvHv8crWNjg7mPwPKKE= X-Google-Smtp-Source: AA6agR7ZvIUDg5byAp1FOPZGD5XjQ9bfOPzUOIEnOoG5valKcJ9YkYetvCu4Sxo/Md+MXLmj/8WYGJdXMf0H07XR5Dk= X-Received: by 2002:ae9:efc4:0:b0:6cb:e44c:723a with SMTP id d187-20020ae9efc4000000b006cbe44c723amr19456373qkg.402.1663162948728; Wed, 14 Sep 2022 06:42:28 -0700 (PDT) MIME-Version: 1.0 References: <20220913070205.1108906-1-ganapati.kundapura@intel.com> In-Reply-To: From: Jerin Jacob Date: Wed, 14 Sep 2022 19:12:02 +0530 Message-ID: Subject: Re: [PATCH v1] eventdev/eth_rx: sub event type gets reset To: "Kundapura, Ganapati" Cc: "Jayatheerthan, Jay" , "dev@dpdk.org" , "jerinj@marvell.com" , "Naga Harish K, S V" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Sep 14, 2022 at 11:52 AM Kundapura, Ganapati wrote: > > Hi Jay, > > > -----Original Message----- > > From: Jayatheerthan, Jay > > Sent: 13 September 2022 22:32 > > To: Kundapura, Ganapati ; dev@dpdk.org; > > jerinj@marvell.com > > Cc: Naga Harish K, S V > > Subject: RE: [PATCH v1] eventdev/eth_rx: sub event type gets reset > > > > > -----Original Message----- > > > From: Kundapura, Ganapati > > > Sent: Tuesday, September 13, 2022 12:32 PM > > > To: dev@dpdk.org; jerinj@marvell.com > > > Cc: Jayatheerthan, Jay ; Naga Harish K, S > > > V > > > Subject: [PATCH v1] eventdev/eth_rx: sub event type gets reset > > > > > > In rte_event_eth_rx_adapter_queue_add(), sub_event_type of > > rte_event > > > structure is reset which is used by the application > > > > Just a minor comment - application may or may not use this field. "which can > > be used" is better suited. Rest looks good. Thanks for posting. > Updated commit message as suggested in V2 > > > > With this change, > > Acked-by: Jay Jayatheerthan > > > Added Ack with commit header change in V2 Updated the git commit as follows and applied v2 to dpdk-next-net-eventdev/for-main. Thanks eventdev/eth_rx: remove resetting sub event type In rte_event_eth_rx_adapter_queue_add(), sub_event_type of rte_event structure is reset which can be used by the application to determine the processing function. Removed resetting of rte_event::sub_event_type Signed-off-by: Ganapati Kundapura Acked-by: Jay Jayatheerthan > > > to determine the processing function. > > > > > > Removed resetting of rte_event::sub_event_type > > > > > > Signed-off-by: Ganapati Kundapura > > > > > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c > > > b/lib/eventdev/rte_event_eth_rx_adapter.c > > > index 64a6add..e42e41c 100644 > > > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > > > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > > > @@ -2054,7 +2054,6 @@ rxa_add_queue(struct event_eth_rx_adapter > > *rx_adapter, > > > qi_ev->event = ev->event; > > > qi_ev->op = RTE_EVENT_OP_NEW; > > > qi_ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER; > > > - qi_ev->sub_event_type = 0; > > > > > > if (conf->rx_queue_flags & > > > > > RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) { > > > -- > > > 2.6.4 >