DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
@ 2021-04-12 13:20 Jerin Jacob Kollanukkaran
  2021-04-12 13:27 ` McDaniel, Timothy
  2021-04-12 22:12 ` Thomas Monjalon
  0 siblings, 2 replies; 18+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2021-04-12 13:20 UTC (permalink / raw)
  To: Thomas Monjalon, abhinandan.gujjar, Timothy McDaniel,
	Jerin Jacob Kollanukkaran, harry.van.haaren
  Cc: dev, Shijith Thotton, Akhil Goyal, Pavan Nikhilesh Bhagavatula,
	mattias.ronnblom

Patched moved to next  pull-request for next RC1
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

1) http://patches.dpdk.org/user/todo/dpdk/?series=16285 (Waiting for @abhinandan.gujjar@intel.com Ack)
2) http://patches.dpdk.org/project/dpdk/patch/8d73cf4b565f5f66badaca26ec3a9f26cedf2304.1618217424.git.sthotton@marvell.com/ 	(Waiting for @abhinandan.gujjar@intel.com Ack)

Patches moved to next  pull-request for RC2
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1) event/dlb2 rework( Waiting for @Timothy McDaniel's next version)
2) event/cnxk addition ( Waiting for @Jerin Jacob Kollanukkaran Review)


Patched moved to v21.08
~~~~~~~~~~~~~~~~~~~~~
1) http://patches.dpdk.org/project/dpdk/patch/20210409113223.65260-1-mattias.ronnblom@ericsson.com/ (Waiting for Review from @harry.van.haaren@intel.com @Jerin Jacob Kollanukkaran for RFC patch)


Hi @Thomas Monjalon

The following changes since commit b40d7062ff2e065fb617494589ee810766e12a19:

  net/dpaa2: fix RSS distribution size field (2021-04-09 11:00:30 +0200)

are available in the Git repository at:

  http://dpdk.org/git/next/dpdk-next-eventdev

for you to fetch changes up to 36a402db0966a64cbf9d133d2d982b234a0ff9fb:

  event/octeontx2: fix device reconfigure for single slot (2021-04-12 12:53:34 +0530)

----------------------------------------------------------------
Harman Kalra (1):
      event/octeontx2: fix device reconfigure for single slot

Harry van Haaren (1):
      event/sw: add xstats to expose progress details

Mattias Rönnblom (1):
      event/dsw: use GCC built-ins for atomics

Pavan Nikhilesh (14):
      test/event: fix timeout accuracy
      event/octeontx2: fix xaq pool reconfigure
      app/eventdev: fix timeout accuracy
      event/octeontx2: simplify timer bucket estimation
      event/octeontx2: optimize timer arm routine
      event/octeontx2: reduce chunk pool memory usage
      event/octeontx2: timer always use virtual counter
      eventdev: introduce event vector capability
      eventdev: introduce event vector Rx capability
      eventdev: introduce event vector Tx capability
      eventdev: add Rx adapter event vector support
      eventdev: add Tx adapter event vector support
      app/eventdev: add event vector mode in pipeline test
      doc: announce event Rx adapter config changes

Shijith Thotton (3):
      eventdev: introduce adapter flags for periodic mode
      test/event: add unit tests for periodic timer
      event/octeontx2: add timer periodic mode support

Timothy McDaniel (1):
       event/dlb: remove dlb driver


MAINTAINERS                                        |    5 -
 app/test-eventdev/evt_common.h                     |    4 +
 app/test-eventdev/evt_options.c                    |   52 +
 app/test-eventdev/evt_options.h                    |    4 +
 app/test-eventdev/test_perf_common.c               |   22 +-
 app/test-eventdev/test_pipeline_atq.c              |  310 +-
 app/test-eventdev/test_pipeline_common.c           |  113 +-
 app/test-eventdev/test_pipeline_common.h           |   18 +
 app/test-eventdev/test_pipeline_queue.c            |  318 +-
 app/test/test_event_timer_adapter.c                |  142 +-
 app/test/test_eventdev.c                           |    7 -
 config/rte_config.h                                |    6 -
 doc/api/doxy-api-index.md                          |    1 -
 doc/api/doxy-api.conf.in                           |    1 -
 doc/guides/eventdevs/dlb.rst                       |  341 -
 doc/guides/eventdevs/index.rst                     |    1 -
 .../prog_guide/event_ethernet_rx_adapter.rst       |   57 +
 .../prog_guide/event_ethernet_tx_adapter.rst       |   12 +
 doc/guides/prog_guide/event_timer_adapter.rst      |   16 +-
 doc/guides/prog_guide/eventdev.rst                 |   36 +-
 doc/guides/rel_notes/deprecation.rst               |    9 +
 doc/guides/rel_notes/release_20_11.rst             |    3 +-
 doc/guides/rel_notes/release_21_05.rst             |   16 +
 doc/guides/tools/testeventdev.rst                  |   45 +-
 drivers/common/octeontx2/otx2_mbox.h               |    7 +
 drivers/event/dlb/dlb.c                            | 4085 ------------
 drivers/event/dlb/dlb_iface.c                      |   79 -
 drivers/event/dlb/dlb_iface.h                      |   82 -
 drivers/event/dlb/dlb_inline_fns.h                 |   36 -
 drivers/event/dlb/dlb_log.h                        |   25 -
 drivers/event/dlb/dlb_priv.h                       |  511 --
 drivers/event/dlb/dlb_selftest.c                   | 1544 -----
 drivers/event/dlb/dlb_user.h                       |  814 ---
 drivers/event/dlb/dlb_xstats.c                     | 1212 ----
 drivers/event/dlb/meson.build                      |   22 -
 drivers/event/dlb/pf/base/dlb_hw_types.h           |  334 -
 drivers/event/dlb/pf/base/dlb_osdep.h              |  310 -
 drivers/event/dlb/pf/base/dlb_osdep_bitmap.h       |  441 --
 drivers/event/dlb/pf/base/dlb_osdep_list.h         |  131 -
 drivers/event/dlb/pf/base/dlb_osdep_types.h        |   31 -
 drivers/event/dlb/pf/base/dlb_regs.h               | 2368 -------
 drivers/event/dlb/pf/base/dlb_resource.c           | 6904 --------------------
 drivers/event/dlb/pf/base/dlb_resource.h           |  876 ---
 drivers/event/dlb/pf/dlb_main.c                    |  552 --
 drivers/event/dlb/pf/dlb_main.h                    |   44 -
 drivers/event/dlb/pf/dlb_pf.c                      |  755 ---
 drivers/event/dlb/rte_pmd_dlb.c                    |   38 -
 drivers/event/dlb/rte_pmd_dlb.h                    |   77 -
 drivers/event/dlb/version.map                      |    9 -
 drivers/event/dsw/dsw_evdev.c                      |    5 +-
 drivers/event/dsw/dsw_evdev.h                      |    6 +-
 drivers/event/dsw/dsw_event.c                      |   37 +-
 drivers/event/dsw/dsw_xstats.c                     |    4 +-
 drivers/event/meson.build                          |    2 +-
 drivers/event/octeontx2/otx2_evdev.c               |   65 +-
drivers/event/octeontx2/otx2_tim_evdev.c           |  145 +-
 drivers/event/octeontx2/otx2_tim_evdev.h           |  109 +-
 drivers/event/octeontx2/otx2_tim_worker.c          |    9 +-
 drivers/event/octeontx2/otx2_tim_worker.h          |  211 +-
 drivers/event/sw/sw_evdev.h                        |    2 +
 drivers/event/sw/sw_evdev_scheduler.c              |   13 +
 drivers/event/sw/sw_evdev_selftest.c               |   28 +-
 drivers/event/sw/sw_evdev_xstats.c                 |    9 +-
 lib/librte_eventdev/eventdev_pmd.h                 |   60 +-
 lib/librte_eventdev/rte_event_eth_rx_adapter.c     |  386 +-
 lib/librte_eventdev/rte_event_eth_rx_adapter.h     |  108 +
 lib/librte_eventdev/rte_event_eth_tx_adapter.c     |   66 +-
 lib/librte_eventdev/rte_event_timer_adapter.h      |   13 +
 lib/librte_eventdev/rte_eventdev.c                 |   53 +-
 lib/librte_eventdev/rte_eventdev.h                 |  117 +-
 lib/librte_eventdev/version.map                    |    5 +
 71 files changed, 2209 insertions(+), 22070 deletions(-)
 delete mode 100644 doc/guides/eventdevs/dlb.rst
 delete mode 100644 drivers/event/dlb/dlb.c
 delete mode 100644 drivers/event/dlb/dlb_iface.c
 delete mode 100644 drivers/event/dlb/dlb_iface.h
 delete mode 100644 drivers/event/dlb/dlb_inline_fns.h
 delete mode 100644 drivers/event/dlb/dlb_log.h
 delete mode 100644 drivers/event/dlb/dlb_priv.h
 delete mode 100644 drivers/event/dlb/dlb_selftest.c
 delete mode 100644 drivers/event/dlb/dlb_user.h
 delete mode 100644 drivers/event/dlb/dlb_xstats.c
 delete mode 100644 drivers/event/dlb/meson.build
 delete mode 100644 drivers/event/dlb/pf/base/dlb_hw_types.h
 delete mode 100644 drivers/event/dlb/pf/base/dlb_osdep.h
 delete mode 100644 drivers/event/dlb/pf/base/dlb_osdep_bitmap.h
 delete mode 100644 drivers/event/dlb/pf/base/dlb_osdep_list.h
 delete mode 100644 drivers/event/dlb/pf/base/dlb_osdep_types.h
 delete mode 100644 drivers/event/dlb/pf/base/dlb_regs.h
 delete mode 100644 drivers/event/dlb/pf/base/dlb_resource.c
 delete mode 100644 drivers/event/dlb/pf/base/dlb_resource.h
 delete mode 100644 drivers/event/dlb/pf/dlb_main.c
 delete mode 100644 drivers/event/dlb/pf/dlb_main.h
 delete mode 100644 drivers/event/dlb/pf/dlb_pf.c
 delete mode 100644 drivers/event/dlb/rte_pmd_dlb.c
 delete mode 100644 drivers/event/dlb/rte_pmd_dlb.h
 delete mode 100644 drivers/event/dlb/version.map

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
  2021-04-12 13:20 [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1 Jerin Jacob Kollanukkaran
@ 2021-04-12 13:27 ` McDaniel, Timothy
  2021-04-12 13:40   ` Jerin Jacob
  2021-04-12 22:12 ` Thomas Monjalon
  1 sibling, 1 reply; 18+ messages in thread
From: McDaniel, Timothy @ 2021-04-12 13:27 UTC (permalink / raw)
  To: Jerin Jacob Kollanukkaran, Thomas Monjalon, Gujjar, Abhinandan S,
	Van Haaren, Harry
  Cc: dev, Shijith Thotton, Akhil Goyal, Pavan Nikhilesh Bhagavatula,
	mattias.ronnblom


> -----Original Message-----
> From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Sent: Monday, April 12, 2021 8:20 AM
> To: Thomas Monjalon <thomas@monjalon.net>; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>; McDaniel, Timothy
> <timothy.mcdaniel@intel.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Van Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org; Shijith Thotton <sthotton@marvell.com>; Akhil Goyal
> <gakhil@marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; mattias.ronnblom
> <mattias.ronnblom@ericsson.com>
> Subject: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
> 
> Patched moved to next  pull-request for next RC1
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> 1) http://patches.dpdk.org/user/todo/dpdk/?series=16285 (Waiting for
> @abhinandan.gujjar@intel.com Ack)
> 2)
> http://patches.dpdk.org/project/dpdk/patch/8d73cf4b565f5f66badaca26ec3a9f
> 26cedf2304.1618217424.git.sthotton@marvell.com/ 	(Waiting for
> @abhinandan.gujjar@intel.com Ack)
> 
> Patches moved to next  pull-request for RC2
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1) event/dlb2 rework( Waiting for @Timothy McDaniel's next version)
> 2) event/cnxk addition ( Waiting for @Jerin Jacob Kollanukkaran Review)
> 
> 
> Patched moved to v21.08
> ~~~~~~~~~~~~~~~~~~~~~
> 1) http://patches.dpdk.org/project/dpdk/patch/20210409113223.65260-1-
> mattias.ronnblom@ericsson.com/ (Waiting for Review from
> @harry.van.haaren@intel.com @Jerin Jacob Kollanukkaran for RFC patch)
> 
> 
> Hi @Thomas Monjalon
> 
> The following changes since commit
> b40d7062ff2e065fb617494589ee810766e12a19:
> 
>   net/dpaa2: fix RSS distribution size field (2021-04-09 11:00:30 +0200)
> 
> are available in the Git repository at:
> 
>   http://dpdk.org/git/next/dpdk-next-eventdev
> 
> for you to fetch changes up to 36a402db0966a64cbf9d133d2d982b234a0ff9fb:
> 
>   event/octeontx2: fix device reconfigure for single slot (2021-04-12 12:53:34
> +0530)
> 
> ----------------------------------------------------------------
> Harman Kalra (1):
>       event/octeontx2: fix device reconfigure for single slot
> 
> Harry van Haaren (1):
>       event/sw: add xstats to expose progress details
> 
> Mattias Rönnblom (1):
>       event/dsw: use GCC built-ins for atomics
> 
> Pavan Nikhilesh (14):
>       test/event: fix timeout accuracy
>       event/octeontx2: fix xaq pool reconfigure
>       app/eventdev: fix timeout accuracy
>       event/octeontx2: simplify timer bucket estimation
>       event/octeontx2: optimize timer arm routine
>       event/octeontx2: reduce chunk pool memory usage
>       event/octeontx2: timer always use virtual counter
>       eventdev: introduce event vector capability
>       eventdev: introduce event vector Rx capability
>       eventdev: introduce event vector Tx capability
>       eventdev: add Rx adapter event vector support
>       eventdev: add Tx adapter event vector support
>       app/eventdev: add event vector mode in pipeline test
>       doc: announce event Rx adapter config changes
> 
> Shijith Thotton (3):
>       eventdev: introduce adapter flags for periodic mode
>       test/event: add unit tests for periodic timer
>       event/octeontx2: add timer periodic mode support
> 
> Timothy McDaniel (1):
>        event/dlb: remove dlb driver
> 
> 
> MAINTAINERS                                        |    5 -
>  app/test-eventdev/evt_common.h                     |    4 +
>  app/test-eventdev/evt_options.c                    |   52 +
>  app/test-eventdev/evt_options.h                    |    4 +
>  app/test-eventdev/test_perf_common.c               |   22 +-
>  app/test-eventdev/test_pipeline_atq.c              |  310 +-
>  app/test-eventdev/test_pipeline_common.c           |  113 +-
>  app/test-eventdev/test_pipeline_common.h           |   18 +
>  app/test-eventdev/test_pipeline_queue.c            |  318 +-
>  app/test/test_event_timer_adapter.c                |  142 +-
>  app/test/test_eventdev.c                           |    7 -
>  config/rte_config.h                                |    6 -
>  doc/api/doxy-api-index.md                          |    1 -
>  doc/api/doxy-api.conf.in                           |    1 -
>  doc/guides/eventdevs/dlb.rst                       |  341 -
>  doc/guides/eventdevs/index.rst                     |    1 -
>  .../prog_guide/event_ethernet_rx_adapter.rst       |   57 +
>  .../prog_guide/event_ethernet_tx_adapter.rst       |   12 +
>  doc/guides/prog_guide/event_timer_adapter.rst      |   16 +-
>  doc/guides/prog_guide/eventdev.rst                 |   36 +-
>  doc/guides/rel_notes/deprecation.rst               |    9 +
>  doc/guides/rel_notes/release_20_11.rst             |    3 +-
>  doc/guides/rel_notes/release_21_05.rst             |   16 +
>  doc/guides/tools/testeventdev.rst                  |   45 +-
>  drivers/common/octeontx2/otx2_mbox.h               |    7 +
>  drivers/event/dlb/dlb.c                            | 4085 ------------
>  drivers/event/dlb/dlb_iface.c                      |   79 -
>  drivers/event/dlb/dlb_iface.h                      |   82 -
>  drivers/event/dlb/dlb_inline_fns.h                 |   36 -
>  drivers/event/dlb/dlb_log.h                        |   25 -
>  drivers/event/dlb/dlb_priv.h                       |  511 --
>  drivers/event/dlb/dlb_selftest.c                   | 1544 -----
>  drivers/event/dlb/dlb_user.h                       |  814 ---
>  drivers/event/dlb/dlb_xstats.c                     | 1212 ----
>  drivers/event/dlb/meson.build                      |   22 -
>  drivers/event/dlb/pf/base/dlb_hw_types.h           |  334 -
>  drivers/event/dlb/pf/base/dlb_osdep.h              |  310 -
>  drivers/event/dlb/pf/base/dlb_osdep_bitmap.h       |  441 --
>  drivers/event/dlb/pf/base/dlb_osdep_list.h         |  131 -
>  drivers/event/dlb/pf/base/dlb_osdep_types.h        |   31 -
>  drivers/event/dlb/pf/base/dlb_regs.h               | 2368 -------
>  drivers/event/dlb/pf/base/dlb_resource.c           | 6904 --------------------
>  drivers/event/dlb/pf/base/dlb_resource.h           |  876 ---
>  drivers/event/dlb/pf/dlb_main.c                    |  552 --
>  drivers/event/dlb/pf/dlb_main.h                    |   44 -
>  drivers/event/dlb/pf/dlb_pf.c                      |  755 ---
>  drivers/event/dlb/rte_pmd_dlb.c                    |   38 -
>  drivers/event/dlb/rte_pmd_dlb.h                    |   77 -
>  drivers/event/dlb/version.map                      |    9 -
>  drivers/event/dsw/dsw_evdev.c                      |    5 +-
>  drivers/event/dsw/dsw_evdev.h                      |    6 +-
>  drivers/event/dsw/dsw_event.c                      |   37 +-
>  drivers/event/dsw/dsw_xstats.c                     |    4 +-
>  drivers/event/meson.build                          |    2 +-
>  drivers/event/octeontx2/otx2_evdev.c               |   65 +-
> drivers/event/octeontx2/otx2_tim_evdev.c           |  145 +-
>  drivers/event/octeontx2/otx2_tim_evdev.h           |  109 +-
>  drivers/event/octeontx2/otx2_tim_worker.c          |    9 +-
>  drivers/event/octeontx2/otx2_tim_worker.h          |  211 +-
>  drivers/event/sw/sw_evdev.h                        |    2 +
>  drivers/event/sw/sw_evdev_scheduler.c              |   13 +
>  drivers/event/sw/sw_evdev_selftest.c               |   28 +-
>  drivers/event/sw/sw_evdev_xstats.c                 |    9 +-
>  lib/librte_eventdev/eventdev_pmd.h                 |   60 +-
>  lib/librte_eventdev/rte_event_eth_rx_adapter.c     |  386 +-
>  lib/librte_eventdev/rte_event_eth_rx_adapter.h     |  108 +
>  lib/librte_eventdev/rte_event_eth_tx_adapter.c     |   66 +-
>  lib/librte_eventdev/rte_event_timer_adapter.h      |   13 +
>  lib/librte_eventdev/rte_eventdev.c                 |   53 +-
>  lib/librte_eventdev/rte_eventdev.h                 |  117 +-
>  lib/librte_eventdev/version.map                    |    5 +
>  71 files changed, 2209 insertions(+), 22070 deletions(-)
>  delete mode 100644 doc/guides/eventdevs/dlb.rst
>  delete mode 100644 drivers/event/dlb/dlb.c
>  delete mode 100644 drivers/event/dlb/dlb_iface.c
>  delete mode 100644 drivers/event/dlb/dlb_iface.h
>  delete mode 100644 drivers/event/dlb/dlb_inline_fns.h
>  delete mode 100644 drivers/event/dlb/dlb_log.h
>  delete mode 100644 drivers/event/dlb/dlb_priv.h
>  delete mode 100644 drivers/event/dlb/dlb_selftest.c
>  delete mode 100644 drivers/event/dlb/dlb_user.h
>  delete mode 100644 drivers/event/dlb/dlb_xstats.c
>  delete mode 100644 drivers/event/dlb/meson.build
>  delete mode 100644 drivers/event/dlb/pf/base/dlb_hw_types.h
>  delete mode 100644 drivers/event/dlb/pf/base/dlb_osdep.h
>  delete mode 100644 drivers/event/dlb/pf/base/dlb_osdep_bitmap.h
>  delete mode 100644 drivers/event/dlb/pf/base/dlb_osdep_list.h
>  delete mode 100644 drivers/event/dlb/pf/base/dlb_osdep_types.h
>  delete mode 100644 drivers/event/dlb/pf/base/dlb_regs.h
>  delete mode 100644 drivers/event/dlb/pf/base/dlb_resource.c
>  delete mode 100644 drivers/event/dlb/pf/base/dlb_resource.h
>  delete mode 100644 drivers/event/dlb/pf/dlb_main.c
>  delete mode 100644 drivers/event/dlb/pf/dlb_main.h
>  delete mode 100644 drivers/event/dlb/pf/dlb_pf.c
>  delete mode 100644 drivers/event/dlb/rte_pmd_dlb.c
>  delete mode 100644 drivers/event/dlb/rte_pmd_dlb.h
>  delete mode 100644 drivers/event/dlb/version.map

Jerin,

I had sent you an email last week asking for clarification on your request that I use git mv.

Thanks, Tim

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
  2021-04-12 13:27 ` McDaniel, Timothy
@ 2021-04-12 13:40   ` Jerin Jacob
  0 siblings, 0 replies; 18+ messages in thread
From: Jerin Jacob @ 2021-04-12 13:40 UTC (permalink / raw)
  To: McDaniel, Timothy
  Cc: Jerin Jacob Kollanukkaran, Thomas Monjalon, Gujjar, Abhinandan S,
	Van Haaren, Harry, dev, Shijith Thotton, Akhil Goyal,
	Pavan Nikhilesh Bhagavatula, mattias.ronnblom

On Mon, Apr 12, 2021 at 6:57 PM McDaniel, Timothy
<timothy.mcdaniel@intel.com> wrote:

> Jerin,
>
> I had sent you an email last week asking for clarification on your request that I use git mv.

@McDaniel, Timothy  Could you share the link for patchwork link for the same.

>
> Thanks, Tim

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
  2021-04-12 13:20 [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1 Jerin Jacob Kollanukkaran
  2021-04-12 13:27 ` McDaniel, Timothy
@ 2021-04-12 22:12 ` Thomas Monjalon
  2021-04-13  7:15   ` David Marchand
  1 sibling, 1 reply; 18+ messages in thread
From: Thomas Monjalon @ 2021-04-12 22:12 UTC (permalink / raw)
  To: Jerin Jacob Kollanukkaran
  Cc: abhinandan.gujjar, Timothy McDaniel, harry.van.haaren, dev,
	Shijith Thotton, Akhil Goyal, Pavan Nikhilesh Bhagavatula,
	mattias.ronnblom, david.marchand

12/04/2021 15:20, Jerin Jacob Kollanukkaran:
>   http://dpdk.org/git/next/dpdk-next-eventdev

Pulled, thanks.

Note few changes in titles like uppercases for acronyms,
or "add support" simplified as "support",
and release notes moved in the right place.




^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
  2021-04-12 22:12 ` Thomas Monjalon
@ 2021-04-13  7:15   ` David Marchand
  2021-04-13  7:31     ` Thomas Monjalon
                       ` (3 more replies)
  0 siblings, 4 replies; 18+ messages in thread
From: David Marchand @ 2021-04-13  7:15 UTC (permalink / raw)
  To: Thomas Monjalon, Timothy McDaniel, Jerin Jacob Kollanukkaran,
	Ray Kinsella, Aaron Conole, dpdklab
  Cc: abhinandan.gujjar, harry.van.haaren, dev, Shijith Thotton,
	Akhil Goyal, Pavan Nikhilesh Bhagavatula, mattias.ronnblom, ci

On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 12/04/2021 15:20, Jerin Jacob Kollanukkaran:
> >   http://dpdk.org/git/next/dpdk-next-eventdev
>
> Pulled, thanks.
>
> Note few changes in titles like uppercases for acronyms,
> or "add support" simplified as "support",
> and release notes moved in the right place.

The ABI check now reports an error on event/dlb.
The reason is that the event/dlb driver has been removed, and so the
check complains about a missing dump.
This will have to be fixed quickly or reverted.


This has been missed by multiple people, so trying to understand why.

The ABI check should have caught this when run by maintainers (/me
looks at Thomas and Jerin).

The CI should have caught it too.
But, v1 did not apply.
For v2, I can see a doc generation issue reported by Intel CI that I
can't reproduce, so it could be just noise.
I can't find reports for Travis or GHA and I could not find in the
robot logs why the series_15708 branch was not created.

Looking at UNH reports:
http://mails.dpdk.org/archives/test-report/2021-March/182956.html
But looking at the log:
[2713/2716] Compiling C object
'drivers/a715181@@rte_event_octeontx2@sta/meson-generated_.._rte_event_octeontx2.pmd.c.o'.
[2714/2716] Linking static target drivers/librte_event_octeontx2.a.
[2715/2716] Generating rte_event_octeontx2.sym_chk with a meson_exe.py
custom command.
[2716/2716] Linking target drivers/librte_event_octeontx2.so.21.1.
Error: cannot find librte_event_dlb.dump in
/home-local/jenkins-local/jenkins-agent/workspace/Ubuntu18.04-Compile-DPDK-ABI/dpdk/build-gcc-shared/install

Is this something that has been fixed since then?

I don't have the main branch/recent series status from UNH, but at
least GHA and Travis are now complaining about ABI.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
  2021-04-13  7:15   ` David Marchand
@ 2021-04-13  7:31     ` Thomas Monjalon
  2021-04-13  8:45     ` [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check Thomas Monjalon
                       ` (2 subsequent siblings)
  3 siblings, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2021-04-13  7:31 UTC (permalink / raw)
  To: David Marchand
  Cc: Timothy McDaniel, Jerin Jacob Kollanukkaran, Ray Kinsella,
	Aaron Conole, dpdklab, abhinandan.gujjar, harry.van.haaren, dev,
	Shijith Thotton, Akhil Goyal, Pavan Nikhilesh Bhagavatula,
	mattias.ronnblom, ci, ferruh.yigit

13/04/2021 09:15, David Marchand:
> On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 12/04/2021 15:20, Jerin Jacob Kollanukkaran:
> > >   http://dpdk.org/git/next/dpdk-next-eventdev
> >
> > Pulled, thanks.
> >
> > Note few changes in titles like uppercases for acronyms,
> > or "add support" simplified as "support",
> > and release notes moved in the right place.
> 
> The ABI check now reports an error on event/dlb.
> The reason is that the event/dlb driver has been removed, and so the
> check complains about a missing dump.
> This will have to be fixed quickly or reverted.
> 
> 
> This has been missed by multiple people, so trying to understand why.
> 
> The ABI check should have caught this when run by maintainers (/me
> looks at Thomas and Jerin).
> 
> The CI should have caught it too.
> But, v1 did not apply.
> For v2, I can see a doc generation issue reported by Intel CI that I
> can't reproduce, so it could be just noise.
> I can't find reports for Travis or GHA and I could not find in the
> robot logs why the series_15708 branch was not created.
> 
> Looking at UNH reports:
> http://mails.dpdk.org/archives/test-report/2021-March/182956.html
> But looking at the log:
> [2713/2716] Compiling C object
> 'drivers/a715181@@rte_event_octeontx2@sta/meson-generated_.._rte_event_octeontx2.pmd.c.o'.
> [2714/2716] Linking static target drivers/librte_event_octeontx2.a.
> [2715/2716] Generating rte_event_octeontx2.sym_chk with a meson_exe.py
> custom command.
> [2716/2716] Linking target drivers/librte_event_octeontx2.so.21.1.
> Error: cannot find librte_event_dlb.dump in
> /home-local/jenkins-local/jenkins-agent/workspace/Ubuntu18.04-Compile-DPDK-ABI/dpdk/build-gcc-shared/install
> 
> Is this something that has been fixed since then?
> 
> I don't have the main branch/recent series status from UNH, but at
> least GHA and Travis are now complaining about ABI.

Sorry about that, this is because I stupidly thought I could fix it
locally without thinking about the CI.
I am going to send a patch for devtools/libabigail.abignore.



^ permalink raw reply	[flat|nested] 18+ messages in thread

* [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check
  2021-04-13  7:15   ` David Marchand
  2021-04-13  7:31     ` Thomas Monjalon
@ 2021-04-13  8:45     ` Thomas Monjalon
  2021-04-13  9:15       ` David Marchand
  2021-04-13 16:09       ` Kinsella, Ray
  2021-04-13  8:54     ` [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1 Jerin Jacob
  2021-04-13 12:58     ` Aaron Conole
  3 siblings, 2 replies; 18+ messages in thread
From: Thomas Monjalon @ 2021-04-13  8:45 UTC (permalink / raw)
  To: dev; +Cc: jerinj, David Marchand, Ray Kinsella, Neil Horman, Timothy McDaniel

The eventdev driver DLB was removed in DPDK 21.05,
breaking the ABI check.
The exception was agreed so we just need to skip this check.

Note: complete removal of a driver cannot be ignored
in devtools/libabigail.abignore, so the script must be patched.

Fixes: 698fa829415d ("event/dlb: remove driver")

Reported-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
This should have been done as part of removing the driver.
The CI is currently broken, so it should be merged today.
---
 devtools/check-abi.sh | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh
index 9835e346da..ca523eb94c 100755
--- a/devtools/check-abi.sh
+++ b/devtools/check-abi.sh
@@ -44,6 +44,10 @@ for dump in $(find $refdir -name "*.dump"); do
 		echo "Skipped glue library $name."
 		continue
 	fi
+	if grep -qE "\<soname='librte_event_dlb\.so" $dump; then
+		echo "Skipped removed driver $name."
+		continue
+	fi
 	dump2=$(find $newdir -name $name)
 	if [ -z "$dump2" ] || [ ! -e "$dump2" ]; then
 		echo "Error: cannot find $name in $newdir" >&2
-- 
2.31.1


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
  2021-04-13  7:15   ` David Marchand
  2021-04-13  7:31     ` Thomas Monjalon
  2021-04-13  8:45     ` [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check Thomas Monjalon
@ 2021-04-13  8:54     ` Jerin Jacob
  2021-04-13  9:01       ` Thomas Monjalon
  2021-04-13  9:07       ` David Marchand
  2021-04-13 12:58     ` Aaron Conole
  3 siblings, 2 replies; 18+ messages in thread
From: Jerin Jacob @ 2021-04-13  8:54 UTC (permalink / raw)
  To: David Marchand
  Cc: Thomas Monjalon, Timothy McDaniel, Jerin Jacob Kollanukkaran,
	Ray Kinsella, Aaron Conole, dpdklab, abhinandan.gujjar,
	harry.van.haaren, dev, Shijith Thotton, Akhil Goyal,
	Pavan Nikhilesh Bhagavatula, mattias.ronnblom, ci

On Tue, Apr 13, 2021 at 12:46 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 12/04/2021 15:20, Jerin Jacob Kollanukkaran:
> > >   http://dpdk.org/git/next/dpdk-next-eventdev
> >
> > Pulled, thanks.
> >
> > Note few changes in titles like uppercases for acronyms,
> > or "add support" simplified as "support",
> > and release notes moved in the right place.
>
> The ABI check now reports an error on event/dlb.
> The reason is that the event/dlb driver has been removed, and so the
> check complains about a missing dump.
> This will have to be fixed quickly or reverted.
>
>
> This has been missed by multiple people, so trying to understand why.


I was running the following script[1] to detect ABI issues.
Since the "./devtools/test-meson-builds.sh" did not return non zero value or
the error print was "Error: cannot find librte_event_dlb.dump", It is
missed from my side.

@David Marchand  @Thomas Monjalon Could you share the snippet you are
using for detecting the ABI issue.


------------------------
# ABI check
DPDK_ABI_REF_VERSION=v20.11 DPDK_ABI_REF_DIR=/tmp bash
./devtools/test-meson-builds.sh 1> /tmp/build.log 2> /tmp/build.log
if [ $? -ne 0 ]; then
        echo "ABI check failed"
        exit
fi

grep "Error: ABI issue reported" /tmp/build.log
if [ $? -eq 0 ]; then
        echo "ABI issue"
        exit
fi

-------------------------------------------------------
>
> The ABI check should have caught this when run by maintainers (/me
> looks at Thomas and Jerin).

Sorry for that :-(

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
  2021-04-13  8:54     ` [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1 Jerin Jacob
@ 2021-04-13  9:01       ` Thomas Monjalon
  2021-04-13  9:07       ` David Marchand
  1 sibling, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2021-04-13  9:01 UTC (permalink / raw)
  To: Jerin Jacob
  Cc: David Marchand, Timothy McDaniel, Jerin Jacob Kollanukkaran,
	Ray Kinsella, Aaron Conole, dpdklab, abhinandan.gujjar,
	harry.van.haaren, dev, Shijith Thotton, Akhil Goyal,
	Pavan Nikhilesh Bhagavatula, mattias.ronnblom, ci

13/04/2021 10:54, Jerin Jacob:
> On Tue, Apr 13, 2021 at 12:46 PM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > >
> > > 12/04/2021 15:20, Jerin Jacob Kollanukkaran:
> > > >   http://dpdk.org/git/next/dpdk-next-eventdev
> > >
> > > Pulled, thanks.
> > >
> > > Note few changes in titles like uppercases for acronyms,
> > > or "add support" simplified as "support",
> > > and release notes moved in the right place.
> >
> > The ABI check now reports an error on event/dlb.
> > The reason is that the event/dlb driver has been removed, and so the
> > check complains about a missing dump.
> > This will have to be fixed quickly or reverted.
> >
> >
> > This has been missed by multiple people, so trying to understand why.
> 
> 
> I was running the following script[1] to detect ABI issues.
> Since the "./devtools/test-meson-builds.sh" did not return non zero value or
> the error print was "Error: cannot find librte_event_dlb.dump", It is
> missed from my side.
> 
> @David Marchand  @Thomas Monjalon Could you share the snippet you are
> using for detecting the ABI issue.

I do like you: simply run test-meson-builds.sh
And yes I saw the error, and I don't know why I thought it was OK!
We are humans :)


> ------------------------
> # ABI check
> DPDK_ABI_REF_VERSION=v20.11 DPDK_ABI_REF_DIR=/tmp bash
> ./devtools/test-meson-builds.sh 1> /tmp/build.log 2> /tmp/build.log
> if [ $? -ne 0 ]; then
>         echo "ABI check failed"
>         exit
> fi
> 
> grep "Error: ABI issue reported" /tmp/build.log
> if [ $? -eq 0 ]; then
>         echo "ABI issue"
>         exit
> fi
> 
> -------------------------------------------------------
> >
> > The ABI check should have caught this when run by maintainers (/me
> > looks at Thomas and Jerin).
> 
> Sorry for that :-(




^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
  2021-04-13  8:54     ` [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1 Jerin Jacob
  2021-04-13  9:01       ` Thomas Monjalon
@ 2021-04-13  9:07       ` David Marchand
  2021-04-13  9:12         ` Thomas Monjalon
  2021-04-13  9:14         ` David Marchand
  1 sibling, 2 replies; 18+ messages in thread
From: David Marchand @ 2021-04-13  9:07 UTC (permalink / raw)
  To: Jerin Jacob
  Cc: Thomas Monjalon, Timothy McDaniel, Jerin Jacob Kollanukkaran,
	Ray Kinsella, Aaron Conole, dpdklab, abhinandan.gujjar,
	harry.van.haaren, dev, Shijith Thotton, Akhil Goyal,
	Pavan Nikhilesh Bhagavatula, mattias.ronnblom, ci

On Tue, Apr 13, 2021 at 10:55 AM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> I was running the following script[1] to detect ABI issues.
> Since the "./devtools/test-meson-builds.sh" did not return non zero value or
> the error print was "Error: cannot find librte_event_dlb.dump", It is
> missed from my side.
>
> @David Marchand  @Thomas Monjalon Could you share the snippet you are
> using for detecting the ABI issue.
>
>
> ------------------------
> # ABI check
> DPDK_ABI_REF_VERSION=v20.11 DPDK_ABI_REF_DIR=/tmp bash

Ah ok, this is because event/dlb did not exist in 20.11.
Running against 21.02, you should get the error.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
  2021-04-13  9:07       ` David Marchand
@ 2021-04-13  9:12         ` Thomas Monjalon
  2021-04-13  9:14         ` David Marchand
  1 sibling, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2021-04-13  9:12 UTC (permalink / raw)
  To: Jerin Jacob, David Marchand
  Cc: Timothy McDaniel, Jerin Jacob Kollanukkaran, Ray Kinsella,
	Aaron Conole, dpdklab, abhinandan.gujjar, harry.van.haaren, dev,
	Shijith Thotton, Akhil Goyal, Pavan Nikhilesh Bhagavatula,
	mattias.ronnblom, ci

13/04/2021 11:07, David Marchand:
> On Tue, Apr 13, 2021 at 10:55 AM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> > I was running the following script[1] to detect ABI issues.
> > Since the "./devtools/test-meson-builds.sh" did not return non zero value or
> > the error print was "Error: cannot find librte_event_dlb.dump", It is
> > missed from my side.
> >
> > @David Marchand  @Thomas Monjalon Could you share the snippet you are
> > using for detecting the ABI issue.
> >
> >
> > ------------------------
> > # ABI check
> > DPDK_ABI_REF_VERSION=v20.11 DPDK_ABI_REF_DIR=/tmp bash
> 
> Ah ok, this is because event/dlb did not exist in 20.11.

No it was added in 20.11.

> Running against 21.02, you should get the error.

Yes we should always run the ABI check against the latest release.
It means you must upgrade DPDK_ABI_REF_VERSION after each release.





^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
  2021-04-13  9:07       ` David Marchand
  2021-04-13  9:12         ` Thomas Monjalon
@ 2021-04-13  9:14         ` David Marchand
  1 sibling, 0 replies; 18+ messages in thread
From: David Marchand @ 2021-04-13  9:14 UTC (permalink / raw)
  To: Jerin Jacob
  Cc: Thomas Monjalon, Timothy McDaniel, Jerin Jacob Kollanukkaran,
	Ray Kinsella, Aaron Conole, dpdklab, abhinandan.gujjar,
	harry.van.haaren, dev, Shijith Thotton, Akhil Goyal,
	Pavan Nikhilesh Bhagavatula, mattias.ronnblom, ci

On Tue, Apr 13, 2021 at 11:07 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Tue, Apr 13, 2021 at 10:55 AM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> > I was running the following script[1] to detect ABI issues.
> > Since the "./devtools/test-meson-builds.sh" did not return non zero value or
> > the error print was "Error: cannot find librte_event_dlb.dump", It is
> > missed from my side.
> >
> > @David Marchand  @Thomas Monjalon Could you share the snippet you are
> > using for detecting the ABI issue.
> >
> >
> > ------------------------
> > # ABI check
> > DPDK_ABI_REF_VERSION=v20.11 DPDK_ABI_REF_DIR=/tmp bash
>
> Ah ok, this is because event/dlb did not exist in 20.11.
> Running against 21.02, you should get the error.

Clicked send too quickly...

No, it did exist.

$ DPDK_ABI_REF_VERSION=v20.11 ./devtools/test-meson-builds.sh
ninja: Entering directory `/home/dmarchan/builds/build-gcc-static'
ninja: no work to do.
ninja: Entering directory `/home/dmarchan/builds/build-gcc-shared'
ninja: no work to do.
Error: cannot find librte_event_dlb.dump in
/home/dmarchan/builds/build-gcc-shared/install

Hum... the next reason I see would be that your reference does not
have event/dlb which is surprising with default configuration.
$ ls $DPDK_ABI_REF_DIR/*/*/dump/*dlb.dump
/home/dmarchan/abi/v20.11/build-clang-shared/dump/librte_event_dlb.dump
 /home/dmarchan/abi/v21.02/build-clang-shared/dump/librte_event_dlb.dump
/home/dmarchan/abi/v20.11/build-gcc-shared/dump/librte_event_dlb.dump
  /home/dmarchan/abi/v21.02/build-gcc-shared/dump/librte_event_dlb.dump


-- 
David Marchand


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check
  2021-04-13  8:45     ` [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check Thomas Monjalon
@ 2021-04-13  9:15       ` David Marchand
  2021-04-13  9:32         ` Thomas Monjalon
  2021-04-13 16:09       ` Kinsella, Ray
  1 sibling, 1 reply; 18+ messages in thread
From: David Marchand @ 2021-04-13  9:15 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dev, Jerin Jacob Kollanukkaran, Ray Kinsella, Neil Horman,
	Timothy McDaniel

On Tue, Apr 13, 2021 at 10:45 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The eventdev driver DLB was removed in DPDK 21.05,
> breaking the ABI check.
> The exception was agreed so we just need to skip this check.
>
> Note: complete removal of a driver cannot be ignored
> in devtools/libabigail.abignore, so the script must be patched.

Indeed, abidiff wants to compare two shared libraries/dumps.
In this situation, we don't have a second library/dump.


>
> Fixes: 698fa829415d ("event/dlb: remove driver")
>
> Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check
  2021-04-13  9:15       ` David Marchand
@ 2021-04-13  9:32         ` Thomas Monjalon
  0 siblings, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2021-04-13  9:32 UTC (permalink / raw)
  To: Jerin Jacob Kollanukkaran, Timothy McDaniel
  Cc: dev, Ray Kinsella, David Marchand

13/04/2021 11:15, David Marchand:
> On Tue, Apr 13, 2021 at 10:45 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > The eventdev driver DLB was removed in DPDK 21.05,
> > breaking the ABI check.
> > The exception was agreed so we just need to skip this check.
> >
> > Note: complete removal of a driver cannot be ignored
> > in devtools/libabigail.abignore, so the script must be patched.
> 
> Indeed, abidiff wants to compare two shared libraries/dumps.
> In this situation, we don't have a second library/dump.
> 
> > Fixes: 698fa829415d ("event/dlb: remove driver")
> >
> > Reported-by: David Marchand <david.marchand@redhat.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Reviewed-by: David Marchand <david.marchand@redhat.com>

Applied




^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1
  2021-04-13  7:15   ` David Marchand
                       ` (2 preceding siblings ...)
  2021-04-13  8:54     ` [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1 Jerin Jacob
@ 2021-04-13 12:58     ` Aaron Conole
  3 siblings, 0 replies; 18+ messages in thread
From: Aaron Conole @ 2021-04-13 12:58 UTC (permalink / raw)
  To: David Marchand
  Cc: Thomas Monjalon, Timothy McDaniel, Jerin Jacob Kollanukkaran,
	Ray Kinsella, dpdklab, abhinandan.gujjar\, harry.van.haaren\,
	dev, Shijith Thotton, Akhil Goyal, Pavan Nikhilesh Bhagavatula,
	mattias.ronnblom\,
	ci

David Marchand <david.marchand@redhat.com> writes:

> On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>>
>> 12/04/2021 15:20, Jerin Jacob Kollanukkaran:
>> >   http://dpdk.org/git/next/dpdk-next-eventdev
>>
>> Pulled, thanks.
>>
>> Note few changes in titles like uppercases for acronyms,
>> or "add support" simplified as "support",
>> and release notes moved in the right place.
>
> The ABI check now reports an error on event/dlb.
> The reason is that the event/dlb driver has been removed, and so the
> check complains about a missing dump.
> This will have to be fixed quickly or reverted.
>
>
> This has been missed by multiple people, so trying to understand why.
>
> The ABI check should have caught this when run by maintainers (/me
> looks at Thomas and Jerin).
>
> The CI should have caught it too.
> But, v1 did not apply.
> For v2, I can see a doc generation issue reported by Intel CI that I
> can't reproduce, so it could be just noise.
> I can't find reports for Travis or GHA and I could not find in the
> robot logs why the series_15708 branch was not created.

I need to go back in the logs - there were a few cases during a
change-over that the robot wasn't running right.

> Looking at UNH reports:
> http://mails.dpdk.org/archives/test-report/2021-March/182956.html
> But looking at the log:
> [2713/2716] Compiling C object
> 'drivers/a715181@@rte_event_octeontx2@sta/meson-generated_.._rte_event_octeontx2.pmd.c.o'.
> [2714/2716] Linking static target drivers/librte_event_octeontx2.a.
> [2715/2716] Generating rte_event_octeontx2.sym_chk with a meson_exe.py
> custom command.
> [2716/2716] Linking target drivers/librte_event_octeontx2.so.21.1.
> Error: cannot find librte_event_dlb.dump in
> /home-local/jenkins-local/jenkins-agent/workspace/Ubuntu18.04-Compile-DPDK-ABI/dpdk/build-gcc-shared/install
>
> Is this something that has been fixed since then?
>
> I don't have the main branch/recent series status from UNH, but at
> least GHA and Travis are now complaining about ABI.


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check
  2021-04-13  8:45     ` [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check Thomas Monjalon
  2021-04-13  9:15       ` David Marchand
@ 2021-04-13 16:09       ` Kinsella, Ray
  2021-04-13 16:44         ` Thomas Monjalon
  1 sibling, 1 reply; 18+ messages in thread
From: Kinsella, Ray @ 2021-04-13 16:09 UTC (permalink / raw)
  To: Thomas Monjalon, dev
  Cc: jerinj, David Marchand, Neil Horman, Timothy McDaniel



On 13/04/2021 09:45, Thomas Monjalon wrote:
> The eventdev driver DLB was removed in DPDK 21.05,
> breaking the ABI check.
> The exception was agreed so we just need to skip this check.
> 
> Note: complete removal of a driver cannot be ignored
> in devtools/libabigail.abignore, so the script must be patched.
> 
> Fixes: 698fa829415d ("event/dlb: remove driver")
> 
> Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> This should have been done as part of removing the driver.
> The CI is currently broken, so it should be merged today.
> ---
>  devtools/check-abi.sh | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh
> index 9835e346da..ca523eb94c 100755
> --- a/devtools/check-abi.sh
> +++ b/devtools/check-abi.sh
> @@ -44,6 +44,10 @@ for dump in $(find $refdir -name "*.dump"); do
>  		echo "Skipped glue library $name."
>  		continue
>  	fi
> +	if grep -qE "\<soname='librte_event_dlb\.so" $dump; then
> +		echo "Skipped removed driver $name."
> +		continue
> +	fi

So this is brute force fix - we can anticipate this problem happening again.
Perhaps a 2nd file called devtools/libabigail.soignore, if agreed I will submit a patch?

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check
  2021-04-13 16:09       ` Kinsella, Ray
@ 2021-04-13 16:44         ` Thomas Monjalon
  2021-04-13 16:45           ` Kinsella, Ray
  0 siblings, 1 reply; 18+ messages in thread
From: Thomas Monjalon @ 2021-04-13 16:44 UTC (permalink / raw)
  To: Kinsella, Ray; +Cc: dev, jerinj, David Marchand, Neil Horman, Timothy McDaniel

13/04/2021 18:09, Kinsella, Ray:
> On 13/04/2021 09:45, Thomas Monjalon wrote:
> > The eventdev driver DLB was removed in DPDK 21.05,
> > breaking the ABI check.
> > The exception was agreed so we just need to skip this check.
> > 
> > Note: complete removal of a driver cannot be ignored
> > in devtools/libabigail.abignore, so the script must be patched.
> > 
> > Fixes: 698fa829415d ("event/dlb: remove driver")
> > 
> > Reported-by: David Marchand <david.marchand@redhat.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > This should have been done as part of removing the driver.
> > The CI is currently broken, so it should be merged today.
> > ---
> >  devtools/check-abi.sh | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh
> > index 9835e346da..ca523eb94c 100755
> > --- a/devtools/check-abi.sh
> > +++ b/devtools/check-abi.sh
> > @@ -44,6 +44,10 @@ for dump in $(find $refdir -name "*.dump"); do
> >  		echo "Skipped glue library $name."
> >  		continue
> >  	fi
> > +	if grep -qE "\<soname='librte_event_dlb\.so" $dump; then
> > +		echo "Skipped removed driver $name."
> > +		continue
> > +	fi
> 
> So this is brute force fix - we can anticipate this problem happening again.
> Perhaps a 2nd file called devtools/libabigail.soignore, if agreed I will submit a patch?

Yes indeed we could have a file for this.
Maybe we could have a dedicated section [suppress_lib]
in the existing file if libabigail is OK with unknown sections?



^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check
  2021-04-13 16:44         ` Thomas Monjalon
@ 2021-04-13 16:45           ` Kinsella, Ray
  0 siblings, 0 replies; 18+ messages in thread
From: Kinsella, Ray @ 2021-04-13 16:45 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dev, jerinj, David Marchand, Neil Horman, Timothy McDaniel



On 13/04/2021 17:44, Thomas Monjalon wrote:
> 13/04/2021 18:09, Kinsella, Ray:
>> On 13/04/2021 09:45, Thomas Monjalon wrote:
>>> The eventdev driver DLB was removed in DPDK 21.05,
>>> breaking the ABI check.
>>> The exception was agreed so we just need to skip this check.
>>>
>>> Note: complete removal of a driver cannot be ignored
>>> in devtools/libabigail.abignore, so the script must be patched.
>>>
>>> Fixes: 698fa829415d ("event/dlb: remove driver")
>>>
>>> Reported-by: David Marchand <david.marchand@redhat.com>
>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>>> ---
>>> This should have been done as part of removing the driver.
>>> The CI is currently broken, so it should be merged today.
>>> ---
>>>  devtools/check-abi.sh | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh
>>> index 9835e346da..ca523eb94c 100755
>>> --- a/devtools/check-abi.sh
>>> +++ b/devtools/check-abi.sh
>>> @@ -44,6 +44,10 @@ for dump in $(find $refdir -name "*.dump"); do
>>>  		echo "Skipped glue library $name."
>>>  		continue
>>>  	fi
>>> +	if grep -qE "\<soname='librte_event_dlb\.so" $dump; then
>>> +		echo "Skipped removed driver $name."
>>> +		continue
>>> +	fi
>>
>> So this is brute force fix - we can anticipate this problem happening again.
>> Perhaps a 2nd file called devtools/libabigail.soignore, if agreed I will submit a patch?
> 
> Yes indeed we could have a file for this.
> Maybe we could have a dedicated section [suppress_lib]
> in the existing file if libabigail is OK with unknown sections?
> 

That would be tidier - I will take a look.

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2021-04-13 16:45 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-12 13:20 [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1 Jerin Jacob Kollanukkaran
2021-04-12 13:27 ` McDaniel, Timothy
2021-04-12 13:40   ` Jerin Jacob
2021-04-12 22:12 ` Thomas Monjalon
2021-04-13  7:15   ` David Marchand
2021-04-13  7:31     ` Thomas Monjalon
2021-04-13  8:45     ` [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check Thomas Monjalon
2021-04-13  9:15       ` David Marchand
2021-04-13  9:32         ` Thomas Monjalon
2021-04-13 16:09       ` Kinsella, Ray
2021-04-13 16:44         ` Thomas Monjalon
2021-04-13 16:45           ` Kinsella, Ray
2021-04-13  8:54     ` [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1 Jerin Jacob
2021-04-13  9:01       ` Thomas Monjalon
2021-04-13  9:07       ` David Marchand
2021-04-13  9:12         ` Thomas Monjalon
2021-04-13  9:14         ` David Marchand
2021-04-13 12:58     ` Aaron Conole

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git